You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/19 07:06:43 UTC
[GitHub] [flink] lirui-apache opened a new pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
lirui-apache opened a new pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625
… constant to Hive constant
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Convert constant Flink object to Hive object before creating Hive's constant object inspectors.
## Brief change log
- Convert the constant value to Hive object in `HiveInspectors::toInspectors`
- Implement our own java constant objector inspectors for char, varchar and decimal
- Add test case
## Verifying this change
New test case
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 closed pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
bowenli86 closed pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361935078
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/module/hive/HiveModuleTest.java
##########
@@ -88,4 +94,24 @@ public void testHiveBuiltInFunction() {
public void testNonExistFunction() {
assertFalse(new HiveModule(HiveShimLoader.getHiveVersion()).getFunctionDefinition("nonexist").isPresent());
}
+
+ @Test
+ public void testConstantArguments() throws Exception {
+ TableEnvironment tEnv = HiveTestUtils.createTableEnvWithBlinkPlannerBatchMode();
+
+ tEnv.unloadModule("core");
+ tEnv.loadModule("hive", new HiveModule(HiveShimLoader.getHiveVersion()));
+
+ List<Row> results = TableUtils.collectToList(tEnv.sqlQuery("select concat('an', 'bn')"));
+ assertEquals("[anbn]", results.toString());
+
+ results = TableUtils.collectToList(tEnv.sqlQuery("select concat('ab', cast('cdefghi' as varchar(5)))"));
Review comment:
Unfortunately we cannot test `null` literals, because Hive functions consider nulls as non-constant arguments: https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveFunction.java#L36
Maybe we should consider all the passed arguments as constant, and don't pass non-constant arguments in the first place. But that'll need to change the interface.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4031 TriggerType:PUSH TriggerID:bd3827ead5cdff406f0f0cceac56c7ff3c591be6
Hash:bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/142833872 TriggerType:PUSH TriggerID:bd3827ead5cdff406f0f0cceac56c7ff3c591be6
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
* bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/142833872) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4031)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-569654679
@JingsongLi PR updated to address your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] bowenli86 commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
bowenli86 commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-569113636
> > Consider using `getPrimitiveWritableConstantObjectInspector`?
> > I tried, and it worked.
>
> @bowenli86 IIRC, you chose to use java constant object inspectors for constant arguments. Is there a reason that we should prefer java to writable object inspectors?
I recall that I might choose java constant oi over writable constant oi because WritableConstantObjectInspector may auto box the java constant which seems not necessary at that time. If auto boxing turns out to be beneficial, we should use it.
BTW, I researched Hive 3.x code base, seems java constant oi is not used anymore, and writable constant oi is the standard now. We should be good to switch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362194203
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
Now this change is moved to b5f0206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361937616
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV310.java
##########
@@ -233,4 +240,23 @@ public LocalDate toFlinkDate(Object hiveDate) {
throw new FlinkHiveException("Failed to convert to Flink date", e);
}
}
+
+ @Override
+ public Writable hivePrimitiveToWritable(Object value) throws CatalogException {
+ try {
+ return super.hivePrimitiveToWritable(value);
+ } catch (CatalogException e) {
Review comment:
Any other good way? exception is a little hacky and low performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361937286
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/module/hive/HiveModuleTest.java
##########
@@ -88,4 +94,24 @@ public void testHiveBuiltInFunction() {
public void testNonExistFunction() {
assertFalse(new HiveModule(HiveShimLoader.getHiveVersion()).getFunctionDefinition("nonexist").isPresent());
}
+
+ @Test
+ public void testConstantArguments() throws Exception {
+ TableEnvironment tEnv = HiveTestUtils.createTableEnvWithBlinkPlannerBatchMode();
+
+ tEnv.unloadModule("core");
+ tEnv.loadModule("hive", new HiveModule(HiveShimLoader.getHiveVersion()));
+
+ List<Row> results = TableUtils.collectToList(tEnv.sqlQuery("select concat('an', 'bn')"));
+ assertEquals("[anbn]", results.toString());
+
+ results = TableUtils.collectToList(tEnv.sqlQuery("select concat('ab', cast('cdefghi' as varchar(5)))"));
Review comment:
And you can add a TODO to the tests.
About null literal support, we should wait for UDF type reworking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-569266869
@JingsongLi @bowenli86 I have updated to use writable OIs for constant arguments, so that we don't need to our own implementations of OIs. Please note:
1. Non-constant arguments still use java OIs, but I can also update that if you think we should be consistent.
2. Also added test for constant DATE and TIMESTAMP values and realized we need a shim for the `java -> writable` conversion.
3. I haven't removed the shim for getting constant OIs. Hopefully it makes review a little bit easier. Can do that if you think we're moving in the right direction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-569042844
> Consider using `getPrimitiveWritableConstantObjectInspector`?
> I tried, and it worked.
@bowenli86 IIRC, you chose to use java constant object inspectors for constant arguments. Is there a reason that we should prefer java to writable object inspectors?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-570106788
travis passed in: https://travis-ci.org/lirui-apache/flink/builds/631257572
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:bd3827ead5cdff406f0f0cceac56c7ff3c591be6
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
* bd3827ead5cdff406f0f0cceac56c7ff3c591be6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362175563
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
And I remember this literal value is internal object, it should be `SqlTimestamp`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xuefuz commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
xuefuz commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362147570
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
What's this change for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361897023
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/module/hive/HiveModuleTest.java
##########
@@ -88,4 +94,24 @@ public void testHiveBuiltInFunction() {
public void testNonExistFunction() {
assertFalse(new HiveModule(HiveShimLoader.getHiveVersion()).getFunctionDefinition("nonexist").isPresent());
}
+
+ @Test
+ public void testConstantArguments() throws Exception {
+ TableEnvironment tEnv = HiveTestUtils.createTableEnvWithBlinkPlannerBatchMode();
+
+ tEnv.unloadModule("core");
+ tEnv.loadModule("hive", new HiveModule(HiveShimLoader.getHiveVersion()));
+
+ List<Row> results = TableUtils.collectToList(tEnv.sqlQuery("select concat('an', 'bn')"));
+ assertEquals("[anbn]", results.toString());
+
+ results = TableUtils.collectToList(tEnv.sqlQuery("select concat('ab', cast('cdefghi' as varchar(5)))"));
Review comment:
Can you add a test for `null` literal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362173968
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
@xuefuz @JingsongLi This is a bug in planner when generating timestamp literals: we pass the type instead of the value as the literal. The added test exposes the issue. Do you think this change needs a dedicated PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362160039
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
Don't mix the planner's single line modification with hive's modification, and there is no test.
You should add a single commit to explain why we need it and what is this bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361936857
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/module/hive/HiveModuleTest.java
##########
@@ -88,4 +94,24 @@ public void testHiveBuiltInFunction() {
public void testNonExistFunction() {
assertFalse(new HiveModule(HiveShimLoader.getHiveVersion()).getFunctionDefinition("nonexist").isPresent());
}
+
+ @Test
+ public void testConstantArguments() throws Exception {
+ TableEnvironment tEnv = HiveTestUtils.createTableEnvWithBlinkPlannerBatchMode();
+
+ tEnv.unloadModule("core");
+ tEnv.loadModule("hive", new HiveModule(HiveShimLoader.getHiveVersion()));
+
+ List<Row> results = TableUtils.collectToList(tEnv.sqlQuery("select concat('an', 'bn')"));
+ assertEquals("[anbn]", results.toString());
+
+ results = TableUtils.collectToList(tEnv.sqlQuery("select concat('ab', cast('cdefghi' as varchar(5)))"));
Review comment:
OK.
Is there any cases to cover null? If not, we can add some whatever whether should be a literal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] xuefuz commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
xuefuz commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362146373
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -232,4 +233,10 @@ SimpleGenericUDAFParameterInfo createUDAFParameterInfo(ObjectInspector[] params,
* Converts a hive date instance to LocalDate which is expected by DataFormatConverter.
*/
LocalDate toFlinkDate(Object hiveDate);
+
+ /**
+ * Converts a Hive primitive java object to corresponding Writable object. Throws CatalogException if the conversion
+ * is not supported.
+ */
+ Writable hivePrimitiveToWritable(Object value) throws CatalogException;
Review comment:
Throwing a catalog ex doesn't seem very intuitive, even though CatalogEx is also a runtime exception. Maybe just remove CatalogEx from the signature and throw a runtime exception when problem occurs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361938203
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimV310.java
##########
@@ -233,4 +240,23 @@ public LocalDate toFlinkDate(Object hiveDate) {
throw new FlinkHiveException("Failed to convert to Flink date", e);
}
}
+
+ @Override
+ public Writable hivePrimitiveToWritable(Object value) throws CatalogException {
+ try {
+ return super.hivePrimitiveToWritable(value);
+ } catch (CatalogException e) {
Review comment:
Maybe I can use optional. Let me have a try
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362191208
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
Right, `ts` is a `SqlTimestamp `. I'll squash and make a separate commit for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142639483 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983 TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142742105 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:b5f020618f6d894a816de3fc7c0c53af295e7ce2 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018 TriggerType:PUSH TriggerID:b5f020618f6d894a816de3fc7c0c53af295e7ce2
Hash:bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4031 TriggerType:PUSH TriggerID:bd3827ead5cdff406f0f0cceac56c7ff3c591be6
Hash:bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142833872 TriggerType:PUSH TriggerID:bd3827ead5cdff406f0f0cceac56c7ff3c591be6
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142639483) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3983)
* b5f020618f6d894a816de3fc7c0c53af295e7ce2 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142742105) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4018)
* bd3827ead5cdff406f0f0cceac56c7ff3c591be6 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142833872) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4031)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:c95faa623e5e0ea94dcb82df536fbe37e724baac Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c95faa623e5e0ea94dcb82df536fbe37e724baac
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
* c95faa623e5e0ea94dcb82df536fbe37e724baac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-570108142
> @lirui-apache Can you organize the format of commits:
> `[FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink constant to Hive constant`
> `[hotfix][table-planner-blink] Fix generating timestamp literal`
@JingsongLi Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-570105548
@lirui-apache Can you organize the format of commits:
`[FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink constant to Hive constant`
`[hotfix][table-planner-blink] Fix generating timestamp literal`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/142456762 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957 TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/142456762) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3957)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r361374941
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/conversion/HiveInspectors.java
##########
@@ -118,6 +118,8 @@
HiveTypeUtil.toHiveTypeInfo(argTypes[i], false));
} else {
PrimitiveTypeInfo primitiveTypeInfo = (PrimitiveTypeInfo) HiveTypeUtil.toHiveTypeInfo(argTypes[i], false);
+ constant = getConversion(getObjectInspector(primitiveTypeInfo), argTypes[i].getLogicalType(), hiveShim)
Review comment:
This is really a blocker...
Without this line, will throw exception...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362175409
##########
File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/GenerateUtils.scala
##########
@@ -375,7 +375,7 @@ object GenerateUtils {
| $SQL_TIMESTAMP.fromEpochMillis(${ts.getMillisecond}L, ${ts.getNanoOfMillisecond});
""".stripMargin
ctx.addReusableMember(fieldTimestamp)
- generateNonNullLiteral(literalType, fieldTerm, literalType)
+ generateNonNullLiteral(literalType, fieldTerm, ts)
Review comment:
I think we don't need to dedicated PR for little changes, but we should a dedicated commit at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#issuecomment-567374884
<!--
Meta data
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:b200938f6abf4bac5e929db791c52289d110054e Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/141714552 TriggerType:PUSH TriggerID:b200938f6abf4bac5e929db791c52289d110054e
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/141863465 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:de8b409c144285a3d75874e4863a2d1f7fc4336a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797 TriggerType:PUSH TriggerID:de8b409c144285a3d75874e4863a2d1f7fc4336a
Hash:d021a016adf64118b785642ffbe1fbe45cb9e15a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d021a016adf64118b785642ffbe1fbe45cb9e15a
-->
## CI report:
* b200938f6abf4bac5e929db791c52289d110054e Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/141714552) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3751)
* de8b409c144285a3d75874e4863a2d1f7fc4336a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/141863465) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=3797)
* d021a016adf64118b785642ffbe1fbe45cb9e15a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #10625: [FLINK-15259][hive] HiveInspector.toInspectors() should convert Flink…
URL: https://github.com/apache/flink/pull/10625#discussion_r362193585
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShim.java
##########
@@ -232,4 +233,10 @@ SimpleGenericUDAFParameterInfo createUDAFParameterInfo(ObjectInspector[] params,
* Converts a hive date instance to LocalDate which is expected by DataFormatConverter.
*/
LocalDate toFlinkDate(Object hiveDate);
+
+ /**
+ * Converts a Hive primitive java object to corresponding Writable object. Throws CatalogException if the conversion
+ * is not supported.
+ */
+ Writable hivePrimitiveToWritable(Object value) throws CatalogException;
Review comment:
I'll change to throw `FlinkHiveException`. It's also a runtime exception but more specific to Hive connector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services