You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "aglinxinyuan (via GitHub)" <gi...@apache.org> on 2026/07/25 07:54:23 UTC
[PR] test(workflow-operator): add unit tests for MySQL and PostgreSQL SourceOpExec [texera]
aglinxinyuan opened a new pull request, #6888:
URL: https://github.com/apache/texera/pull/6888
### What changes were proposed in this PR?
Adds `MySQLSourceOpExecSpec` and `PostgreSQLSourceOpExecSpec` (34 tests) for the two `SQLSourceOpExec` dialect subclasses, both previously at **0% coverage**. They mirror the harness already used by `SQLSourceOpExecSpec`: an in-spec subclass supplying the DB hooks, a `descString` built from a real dialect OpDesc so the polymorphic `operatorType` tag resolves, and ScalaMock JDBC doubles.
Covered per dialect:
- `establishConn` — the exact JDBC URL/properties it dials, and that a `SQLException` propagates rather than being swallowed;
- the `information_schema` table-name query, its bound parameter, draining the `ResultSet`, and closing both it and the statement (plus the empty-listing case);
- `open()` — accepting a present table and rejecting an absent one;
- the dialect-specific keyword search — MySQL `MATCH(...) AGAINST (? IN BOOLEAN MODE)` and PostgreSQL `to_tsvector`, keeping the keyword as a bind parameter — plus the toggle-off, missing-column and non-STRING-column error branches.
No source changes.
### Any related issues, documentation, discussions?
Closes #6885.
### How was this PR tested?
`sbt -java-home <jbr-17> "WorkflowOperator/testOnly *MySQLSourceOpExecSpec *PostgreSQLSourceOpExecSpec"` -> 34 succeeded, 0 failed. `Test/scalafmtCheck` + `Test/scalafix --check` clean.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 4.8 [1M context])
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit tests for MySQL and PostgreSQL SourceOpExec [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan merged PR #6888:
URL: https://github.com/apache/texera/pull/6888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit tests for MySQL and PostgreSQL SourceOpExec [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6888:
URL: https://github.com/apache/texera/pull/6888#issuecomment-5077604742
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 5 better · 🔴 2 worse · ⚪ 8 noise (<±5%) · 0 without baseline
> Compared against main `81d4612` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/30150148596)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 603 | 0.368 | 15,617/25,654/25,654 us | 🔴 +15.6% / 🔴 +54.6% |
| 🟢 | bs=100 sw=10 sl=64 | 1,259 | 0.769 | 77,042/107,675/107,675 us | 🟢 -20.1% / 🟢 +30.0% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,429 | 0.872 | 697,213/725,223/725,223 us | ⚪ within ±5% / 🟢 +42.4% |
<details><summary>Baseline details</summary>
Latest main `81d4612` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 603 tuples/sec | 598 tuples/sec | 754.55 tuples/sec | +0.8% | -20.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.368 MB/s | 0.365 MB/s | 0.461 MB/s | +0.8% | -20.1% |
| bs=10 sw=10 sl=64 | p50 | 15,617 us | 16,276 us | 12,816 us | -4.0% | +21.9% |
| bs=10 sw=10 sl=64 | p95 | 25,654 us | 22,190 us | 16,594 us | +15.6% | +54.6% |
| bs=10 sw=10 sl=64 | p99 | 25,654 us | 22,190 us | 19,806 us | +15.6% | +29.5% |
| bs=100 sw=10 sl=64 | throughput | 1,259 tuples/sec | 1,135 tuples/sec | 969.38 tuples/sec | +10.9% | +29.9% |
| bs=100 sw=10 sl=64 | MB/s | 0.769 MB/s | 0.693 MB/s | 0.592 MB/s | +11.0% | +30.0% |
| bs=100 sw=10 sl=64 | p50 | 77,042 us | 82,904 us | 103,584 us | -7.1% | -25.6% |
| bs=100 sw=10 sl=64 | p95 | 107,675 us | 134,742 us | 109,097 us | -20.1% | -1.3% |
| bs=100 sw=10 sl=64 | p99 | 107,675 us | 134,742 us | 117,304 us | -20.1% | -8.2% |
| bs=1000 sw=10 sl=64 | throughput | 1,429 tuples/sec | 1,456 tuples/sec | 1,004 tuples/sec | -1.9% | +42.4% |
| bs=1000 sw=10 sl=64 | MB/s | 0.872 MB/s | 0.889 MB/s | 0.613 MB/s | -1.9% | +42.4% |
| bs=1000 sw=10 sl=64 | p50 | 697,213 us | 686,343 us | 1,002,357 us | +1.6% | -30.4% |
| bs=1000 sw=10 sl=64 | p95 | 725,223 us | 745,113 us | 1,046,463 us | -2.7% | -30.7% |
| bs=1000 sw=10 sl=64 | p99 | 725,223 us | 745,113 us | 1,073,661 us | -2.7% | -32.5% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,331.63,200,128000,603,0.368,15617.15,25654.01,25654.01
1,100,10,64,20,1588.14,2000,1280000,1259,0.769,77041.54,107674.77,107674.77
2,1000,10,64,20,13996.62,20000,12800000,1429,0.872,697213.00,725223.08,725223.08
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit tests for MySQL and PostgreSQL SourceOpExec [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6888:
URL: https://github.com/apache/texera/pull/6888#issuecomment-5077623710
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/6888?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 78.04%. Comparing base ([`bcf9e01`](https://app.codecov.io/gh/apache/texera/commit/bcf9e014fee7e742c8d2229424fc2a186c2040ad?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2ebaf8b`](https://app.codecov.io/gh/apache/texera/commit/2ebaf8b887fcf645ddbb70f65e0027c62c238e30?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #6888 +/- ##
============================================
+ Coverage 77.35% 78.04% +0.68%
- Complexity 3522 3687 +165
============================================
Files 1161 1161
Lines 46034 46034
Branches 5099 5099
============================================
+ Hits 35611 35928 +317
+ Misses 8842 8480 -362
- Partials 1581 1626 +45
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `76.76% <ø> (ø)` | | Carriedforward from [bcf9e01](https://app.codecov.io/gh/apache/texera/commit/bcf9e014fee7e742c8d2229424fc2a186c2040ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.97% <ø> (+1.87%)` | :arrow_up: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `20.49% <ø> (ø)` | | |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.66% <ø> (ø)` | | |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.21% <ø> (ø)` | | |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.58% <ø> (ø)` | | Carriedforward from [bcf9e01](https://app.codecov.io/gh/apache/texera/commit/bcf9e014fee7e742c8d2229424fc2a186c2040ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.94% <ø> (ø)` | | |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.28% <ø> (ø)` | | Carriedforward from [bcf9e01](https://app.codecov.io/gh/apache/texera/commit/bcf9e014fee7e742c8d2229424fc2a186c2040ad?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/6888/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/6888?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test(workflow-operator): add unit tests for MySQL and PostgreSQL SourceOpExec [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6888:
URL: https://github.com/apache/texera/pull/6888#issuecomment-5077589652
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org