You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/12/18 22:27:06 UTC
[GitHub] brodybits commented on issue #478: Use cross-spawn & shelljs
instead of child-process
brodybits commented on issue #478: Use cross-spawn & shelljs instead of child-process
URL: https://github.com/apache/cordova-ios/pull/478#issuecomment-448395122
I just updated the title and my comments in the description yet again. I was under the mistaken impression that this PR did actually fix the xcodebuild command log, but this is part of #479.
I will raise another followup PR to add the warning that the `spawn` function in `spawn.js` is deprecated.
Another comment is that I think we should do the same thing on cordova-osx, just raised apache/cordova-osx#81 to track this.
I will probably merge this in 10-20 minutes. Thanks again for the contributions!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org