[jira] Commented: (SHINDIG-1003) Proxied image resizing

["Filip Miletic (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SHINDIG-1003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695085#action_12695085 ] 

Filip Miletic commented on SHINDIG-1003:
----------------------------------------

Submitted for code review here: http://codereview.appspot.com/32111

f


> Proxied image resizing
> ----------------------
>
>                 Key: SHINDIG-1003
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1003
>             Project: Shindig
>          Issue Type: New Feature
>          Components: Java
>    Affects Versions: trunk
>            Reporter: Filip Miletic
>         Attachments: fmil-proxied-image-resizing.patch
>
>   Original Estimate: 0h
>  Remaining Estimate: 0h
>
>     The code and cleanup to support proxied image resizing.
>     
>     Based on the initial work of Paul Lindner of Hi5.  His work in turn is
>     based on further contributions, but I don't know at present which ones.
>     
>     New contributions are Copyright (c) 2009 Google.  Rest by Paul Lindner.
>     
> NB: sorry I didn't submit to http://codereview.appspot.com, the UI would not accept my patch file as a valid diff.
>     o Reorganized the image rewriter implementation from Paul, and corrected
>     a few bugs in the image dimensions computation.
>     o A few readability changes.
>     o Verified new behavior and added the tests to guard against accidental
>     further behavior changes.
>     o Modified the caching policy to take into account the resizing URL
>     arguments required for resizing to work.
>     o Factored the cache key building into a builder class that ensures
>     backward compatibility of the generated cache keys, and makes building
>     cache keys easier in general.
>     o Added the tests to guard against accidental behavior changes in the
>     cache key builder.
>     o Fitted all the pieces back together again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.