[jira] [Commented] (QUARKS-195) Metrics.{counter,rateMeter}() shouldn't use TStream.pipe()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QUARKS-195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15319075#comment-15319075 ] 

ASF GitHub Bot commented on QUARKS-195:
---------------------------------------

GitHub user dlaboss opened a pull request:

    https://github.com/apache/incubator-quarks/pull/130

    [QUARKS-195] Metrics.counter needs TStream.peek(oplet)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dlaboss/incubator-quarks quarks-195-metrics-peek

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/130.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #130
    
----
commit 1824df8d362b7ff8d486e8784e235ea98379c054
Author: Dale LaBossiere <dl...@us.ibm.com>
Date:   2016-06-07T18:29:48Z

    [QUARKS-195] Metrics.counter needs TStream.peek(oplet)

----


> Metrics.{counter,rateMeter}() shouldn't use TStream.pipe()
> ----------------------------------------------------------
>
>                 Key: QUARKS-195
>                 URL: https://issues.apache.org/jira/browse/QUARKS-195
>             Project: Quarks
>          Issue Type: Bug
>          Components: API
>            Reporter: Dale LaBossiere
>            Assignee: Dale LaBossiere
>            Priority: Minor
>
> Add `TStream.peek(Peek<T>)` and change `Metrics.counter(TStream)` and `Metrics.rateMeter(TStream)` to use it instead of `pipe()`.
> Using pipe() isn't appropriate as these are Peek ops and it's partially responsible for the effect reported in QUARKS-189.  Changing to peek() will eliminate one of the two extra injected CounterOp and will eliminate the single extra StreamScope.
> The growing number of "oplet" based analogs to the "function" based methods makes me wonder if the oplet ones should be broken out into another interface that TStream implements (`OpletTStream`?).  It would contain the current `pipe(Pipe)`, `fanin(FanIn,List)`, `sink(Sink)`, and the new `peek(Peek)`, and any others that may be needed in the future  - e.g., a `split(Split)` and/or one that can handle multiple iports and oports.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)