You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/30 14:20:11 UTC

[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2567: [Feature][ST-Engine] Notice Task State By TaskExecutionService

EricJoy2048 commented on code in PR #2567:
URL: https://github.com/apache/incubator-seatunnel/pull/2567#discussion_r958546670


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -191,4 +194,16 @@ public JobStatus getJobStatus(long jobId) {
         }
         return runningJobMaster.getJobStatus();
     }
+
+    /**
+     * When TaskGroup ends, it is called by {@link TaskExecutionService} to notify JobMaster the TaskGroup's state.
+     */
+    public void updateTaskExecutionState(TaskExecutionState taskExecutionState) {
+        TaskGroupLocation taskGroupLocation = taskExecutionState.getTaskGroupLocation();
+        JobMaster runningJobMaster = runningJobMasterMap.get(taskGroupLocation.getJobId());
+        if (runningJobMaster == null) {
+            throw new JobException(String.format("Job %s not running", taskGroupLocation.getJobId()));
+        }
+        runningJobMaster.updateTaskExecutionState(taskExecutionState);

Review Comment:
   I will update it in a new pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org