You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "mengw15 (via GitHub)" <gi...@apache.org> on 2026/07/23 07:28:22 UTC
[I] add unit test coverage for OperatorPropertyEditFrameComponent (remaining non-Quill methods) [texera]
mengw15 opened a new issue, #6826:
URL: https://github.com/apache/texera/issues/6826
### Task Summary
`OperatorPropertyEditFrameComponent` sits at codecov ~72% (117 uncovered lines). Goal: **cover the file's remaining unit-testable methods to bring its coverage toward complete** — mock the injected services and exercise every method that doesn't require the Quill rich-text editor. The families below are the likely gap; cover whichever the spec doesn't already hit, plus any other non-Quill method. Only the Quill binding is out of scope. jsdom/Vitest; see `frontend/TESTING.md`.
### Behavior to add
**OperatorPropertyEditFrameComponent** (`frontend/src/app/workspace/component/property-editor/operator-property-edit-frame/operator-property-edit-frame.component.ts`, codecov ~72% — EXTEND; cover all remaining non-Quill methods)
- Modify-logic gating: `checkOperatorProperty` / `allowModifyOperatorLogic` / `confirmModifyOperatorLogic` — assert whether editing is allowed for a running vs idle execution and that confirm applies the change.
- Predicates / transforms (pure): `isHuggingFaceOperator` / `formatTaskTitle` / `hideEnvNameWhenDefaultEnvChecked` / `patchPythonUdfEnvironmentSchema` / `typeInferenceOnLambdaFunction` — assert the returned value/schema for representative operator inputs.
- Form state: `onFormChanges` / `setInteractivity` / `setFormlyFormBinding` / `rerenderEditorForm` — assert the form model / interactivity flag updates.
- Subscription handlers: `registerOperatorPropertyChangeHandler` / `registerOperatorSchemaChangeHandler` / `registerOperatorDisplayNameChangeHandler` / `registerOnFormChangeHandler` / `registerDisableEditorInteractivityHandler` — drive the source event through a mocked service and assert the component reacts.
Out of scope (rich-text binding, needs Quill): `registerQuillBinding` / `connectQuillToText` / `disconnectQuillFromText` — leave those; do not mount a real Quill editor.
### Task Type
- [ ] Refactor / Cleanup
- [ ] DevOps / Deployment / CI
- [x] Testing / QA
- [ ] Documentation
- [ ] Performance
- [ ] Other
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] add unit test coverage for OperatorPropertyEditFrameComponent (remaining non-Quill methods) [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan closed issue #6826: add unit test coverage for OperatorPropertyEditFrameComponent (remaining non-Quill methods)
URL: https://github.com/apache/texera/issues/6826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org