You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by whenceforth <gi...@git.apache.org> on 2014/04/19 08:05:04 UTC
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
GitHub user whenceforth opened a pull request:
https://github.com/apache/spark/pull/453
Spark 1532- provide option to specify allowed IPs for EC2 instance when creating EC2 cluster
Modified the python script that creates spark clusters on EC2. Instead of always allowing '0.0.0.0/0' to access the open ports, the script now provides the option to set the allowed IPs. It defaults to '0.0.0.0/0' so only users who actually specify the new option will see a change in behavior.
https://issues.apache.org/jira/browse/SPARK-1532
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/whenceforth/spark spark-1532
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/453.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #453
----
commit 8112708ea5167fa4cd7ea0abf343907d6bd3fd46
Author: Art Peel <ar...@safeshepherd.com>
Date: 2014-04-14T20:42:48Z
Provide option to set more restrictive Source in the security groups.
The new option is --ips-allowed and it defaults to 0.0.0.0/0 to
match the existing behavior of the script.
commit 0bf9a9dc0425dcb6f819d5f4d189b7185e698461
Author: Art Peel <ap...@yahoo.com>
Date: 2014-04-19T05:52:44Z
Merge branch 'access_mask_option' into spark-1532
Adding fix for SPARK-1532 to more current master.
Why? Travis-CI failed one part of build for an earlier
pull request on code very much unrelated to the fix for
SPARK-1532.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/453#issuecomment-45159889
Hey @whenceforth - I'd like to see this one merged, it seems like a useful feature. Would you mind bringing it up to date.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/453#discussion_r13415161
--- Diff: ec2/spark_ec2.py ---
@@ -103,6 +103,8 @@ def parse_args():
help="When destroying a cluster, delete the security groups that were created")
parser.add_option("--use-existing-master", action="store_true", default=False,
help="Launch fresh slaves, but use an existing stopped master if possible")
+ parser.add_option("--ips-allowed", default="0.0.0.0/0",
+ help="IP addresses allowed to access the machine")
--- End diff --
What is the format for specifying multiple IP addresses (is it comma separated?). It would be good to put that format in this comment. I'd also mention that these are CIDR ranges and not individual addresses.
```
parser.add_option("--ips-allowed", default="0.0.0.0/0",
help="CIDR IP ranges allowed to access the machine. Multiple ranges can be separated with commas.")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/453
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/453#issuecomment-50693564
@whenceforth I think we are going to close this issue for now since it's gone stale, but feel free to re-open if you want to take a crack at it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Spark 1532- provide option to specify allowed ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/453#issuecomment-40862013
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---