You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/23 06:13:08 UTC
[GitHub] [skywalking-python] Superskyyy opened a new pull request #172: Add more lint
Superskyyy opened a new pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172
Signed-off-by: Superskyyy <su...@outlook.com><!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
<!--
- [ ] Add a test case for the new plugin
- [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
- [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172#issuecomment-950098173
Accident pr, not done yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172#issuecomment-950181561
> > @kezhenxu94 A quick question, I'm introducing a new [makefile.venv](https://github.com/Superskyyy/skywalking-python/blob/830a8908ad9ba7dbbb3ed3d2fffe888d6654fcf8/Makefile.venv) for python env isolation. I got it from here - [sio/Makefile.venv](https://github.com/sio/Makefile.venv)
> > The question is should I keep the file as is(it has an apache2.0 license header line 63-67)?
>
> Can we use this [sio/Makefile.venv#alternative-method](https://github.com/sio/Makefile.venv#alternative-method) method to avoid copying?
Looks like it's getting complicated.
So, MacOS doesn't have a checksum built-in, and I actually need to modify the file (.venv to venv). I'm going to write a simpler solution for now - just invoke the venv myself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172#issuecomment-950100681
> @kezhenxu94 A quick question, I'm introducing a new [makefile.venv](https://github.com/Superskyyy/skywalking-python/blob/830a8908ad9ba7dbbb3ed3d2fffe888d6654fcf8/Makefile.venv) for python env isolation. I got it from here - https://github.com/sio/Makefile.venv
>
> The question is should I keep the file as is(it has an apache2.0 license header line 63-67)?
Can we use this https://github.com/sio/Makefile.venv#alternative-method method to avoid copying?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172#issuecomment-950099939
@kezhenxu94 A quick question, I'm introducing a new [makefile.venv](https://github.com/Superskyyy/skywalking-python/blob/830a8908ad9ba7dbbb3ed3d2fffe888d6654fcf8/Makefile.venv) for python env isolation. I got it from here - https://github.com/sio/Makefile.venv
The question is should I keep the file as is(it has an apache2.0 license header line 63-67)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy closed pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
Superskyyy closed pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] Superskyyy commented on pull request #172: Add more lint
Posted by GitBox <gi...@apache.org>.
Superskyyy commented on pull request #172:
URL: https://github.com/apache/skywalking-python/pull/172#issuecomment-950103345
> > @kezhenxu94 A quick question, I'm introducing a new [makefile.venv](https://github.com/Superskyyy/skywalking-python/blob/830a8908ad9ba7dbbb3ed3d2fffe888d6654fcf8/Makefile.venv) for python env isolation. I got it from here - https://github.com/sio/Makefile.venv
> >
> > The question is should I keep the file as is(it has an apache2.0 license header line 63-67)?
>
> Can we use this https://github.com/sio/Makefile.venv#alternative-method method to avoid copying?
I think that would work, gonna try it tmr. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org