You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2022/02/23 04:04:00 UTC

[jira] [Created] (YUNIKORN-1090) remove common.Node from the shim

Wilfred Spiegelenburg created YUNIKORN-1090:
-----------------------------------------------

             Summary: remove common.Node from the shim
                 Key: YUNIKORN-1090
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1090
             Project: Apache YuniKorn
          Issue Type: Improvement
          Components: shim - kubernetes
            Reporter: Wilfred Spiegelenburg


The node code seems overly complex with 3 types of nodes:
 * cache.SchedulerNode
 * framework.NodeInfo
 * common.Node

The first two we really need as one is the internal cache node, and the other one is K8s node.
The last one {{common.Node}} is only used for communication between the cache and the si_helper code. We do not really need that object. It is short lived, one function call, and for some of the calls we only really use one field from the object.
Creating the object and almost immediately dropping is GC overhead. It is cheaper and simpler to just pass the field(s) directly into the si_helper as we do for the application.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org