You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "fansehep (via GitHub)" <gi...@apache.org> on 2023/10/16 06:37:13 UTC
[PR] feat: support parsing for parquet writer option [arrow-rs]
fansehep opened a new pull request, #4938:
URL: https://github.com/apache/arrow-rs/pull/4938
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
part https://github.com/apache/arrow-rs/issues/4693
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#discussion_r1362846325
##########
parquet/src/basic.rs:
##########
@@ -2130,4 +2235,93 @@ mod tests {
);
assert_eq!(ColumnOrder::UNDEFINED.sort_order(), SortOrder::SIGNED);
}
+
+ #[test]
+ fn test_parse_encoding() {
+ let mut encoding: Encoding = "PLAIN".parse().unwrap();
+ assert_eq!(encoding, Encoding::PLAIN);
+ encoding = "PLAIN_DICTIONARY".parse().unwrap();
+ assert_eq!(encoding, Encoding::PLAIN_DICTIONARY);
+ encoding = "RLE".parse().unwrap();
+ assert_eq!(encoding, Encoding::RLE);
+ encoding = "BIT_PACKED".parse().unwrap();
+ assert_eq!(encoding, Encoding::BIT_PACKED);
+ encoding = "DELTA_BINARY_PACKED".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_BINARY_PACKED);
+ encoding = "DELTA_LENGTH_BYTE_ARRAY".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_LENGTH_BYTE_ARRAY);
+ encoding = "DELTA_BYTE_ARRAY".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_BYTE_ARRAY);
+ encoding = "RLE_DICTIONARY".parse().unwrap();
+ assert_eq!(encoding, Encoding::RLE_DICTIONARY);
+ encoding = "BYTE_STREAM_SPLIT".parse().unwrap();
+ assert_eq!(encoding, Encoding::BYTE_STREAM_SPLIT);
+
+ // test lowercase
+ encoding = "Byte_Stream_Split".parse().unwrap();
+ assert_eq!(encoding, Encoding::BYTE_STREAM_SPLIT);
+
+ // test unknown string
+ match "plain_xxx".parse::<Encoding>() {
+ Ok(e) => {
+ panic!("Should not be able to parse {:?}", e);
+ }
+ Err(e) => {
+ assert_eq!(e.to_string(), "Parquet error: unknown encoding: plain_xxx");
+ }
+ }
+ }
+
+ #[test]
+ fn test_parse_compression() {
+ let mut compress: Compression = "snappy".parse().unwrap();
+ assert_eq!(compress, Compression::SNAPPY);
+ compress = "lzo".parse().unwrap();
+ assert_eq!(compress, Compression::LZO);
+ compress = "zstd(3)".parse().unwrap();
+ assert_eq!(compress, Compression::ZSTD(ZstdLevel::try_new(3).unwrap()));
+ compress = "LZ4_raw".parse().unwrap();
+ assert_eq!(compress, Compression::LZ4_RAW);
+ compress = "uncompressed".parse().unwrap();
+ assert_eq!(compress, Compression::UNCOMPRESSED);
+ compress = "snappy".parse().unwrap();
+ assert_eq!(compress, Compression::SNAPPY);
+ compress = "gzip(9)".parse().unwrap();
+ assert_eq!(compress, Compression::GZIP(GzipLevel::try_new(9).unwrap()));
+ compress = "lzo".parse().unwrap();
+ assert_eq!(compress, Compression::LZO);
+ compress = "brotli(3)".parse().unwrap();
+ assert_eq!(
+ compress,
+ Compression::BROTLI(BrotliLevel::try_new(3).unwrap())
+ );
+ compress = "lz4".parse().unwrap();
+ assert_eq!(compress, Compression::LZ4);
+
+ // test unknown compression
+ match "unknown".parse::<Compression>() {
Review Comment:
These could also make use of unwrap_err()
##########
parquet/src/basic.rs:
##########
@@ -278,6 +279,25 @@ pub enum Encoding {
BYTE_STREAM_SPLIT,
}
+impl FromStr for Encoding {
+ type Err = ParquetError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_owned().to_uppercase().as_str() {
Review Comment:
I wonder if we should be case sensitive and leave it to the caller to force to upper case if that is what they want?
It seems strange that we would support parsing things like `PlAiN`
##########
parquet/src/basic.rs:
##########
@@ -2130,4 +2235,93 @@ mod tests {
);
assert_eq!(ColumnOrder::UNDEFINED.sort_order(), SortOrder::SIGNED);
}
+
+ #[test]
+ fn test_parse_encoding() {
+ let mut encoding: Encoding = "PLAIN".parse().unwrap();
+ assert_eq!(encoding, Encoding::PLAIN);
+ encoding = "PLAIN_DICTIONARY".parse().unwrap();
+ assert_eq!(encoding, Encoding::PLAIN_DICTIONARY);
+ encoding = "RLE".parse().unwrap();
+ assert_eq!(encoding, Encoding::RLE);
+ encoding = "BIT_PACKED".parse().unwrap();
+ assert_eq!(encoding, Encoding::BIT_PACKED);
+ encoding = "DELTA_BINARY_PACKED".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_BINARY_PACKED);
+ encoding = "DELTA_LENGTH_BYTE_ARRAY".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_LENGTH_BYTE_ARRAY);
+ encoding = "DELTA_BYTE_ARRAY".parse().unwrap();
+ assert_eq!(encoding, Encoding::DELTA_BYTE_ARRAY);
+ encoding = "RLE_DICTIONARY".parse().unwrap();
+ assert_eq!(encoding, Encoding::RLE_DICTIONARY);
+ encoding = "BYTE_STREAM_SPLIT".parse().unwrap();
+ assert_eq!(encoding, Encoding::BYTE_STREAM_SPLIT);
+
+ // test lowercase
+ encoding = "Byte_Stream_Split".parse().unwrap();
+ assert_eq!(encoding, Encoding::BYTE_STREAM_SPLIT);
+
+ // test unknown string
+ match "plain_xxx".parse::<Encoding>() {
+ Ok(e) => {
+ panic!("Should not be able to parse {:?}", e);
+ }
+ Err(e) => {
+ assert_eq!(e.to_string(), "Parquet error: unknown encoding: plain_xxx");
+ }
+ }
Review Comment:
```suggestion
let err = "plain_xxx".parse::<Encoding>().unwrap_err();
assert_eq!(e.to_string(), "Parquet error: unknown encoding: plain_xxx");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#discussion_r1363360364
##########
parquet/src/basic.rs:
##########
@@ -278,6 +279,25 @@ pub enum Encoding {
BYTE_STREAM_SPLIT,
}
+impl FromStr for Encoding {
+ type Err = ParquetError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_owned().to_uppercase().as_str() {
Review Comment:
I think we should just support case sensitive parsing and the user can opt in to case insensitive parsing by converting the input to uppercase should they want this behaviour
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "fansehep (via GitHub)" <gi...@apache.org>.
fansehep commented on PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#issuecomment-1764307581
> Could we get some tests for this please 🙏
🫣i will add some tests later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "fansehep (via GitHub)" <gi...@apache.org>.
fansehep commented on code in PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#discussion_r1363148423
##########
parquet/src/basic.rs:
##########
@@ -278,6 +279,25 @@ pub enum Encoding {
BYTE_STREAM_SPLIT,
}
+impl FromStr for Encoding {
+ type Err = ParquetError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_owned().to_uppercase().as_str() {
Review Comment:
> It seems strange that we would support parsing things like `PlAiN`
For users, whose usage is generally unobservable, I also find it odd to support this kind of parsing like `PlAiN`, but it seems that both cases should be supported?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#issuecomment-1768065579
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: support parsing for parquet writer option [arrow-rs]
Posted by "fansehep (via GitHub)" <gi...@apache.org>.
fansehep commented on code in PR #4938:
URL: https://github.com/apache/arrow-rs/pull/4938#discussion_r1363452261
##########
parquet/src/basic.rs:
##########
@@ -278,6 +279,25 @@ pub enum Encoding {
BYTE_STREAM_SPLIT,
}
+impl FromStr for Encoding {
+ type Err = ParquetError;
+
+ fn from_str(s: &str) -> Result<Self, Self::Err> {
+ match s.to_owned().to_uppercase().as_str() {
Review Comment:
> I think we should just support case sensitive parsing and the user can opt in to case insensitive parsing by converting the input to uppercase should they want this behaviour
done. i think it's a good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org