You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2016/11/15 03:33:23 UTC
Review Request 53748: Updated equals and hashCode signatures
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Repository: atlas
Description
-------
Updated equals and hashCode signatures
Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
Diffs
-----
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
Diff: https://reviews.apache.org/r/53748/diff/
Testing
-------
Working on executing all tests
Thanks,
Apoorv Naik
Re: Review Request 53748: Updated equals and hashCode signatures
Posted by Apoorv Naik <na...@gmail.com>.
> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87
> > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87>
> >
> > Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features
Sure I can give it a try. Is MIT licensing ok with ASF projects ?
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156164
-----------------------------------------------------------
On Nov. 15, 2016, 3:33 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 3:33 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode signatures
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Suma Shivaprasad <su...@gmail.com>.
> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87
> > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87>
> >
> > Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features
>
> Apoorv Naik wrote:
> Sure I can give it a try. Is MIT licensing ok with ASF projects ?
Yes it is compatible. Pls include the license in the LICENSE file it it doesnt exist already.
- Suma
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156164
-----------------------------------------------------------
On Nov. 17, 2016, 4:58 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2016, 4:58 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1303
> https://issues.apache.org/jira/browse/ATLAS-1303
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode methods
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
> On Nov. 17, 2016, 1:37 a.m., Suma Shivaprasad wrote:
> > catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java, line 87
> > <https://reviews.apache.org/r/53748/diff/1/?file=1563756#file1563756line87>
> >
> > Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features
>
> Apoorv Naik wrote:
> Sure I can give it a try. Is MIT licensing ok with ASF projects ?
>
> Suma Shivaprasad wrote:
> Yes it is compatible. Pls include the license in the LICENSE file it it doesnt exist already.
Dropping the issue for now as Madhan wants to discuss this further.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156164
-----------------------------------------------------------
On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 8:38 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1303
> https://issues.apache.org/jira/browse/ATLAS-1303
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode methods
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e0344
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode signatures
Posted by Suma Shivaprasad <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156164
-----------------------------------------------------------
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java (line 86)
<https://reviews.apache.org/r/53748/#comment226303>
Can we switch to/think of using Lombok instead which would make the code more concise and less error prone - https://projectlombok.org/features/index.html. We could use it later for Getter/Setters and other useful features
- Suma Shivaprasad
On Nov. 15, 2016, 3:33 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 3:33 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode signatures
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/
-----------------------------------------------------------
(Updated Dec. 13, 2016, 6:52 a.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Rebased on latest changes.
Bugs: ATLAS-1303
https://issues.apache.org/jira/browse/ATLAS-1303
Repository: atlas
Description
-------
Updated equals and hashCode methods
Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f4
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab0
common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5f
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf7
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74aeb
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585c
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d93
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bbf
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f41187
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f336
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91a
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d0
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee15
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176a
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b2
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e03442
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b31
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e0
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc8
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117d
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3c
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421d
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f5562232
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d9
typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a38
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 80694224
typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2eed
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc8
webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76c
Diff: https://reviews.apache.org/r/53748/diff/
Testing (updated)
-------
Unit tests passing.
Thanks,
Apoorv Naik
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/
-----------------------------------------------------------
(Updated Nov. 29, 2016, 8:38 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Removed duplicate code. Compilation and test runs were successful.
Bugs: ATLAS-1303
https://issues.apache.org/jira/browse/ATLAS-1303
Repository: atlas
Description
-------
Updated equals and hashCode methods
Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e0344
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
Diff: https://reviews.apache.org/r/53748/diff/
Testing
-------
Working on executing all tests
Thanks,
Apoorv Naik
Re: Review Request 53748: Updated equals and hashCode
Posted by Vimal Sharma <vi...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review157267
-----------------------------------------------------------
Please run all tests as well to verify that these changes do not introduce new test failures
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java (line 177)
<https://reviews.apache.org/r/53748/#comment227791>
Seems like equals and hashcode methods have been declared twice
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java (line 213)
<https://reviews.apache.org/r/53748/#comment227792>
Changes are required here as well
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java (line 99)
<https://reviews.apache.org/r/53748/#comment227793>
Duplicate. Please remove
- Vimal Sharma
On Nov. 28, 2016, 8:32 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2016, 8:32 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1303
> https://issues.apache.org/jira/browse/ATLAS-1303
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode methods
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ef12896
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/
-----------------------------------------------------------
(Updated Nov. 28, 2016, 8:32 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Changes
-------
Rebased on latest master
Bugs: ATLAS-1303
https://issues.apache.org/jira/browse/ATLAS-1303
Repository: atlas
Description
-------
Updated equals and hashCode methods
Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
Diffs (updated)
-----
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java ef12896
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
Diff: https://reviews.apache.org/r/53748/diff/
Testing
-------
Working on executing all tests
Thanks,
Apoorv Naik
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
> On Nov. 17, 2016, 8:01 p.m., Sarath Subramanian wrote:
> > client/src/main/java/org/apache/atlas/EntityAuditEvent.java, line 57
> > <https://reviews.apache.org/r/53748/diff/1/?file=1563757#file1563757line57>
> >
> > we can also consider using the commons lang - EqualsBuilder and HashCodeBuilder.
Same here, absolute preference for JDK utils over third-party libraries.
- Apoorv
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156234
-----------------------------------------------------------
On Nov. 29, 2016, 8:38 p.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2016, 8:38 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1303
> https://issues.apache.org/jira/browse/ATLAS-1303
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode methods
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 5288cbf
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java bedd4d9
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java 72f4118
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java feae00d
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 1be5ee1
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 0312176
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java f486f9b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 16e0344
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java cdeb117
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 0b3ffe3
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java a3f9421
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Sarath Subramanian <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/#review156234
-----------------------------------------------------------
client/src/main/java/org/apache/atlas/EntityAuditEvent.java (line 57)
<https://reviews.apache.org/r/53748/#comment226394>
we can also consider using the commons lang - EqualsBuilder and HashCodeBuilder.
- Sarath Subramanian
On Nov. 17, 2016, 8:58 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53748/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2016, 8:58 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
>
>
> Bugs: ATLAS-1303
> https://issues.apache.org/jira/browse/ATLAS-1303
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Updated equals and hashCode methods
>
> Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
>
>
> Diffs
> -----
>
> catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
> client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
> common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
> intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
> intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
> intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
> intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
> intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
> intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
> notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
> notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
> repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
> typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
> typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
> typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
> typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
> typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
> typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
> typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
> webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
>
> Diff: https://reviews.apache.org/r/53748/diff/
>
>
> Testing
> -------
>
> Working on executing all tests
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 53748: Updated equals and hashCode
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53748/
-----------------------------------------------------------
(Updated Nov. 17, 2016, 4:58 p.m.)
Review request for atlas, Madhan Neethiraj, Sarath Subramanian, Shwetha GS, and Suma Shivaprasad.
Summary (updated)
-----------------
Updated equals and hashCode
Bugs: ATLAS-1303
https://issues.apache.org/jira/browse/ATLAS-1303
Repository: atlas
Description (updated)
-------
Updated equals and hashCode methods
Using JDK7's built-in classes to simplify the code and make it more readable/understandable.
Diffs
-----
catalog/src/main/java/org/apache/atlas/catalog/BaseRequest.java b0e428f
client/src/main/java/org/apache/atlas/EntityAuditEvent.java 29a04ab
common/src/main/java/org/apache/atlas/ha/HAConfiguration.java aefaef5
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 6727f27
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityHeader.java d9c74ae
intg/src/main/java/org/apache/atlas/model/instance/AtlasEntityWithAssociations.java 4ddd585
intg/src/main/java/org/apache/atlas/model/instance/AtlasObjectId.java 5921fea
intg/src/main/java/org/apache/atlas/model/instance/AtlasStruct.java 695f1bb
intg/src/main/java/org/apache/atlas/model/instance/EntityMutationResponse.java a6c75ed
intg/src/main/java/org/apache/atlas/model/instance/EntityMutations.java e489f33
intg/src/main/java/org/apache/atlas/model/lineage/AtlasLineageInfo.java 61b7f91
intg/src/main/java/org/apache/atlas/model/typedef/AtlasBaseTypeDef.java d953633
intg/src/main/java/org/apache/atlas/model/typedef/AtlasClassificationDef.java 2e34127
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 86e2388
intg/src/main/java/org/apache/atlas/model/typedef/AtlasEnumDef.java e4c5e1b
intg/src/main/java/org/apache/atlas/model/typedef/AtlasStructDef.java 582b095
intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypeDefHeader.java a3929b3
notification/src/main/java/org/apache/atlas/notification/MessageVersion.java 6ef407a
notification/src/main/java/org/apache/atlas/notification/entity/EntityNotificationImpl.java fda588e
notification/src/test/java/org/apache/atlas/notification/AbstractNotificationConsumerTest.java ed5b9fc
repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 7e47d30
typesystem/src/main/java/org/apache/atlas/typesystem/Referenceable.java 5b8e157
typesystem/src/main/java/org/apache/atlas/typesystem/persistence/Id.java 42280d0
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeDefinition.java f556223
typesystem/src/main/java/org/apache/atlas/typesystem/types/AttributeInfo.java 9cb0d0d
typesystem/src/main/java/org/apache/atlas/typesystem/types/EnumTypeDefinition.java ac3b5a3
typesystem/src/main/java/org/apache/atlas/typesystem/types/HierarchicalTypeDefinition.java 8069422
typesystem/src/main/java/org/apache/atlas/typesystem/types/Multiplicity.java 18ef2ee
typesystem/src/main/java/org/apache/atlas/typesystem/types/StructTypeDefinition.java c9316cc
webapp/src/main/java/org/apache/atlas/web/params/AbstractParam.java 9cfdb76
Diff: https://reviews.apache.org/r/53748/diff/
Testing
-------
Working on executing all tests
Thanks,
Apoorv Naik