You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2022/11/10 03:03:16 UTC

[GitHub] [karaf] rovarga opened a new pull request, #1680: [KARAF-7607]: careful JLine/SSHD translation

rovarga opened a new pull request, #1680:
URL: https://github.com/apache/karaf/pull/1680

   JLine returns -1 for control characters it does not find. SSHD requires modes' values to be unsigned integers. Mind this difference when populating SSD PtyModes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre commented on pull request #1680: [KARAF-7607]: careful JLine/SSHD translation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #1680:
URL: https://github.com/apache/karaf/pull/1680#issuecomment-1321644470

   I will tackle that today thanks !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] asfgit closed pull request #1680: [KARAF-7607]: careful JLine/SSHD translation

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1680: [KARAF-7607]: careful JLine/SSHD translation
URL: https://github.com/apache/karaf/pull/1680


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] jbonofre commented on pull request #1680: [KARAF-7607]: careful JLine/SSHD translation

Posted by GitBox <gi...@apache.org>.
jbonofre commented on PR #1680:
URL: https://github.com/apache/karaf/pull/1680#issuecomment-1313105150

   @rovarga thanks, I'm starting my review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [karaf] rovarga commented on pull request #1680: [KARAF-7607]: careful JLine/SSHD translation

Posted by GitBox <gi...@apache.org>.
rovarga commented on PR #1680:
URL: https://github.com/apache/karaf/pull/1680#issuecomment-1321309569

   @jbonofre hey JB, can I get a review, please?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@karaf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org