[GitHub] vvraskin commented on a change in pull request #4000: Put error message as tag into failed trace.

[GitBox <gi...@apache.org>]

vvraskin commented on a change in pull request #4000: Put error message as tag into failed trace.
URL: https://github.com/apache/incubator-openwhisk/pull/4000#discussion_r215198633
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -174,23 +175,24 @@ protected[actions] trait PrimitiveActions {
 
     val postedFuture = loadBalancer.publish(action, message)
 
-    postedFuture.flatMap { activeAckResponse =>
-      // successfully posted activation request to the message bus
-      transid.finished(this, startLoadbalancer)
-
+    postedFuture andThen {
+      case Success(_) => transid.finished(this, startLoadbalancer)
+      case Failure(e) => transid.failed(this, startLoadbalancer, e.getMessage, logLevel = ErrorLevel)
 
 Review comment:
   Should the error log level be eliminated here? An activation failure doesn't always imply a system failure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services