You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/04 00:02:14 UTC

[GitHub] [pulsar] devinbost opened a new issue #10821: [docs] Need clarification around batch indexing configs

devinbost opened a new issue #10821:
URL: https://github.com/apache/pulsar/issues/10821


   In https://pulsar.apache.org/docs/en/reference-configuration/#broker, the docs mention this setting for batch indexing:
   `acknowledgmentAtBatchIndexLevelEnabled`
   
   However, batch indexing is also mentioned [in this doc ](https://pulsar.apache.org/docs/en/concepts-messaging/#batching) with the `batchIndexAcknowledgeEnable` parameter. 
   
   We need some clarification in the docs regarding what is the difference between these parameters. It doesn't look like the newer `acknowledgmentAtBatchIndexLevelEnabled` setting has been documented much yet. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy closed issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
wolfstudy closed issue #10821:
URL: https://github.com/apache/pulsar/issues/10821


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #10821:
URL: https://github.com/apache/pulsar/issues/10821#issuecomment-854306693


   Hi @codelipenghui I find that you [introduced `batchIndexAcknowledgeEnable` in Pulsar 2.6.0](https://pulsar.apache.org/blog/2020/06/18/Apache-Pulsar-2-6-0/#pip-54-support-acknowledgment-at-the-batch-index-level) and allowed users to set this configuration in `broker.conf`.
   
   Question:
   
   1. I search `batchIndexAcknowledgeEnable` in `broker.conf`, but got nothing. Do we need to add it to `broker.conf`?
   
   2. `batchIndexAcknowledgeEnable` is similar to [`acknowledgmentAtBatchIndexLevelEnabled`](https://pulsar.apache.org/docs/en/reference-configuration/#broker), which can be set in `broker.conf` as well. What's the difference between them? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #10821:
URL: https://github.com/apache/pulsar/issues/10821#issuecomment-855543168


   > I search batchIndexAcknowledgeEnable in broker.conf, but got nothing. Do we need to add it to broker.conf?
   
   In `broker.conf`, `acknowledgmentAtBatchIndexLevelEnabled` is the answer you want.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #10821:
URL: https://github.com/apache/pulsar/issues/10821#issuecomment-855547409


   @wolfstudy many thanks for your contribution. I've reviewed the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] wolfstudy commented on issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #10821:
URL: https://github.com/apache/pulsar/issues/10821#issuecomment-855544190


   @Anonymitaet It seems that `batchIndexAcknowledgeEnable` and `acknowledgmentAtBatchIndexLevelEnabled` are confused in the documentation. I will send a pr to fix this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on issue #10821: [docs] Need clarification around batch indexing configs

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on issue #10821:
URL: https://github.com/apache/pulsar/issues/10821#issuecomment-854306693


   Hi @codelipenghui I find that you [introduced `batchIndexAcknowledgeEnable` in Pulsar 2.6.0](https://pulsar.apache.org/blog/2020/06/18/Apache-Pulsar-2-6-0/#pip-54-support-acknowledgment-at-the-batch-index-level) and allowed users to set this configuration in `broker.conf`.
   
   Question:
   
   1. I search `batchIndexAcknowledgeEnable` in `broker.conf`, but got nothing. Do we need to add it to `broker.conf`?
   
   2. `batchIndexAcknowledgeEnable` is similar to [`acknowledgmentAtBatchIndexLevelEnabled`](https://pulsar.apache.org/docs/en/reference-configuration/#broker), which can be set in `broker.conf` as well. What's the difference between them? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org