[GitHub] [maven-reporting-exec] gnodet commented on a change in pull request #8: Drop support for maven below 3.2.x

[GitBox <gi...@apache.org>]

gnodet commented on a change in pull request #8:
URL: https://github.com/apache/maven-reporting-exec/pull/8#discussion_r791101276



##########
File path: src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -48,134 +50,20 @@
     @Requirement
     protected MavenPluginManager mavenPluginManager;

Review comment:
       Should we switch to a constructor based `@Inject` + `@Named` instead of `@Component` / `@Requirement` and get rid of plexus logging at the same time ?

##########
File path: pom.xml
##########
@@ -56,9 +56,9 @@
   </distributionManagement>
 
   <properties>
-    <mavenVersion>3.0</mavenVersion>
+    <mavenVersion>3.2.5</mavenVersion>
+    <aetherVersion>1.0.0.v20140518</aetherVersion>

Review comment:
       Would it make sense to depend on `maven-resolver` rather than `org.eclipse.aether` ?

##########
File path: src/main/java/org/apache/maven/reporting/exec/DefaultMavenPluginManagerHelper.java
##########
@@ -34,6 +32,10 @@
 import org.codehaus.plexus.component.annotations.Component;
 import org.codehaus.plexus.component.annotations.Requirement;
 import org.codehaus.plexus.logging.Logger;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.graph.DependencyFilter;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.util.filter.ExclusionsDependencyFilter;

Review comment:
       Can we list on a wiki page the list of missing APIs ? If the goal is to hide maven-resolver in a clean maven-core provided api, we need to list the bits that are currently missing.  The fact that the `MavenPluginManager` is depending on the aether api is wrong.

##########
File path: pom.xml
##########
@@ -170,7 +145,13 @@
     <dependency>
       <groupId>junit</groupId>
       <artifactId>junit</artifactId>
-      <version>4.13.1</version>
+      <version>4.13.2</version>
+      <scope>test</scope>
+    </dependency>
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>
+      <version>1.7.32</version>

Review comment:
       I wonder if the junit / slf4j dependencies should be in the parent to ease alignment ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org