You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "AlenkaF (via GitHub)" <gi...@apache.org> on 2025/04/04 07:02:57 UTC
[PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
AlenkaF opened a new pull request, #46029:
URL: https://github.com/apache/arrow/pull/46029
### Rationale for this change
`test-conda-python-3.11-hypothesis` have been failing sporadically due to data generation being slow.
### What changes are included in this PR?
`HealthCheck.too_slow` in the `suppress_health_check` settings is added to `test_dtypes` test in order to disable this health check.
### Are these changes tested?
Existing tests should pass.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2778672482
Correct, the failure is different now (`ArrowInvalid`) and for a different test: `test_chunked_arrays` from `test_strategies.py` that uses `all_chunked_arrays = chunked_arrays(all_types)` strategy.
Nothing in `pyarrow/util.py` and `pyarrow/tests/util.py` that would fit a data generation utility. To confirm, you suggest we move away from using `hypothesis.strategies` and `hypothesis.extra.numpy` in `arrays` strategy defined in `pyarrow/tests/test_strategies.py` and create our own data generation utility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "pitrou (via GitHub)" <gi...@apache.org>.
pitrou commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2777839175
cc @kszucs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2782937137
Revision: 13fb65a2b124e03072b13b8f62fbe6ffd0042eaf
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3de565ebbd](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3de565ebbd)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14307518712/job/40094651121)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2783079609
Revision: bed0f73e03b458375d397bffc22990fa3c724bdb
Submitted crossbow builds: [ursacomputing/crossbow @ actions-530c97573e](https://github.com/ursacomputing/crossbow/branches/all?query=actions-530c97573e)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14308530873/job/40097775221)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2778415615
Ideally we should expose the testing data generation utilities from libarrow then use that directly. Something like `pa.random()` would be useful for other purposes as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2777728598
:warning: GitHub issue #45292 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2783041940
Revision: c2f4d3e0ccacd2369cf72643c5bfeedcfdf62f26
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3da19f7966](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3da19f7966)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14308293880/job/40097014594)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2782929212
@github-actions crossbow submit test-conda-python-3.11-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2782934077
I suggest to first get a fix on the tests to get a clean build and then we can tackle the bigger issue separately (will open an issue to move away from numpy/pylist strategies and define testing data generation utilities in PyArrow).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2777767333
Not sure running `@github-actions crossbow submit test-conda-python-3.11-hypothesis` makes sense as the test fails sporadically but will do it just in case :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2783036311
@github-actions crossbow submit test-conda-python-3.11-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2783361467
Created [[Python] Expose testing data generation utility](https://github.com/apache/arrow/issues/46039).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2777776187
Revision: 154a9c6164455e58b6ffc3c79e386a96891a5f0a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-2bfdd92206](https://github.com/ursacomputing/crossbow/branches/all?query=actions-2bfdd92206)
|Task|Status|
|----|------|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/14260221372/job/39970024204)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2784537106
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c56ec12a2f38ed6fce2d87ea65345b6edf4234f5.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/40130796353) has more details. It also includes information about 13 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2783072236
@github-actions crossbow submit test-conda-python-3.11-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs merged PR #46029:
URL: https://github.com/apache/arrow/pull/46029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2777767470
@github-actions crossbow submit test-conda-python-3.11-hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45292: [Python] test_dtypes hypotesis test fails sporadically [arrow]
Posted by "kszucs (via GitHub)" <gi...@apache.org>.
kszucs commented on PR #46029:
URL: https://github.com/apache/arrow/pull/46029#issuecomment-2778398851
Seems like it fails with a different error now due to incorrect data generation.
Currently the arrays are being generated using a mixture of numpy/pylist strategies, preferably we should move away to generate the arrays directly from pyarrow. Do we have some utilities exposed for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org