[jira] Updated: (RIVER-388) Eliminating compiler warnings, etc. in Outrigger/Space

["James Grahn (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/RIVER-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Grahn updated RIVER-388:
------------------------------

    Attachment: outrigger-java15-refactor-and-findbugs-patch.txt
                outrigger-java15-refactor-patch.txt

The first patch is the bulk of the refactoring, driven primarily by compiler warnings.

The second patch includes the changes of the first, plus revisions recommended by FindBugs.

> Eliminating compiler warnings, etc. in Outrigger/Space
> ------------------------------------------------------
>
>                 Key: RIVER-388
>                 URL: https://issues.apache.org/jira/browse/RIVER-388
>             Project: River
>          Issue Type: Improvement
>          Components: Contributions
>            Reporter: James Grahn
>         Attachments: outrigger-java15-refactor-and-findbugs-patch.txt, outrigger-java15-refactor-patch.txt
>
>
> I'm going to attach a couple of patches to this issue, to summarize, these patches include these light refactoring steps:
> (Some) unused methods removed.
> (Some) unused variables removed.
> Extracting common code into methods.
> Replacing iterator usage with the enhanced for loop (for each).
> Added generic usage to internal methods/fields.
> Removed unused imports.
> The second patch includes some fixes from running FindBugs.   (And one other thing I resolved myself.)
> I localized my changes to outrigger/space packages.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.