You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by purechoc <gi...@git.apache.org> on 2016/12/06 07:19:29 UTC
[GitHub] zeppelin pull request #1729: [ZEPPELIN-1758] using pyspark(python3) with liv...
GitHub user purechoc opened a pull request:
https://github.com/apache/zeppelin/pull/1729
[ZEPPELIN-1758] using pyspark(python3) with livy interperter
### What is this PR for?
support livy pyspark Interpreter's magic function
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1758
### How should this be tested?
test code
{code}
{code}
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purechoc/zeppelin support-livy-magic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1729
----
commit 5fe38d2469004c2c11147a6c53ae7abf89b73f35
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-06T07:15:59Z
support table magic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1729: [ZEPPELIN-1758] support livy pyspark Interprete...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] using pyspark(python3) with livy inter...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
PR title is wrong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
Thanks @purechoc . LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@purechoc refactoring LivyHelper has been done. You can continue this PR. I think the right place for you is https://github.com/apache/zeppelin/blob/master/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java#L231
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by purechoc <gi...@git.apache.org>.
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@zjffdu why not. i will wait.
thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1729
LGTM and merge to master if there're no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by purechoc <gi...@git.apache.org>.
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@felixcheung @Leemoonsoo
could you mind merge of this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1729: [ZEPPELIN-1758] support livy pyspark Interprete...
Posted by purechoc <gi...@git.apache.org>.
Github user purechoc closed the pull request at:
https://github.com/apache/zeppelin/pull/1729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@purechoc Thanks for the quick update. Could you add test in `LivyInterpreterIT` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1729: [ZEPPELIN-1758] support livy pyspark Interprete...
Posted by purechoc <gi...@git.apache.org>.
GitHub user purechoc reopened a pull request:
https://github.com/apache/zeppelin/pull/1729
[ZEPPELIN-1758] support livy pyspark Interpreter's magic function
### What is this PR for?
support livy pyspark Interpreter's magic function
### What type of PR is it?
Improvement
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1758
### How should this be tested?
test code
```
%livy.pyspark
t = [{"name":"userA", "role":"roleA"}, {"name":"userB", "role":"roleB"}, {"name":"userC"}]
%table t
```
```
%livy.sparkr
plot(iris, col = heat.colors(3))
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purechoc/zeppelin support-livy-magic
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1729
----
commit 5fe38d2469004c2c11147a6c53ae7abf89b73f35
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-06T07:15:59Z
support table magic
commit c33ac76d5ec23b194c55e73bc05606bcc0b4dfab
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-06T08:27:27Z
fixed some wrong code
commit 2af35b96491bda48c4bb2afa3510589693fa4f35
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T00:29:25Z
Merge remote-tracking branch 'upstream2/master' into support-livy-magic
Conflicts:
livy/src/main/java/org/apache/zeppelin/livy/LivyHelper.java
commit 56f1b78957c0cd1e44a1455b0ed5bdf8b3f8b78c
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T03:50:51Z
refactoring
commit 1cdd7ffa08b4f19fc550d7f04e33796656012eaa
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T07:47:21Z
add test in LivyInterpreterIT
commit 0699e840412142b64a0cee32697fb2c95e733765
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T08:34:21Z
change to using StringBuilder
commit 641f4827649b8af431202d1ec5270969e5250ca1
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T08:58:17Z
change to using StringUtils
commit 5f265923658666823f3b344a18e8b189cce2952c
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T09:16:19Z
fixed wrong code
commit e3dcf427e7221f38fa00a17263b7facc83041651
Author: purechoc <pu...@ncsoft.com>
Date: 2016-12-23T09:17:47Z
fixed wrong code
commit 2cbc78252eb7e0c0111587c49fdd1aab34e25e28
Author: chrischo <pu...@gmail.com>
Date: 2016-12-23T10:06:30Z
fixed valiable name
commit c4a09520114c40220d75883f566e77ccc4fe6135
Author: chrischo <pu...@gmail.com>
Date: 2016-12-23T10:35:55Z
fixed valiable name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1729
@purechoc I am refactoring LivyHelper in #1751, could you wait and rebase this PR after #1751 is merged ? Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Posted by purechoc <gi...@git.apache.org>.
Github user purechoc commented on the issue:
https://github.com/apache/zeppelin/pull/1729
fixed PR title.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---