You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/06/16 09:18:01 UTC

[GitHub] [incubator-teaclave] rebol0x6c opened a new pull request #357: fix sgx sdk path.

rebol0x6c opened a new pull request #357:
URL: https://github.com/apache/incubator-teaclave/pull/357


   ## Description
   
   Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
   
   Fixes # (issue)
   
   ## Type of change (select or add applied and delete the others)
   
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [ ] API change with a documentation update
   - [ ] Additional test coverage
   - [ ] Code cleanup or just sync with upstream third-party crates
   
   ## How has this been tested?
   
   ## Checklist
   
   - [ ] Fork the repo and create your branch from `master`.
   - [ ] If you've added code that should be tested, add tests.
   - [ ] If you've changed APIs, update the documentation.
   - [ ] Ensure the tests pass (see CI results).
   - [ ] Make sure your code lints/format.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] rebol0x6c commented on pull request #357: fix sgx sdk path.

Posted by GitBox <gi...@apache.org>.
rebol0x6c commented on pull request #357:
URL: https://github.com/apache/incubator-teaclave/pull/357#issuecomment-645412987


   make all path consistent done.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun merged pull request #357: fix sgx sdk path.

Posted by GitBox <gi...@apache.org>.
mssun merged pull request #357:
URL: https://github.com/apache/incubator-teaclave/pull/357


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun edited a comment on pull request #357: fix sgx sdk path.

Posted by GitBox <gi...@apache.org>.
mssun edited a comment on pull request #357:
URL: https://github.com/apache/incubator-teaclave/pull/357#issuecomment-644911299


   Thanks for the catch. I found that for other docker files, we are using `/opt`. Instead of changing the path, can you change to `/opt` to make all consistent?
   
   https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-2.9.1.Dockerfile#L47-L49
   
   https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-dcap-1.6.Dockerfile#L49-L51


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org

[GitHub] [incubator-teaclave] mssun commented on pull request #357: fix sgx sdk path.

Posted by GitBox <gi...@apache.org>.
mssun commented on pull request #357:
URL: https://github.com/apache/incubator-teaclave/pull/357#issuecomment-644911299


   Thanks for the catch. I found that for other docker files, we are using `/opt`. Can you change to `/opt` to make all consistent?
   
   https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-2.9.1.Dockerfile#L47-L49
   
   https://github.com/apache/incubator-teaclave/blob/5d1cfabedd68b3e715bdc3e9c83843902a94f1ea/docker/build.ubuntu-1804.sgx-dcap-1.6.Dockerfile#L49-L51


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org