You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "James Carman (JIRA)" <ji...@apache.org> on 2010/12/16 22:53:01 UTC
[jira] Created: (WICKET-3257) Make getSignInPage() Method Public
Make getSignInPage() Method Public
----------------------------------
Key: WICKET-3257
URL: https://issues.apache.org/jira/browse/WICKET-3257
Project: Wicket
Issue Type: Improvement
Components: wicket-auth-roles
Affects Versions: 1.5-M3
Reporter: James Carman
I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). But, getSignInPage() is protected in AuthenticatedWebApplication. Unless there are very compelling reasons not to do so, can we open that up? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3257) Add restartResponseAtSignInPage()
Method to AuthenticatedWebApplication
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-3257:
---------------------------------
Attachment: WICKET-3257.patch
Here's the patch.
> Add restartResponseAtSignInPage() Method to AuthenticatedWebApplication
> -----------------------------------------------------------------------
>
> Key: WICKET-3257
> URL: https://issues.apache.org/jira/browse/WICKET-3257
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-auth-roles
> Affects Versions: 1.5-M3
> Reporter: James Carman
> Attachments: WICKET-3257.patch
>
>
> I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). Can we add a method that does that? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3257) Make getSignInPage() Method Public
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-3257:
---------------------------------
Attachment: (was: WICKET-3257.patch)
> Make getSignInPage() Method Public
> ----------------------------------
>
> Key: WICKET-3257
> URL: https://issues.apache.org/jira/browse/WICKET-3257
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-auth-roles
> Affects Versions: 1.5-M3
> Reporter: James Carman
>
> I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). But, getSignInPage() is protected in AuthenticatedWebApplication. Unless there are very compelling reasons not to do so, can we open that up? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3257) Add restartResponseAtSignInPage()
Method to AuthenticatedWebApplication
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-3257.
-----------------------------------
Resolution: Fixed
Fix Version/s: 1.5-M4
Assignee: Igor Vaynberg
> Add restartResponseAtSignInPage() Method to AuthenticatedWebApplication
> -----------------------------------------------------------------------
>
> Key: WICKET-3257
> URL: https://issues.apache.org/jira/browse/WICKET-3257
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-auth-roles
> Affects Versions: 1.5-M3
> Reporter: James Carman
> Assignee: Igor Vaynberg
> Fix For: 1.5-M4
>
> Attachments: WICKET-3257.patch
>
>
> I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). Can we add a method that does that? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3257) Make getSignInPage() Method Public
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-3257:
---------------------------------
Attachment: WICKET-3257.patch
Here's my patch.
> Make getSignInPage() Method Public
> ----------------------------------
>
> Key: WICKET-3257
> URL: https://issues.apache.org/jira/browse/WICKET-3257
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-auth-roles
> Affects Versions: 1.5-M3
> Reporter: James Carman
> Attachments: WICKET-3257.patch
>
>
> I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). But, getSignInPage() is protected in AuthenticatedWebApplication. Unless there are very compelling reasons not to do so, can we open that up? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3257) Add restartResponseAtSignInPage()
Method to AuthenticatedWebApplication
Posted by "James Carman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Carman updated WICKET-3257:
---------------------------------
Description: I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). Can we add a method that does that? Patch coming... (was: I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). But, getSignInPage() is protected in AuthenticatedWebApplication. Unless there are very compelling reasons not to do so, can we open that up? Patch coming...)
Summary: Add restartResponseAtSignInPage() Method to AuthenticatedWebApplication (was: Make getSignInPage() Method Public)
> Add restartResponseAtSignInPage() Method to AuthenticatedWebApplication
> -----------------------------------------------------------------------
>
> Key: WICKET-3257
> URL: https://issues.apache.org/jira/browse/WICKET-3257
> Project: Wicket
> Issue Type: Improvement
> Components: wicket-auth-roles
> Affects Versions: 1.5-M3
> Reporter: James Carman
>
> I have a situation where I need to be able to get the sign in page class outside the context of the AuthenticatedWebApplication class itself (or a subclass). Basically, I've got a Spring Security framework that's going to register a custom exception mapper (that wraps the default one). If it sees an AuthenticationCredentialsNotFoundException, it needs to throw a RestartResponseAtInterceptPage(getSignInPage()). Can we add a method that does that? Patch coming...
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.