[GitHub] [pinot] walterddr commented on a diff in pull request #8484: Add customizable parser module

[GitBox <gi...@apache.org>]

walterddr commented on code in PR #8484:
URL: https://github.com/apache/pinot/pull/8484#discussion_r849530733


##########
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java:
##########
@@ -2656,4 +2624,34 @@ public void testInvalidQueryWithAggregateFunction() {
     Assert.expectThrows(SqlCompilationException.class,
         () -> CalciteSqlParser.compileToPinotQuery("SELECT UPPER(col1), avg(col2) from foo"));
   }
+
+  /**
+   * Test for customized components in src/main/codegen/parserImpls.ftl file.
+   */
+  @Test
+  public void testParserExtensionImpl() {
+    SqlNode sqlNode = testSqlWithCustomSqlParser("INSERT INTO db.tbl "
+        + "FROM FILE 'file:///tmp/file1', FILE 'file:///tmp/file2'");

Review Comment:
   could you give an example? (i am not sure that's supported in my parser syntax)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org