You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/08/14 16:02:36 UTC
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4692: Support references in i256 arithmetic ops
tustvold commented on code in PR #4692:
URL: https://github.com/apache/arrow-rs/pull/4692#discussion_r1293674707
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -659,6 +659,48 @@ macro_rules! derive_op {
self.$wrapping(rhs)
}
}
+
+ impl<'a> std::ops::$t<i256> for &'a i256 {
+ type Output = i256;
+
+ #[cfg(debug_assertions)]
Review Comment:
Could we just dereference the appropriate side as opposed to duplicating the debug_assertions logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org