You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/07 06:36:49 UTC
[GitHub] [skywalking-rocketbot-ui] TinyAllen opened a new pull request #293: Fix: Only check the real node
TinyAllen opened a new pull request #293:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: Re: Re: Whether it is necessary to add new rpc communication (ex:
thrift, dubbo).
Posted by Sheng Wu <wu...@gmail.com>.
Hi ChaoYao
My suggestion would be, if you only want the agent->backend using Dubbo(or
anything), you could consider to open your own repo, and implement the
plugins.
Those don't need the source code level change in the main repo.
Then we are open for you to add your repo as an agent and backend plugin
option in our main documentation.
People could download the plugin from your place, copy into skywalking and
change the configuration, then everything could work.
Does this make sense to you?
Sheng Wu 吴晟
Twitter, wusheng1108
ChenYao <br...@163.com> 于2020年5月8日周五 上午11:39写道：
> @wu Thanks. I get it.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> At 2020-05-08 10:20:12, "Sheng Wu" <wu...@gmail.com> wrote:
> >As you said, the gRPC is everywhere, including agent<->backend, inside OAP
> >cluster, exporter, alert, dynamic configuration
> >Are you want to support other RPC in all cases? That seems very complex.
> >
> >> Developers have a hard time solving sudden problems. For example, an
> >exception problem with the connected NO_ERROR. Provides multiple rpc
> >frameworks to make it easy for users to choose their own familiar rpc and
> >reduce learning costs.
> >
> >HTTP is added, but not all agents change, so such as if you add Dubbo,
> >there is a same thing, agent need to support this new protocol.
> >
> >Sheng Wu 吴晟
> >Twitter, wusheng1108
> >
> >
> >ChenYao <br...@163.com> 于2020年5月8日周五 上午9:59写道：
> >
> >> @all dear
> >>
> >>
> >>
> >> 1. grpc is an excellent rpc frame, unfamiliar with grpc
> >>
> >> Developers have a hard time solving sudden problems. For example, an
> >> exception problem with the connected NO_ERROR. Provides multiple rpc
> >> frameworks to make it easy for users to choose their own familiar rpc
> and
> >> reduce learning costs.
> >>
> >>
> >>
> >>
> >> 2. Skywalking uses grpc coupling degree is still relatively large,
> adding
> >> new rpc framework support, need to add a new level of abstraction.
> >>
> >>
> >> So ask if there is a need to add a new rpc frame.
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> 在 2020-05-07 21:04:25，"Sheng Wu" <wu...@gmail.com> 写道：
> >> >The whole system is open for extension, you could implement this
> easily.
> >> >If you want to push and host in the main repo, I think you need to
> answer
> >> >the question of why we should add these?
> >> >
> >> >Because, on the other hand, you will make the distribution size bigger,
> >> >including the image. I am wondering gRPC is a good RPC framework, why
> we
> >> >need others?
> >> >
> >> >Sheng Wu 吴晟
> >> >Twitter, wusheng1108
> >> >
> >> >
> >> >ChenYao <br...@163.com> 于2020年5月7日周四 下午6:26写道：
> >> >
> >> >> @all dear
> >> >>
> >> >>
> >> >>
> >> >> Whether it is necessary to add new rpc communication (ex: thrift,
> >> dubbo).
> >> >>
> >> >>
> >> >>
> >> >>
> >> >> https://github.com/apache/skywalking/issues/4620
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >> >>
> >>
>
Re:Re: Re: Whether it is necessary to add new rpc communication
(ex: thrift, dubbo).
Posted by ChenYao <br...@163.com>.
@wu Thanks. I get it.
At 2020-05-08 10:20:12, "Sheng Wu" <wu...@gmail.com> wrote:
>As you said, the gRPC is everywhere, including agent<->backend, inside OAP
>cluster, exporter, alert, dynamic configuration
>Are you want to support other RPC in all cases? That seems very complex.
>
>> Developers have a hard time solving sudden problems. For example, an
>exception problem with the connected NO_ERROR. Provides multiple rpc
>frameworks to make it easy for users to choose their own familiar rpc and
>reduce learning costs.
>
>HTTP is added, but not all agents change, so such as if you add Dubbo,
>there is a same thing, agent need to support this new protocol.
>
>Sheng Wu 吴晟
>Twitter, wusheng1108
>
>
>ChenYao <br...@163.com> 于2020年5月8日周五 上午9:59写道：
>
>> @all dear
>>
>>
>>
>> 1. grpc is an excellent rpc frame, unfamiliar with grpc
>>
>> Developers have a hard time solving sudden problems. For example, an
>> exception problem with the connected NO_ERROR. Provides multiple rpc
>> frameworks to make it easy for users to choose their own familiar rpc and
>> reduce learning costs.
>>
>>
>>
>>
>> 2. Skywalking uses grpc coupling degree is still relatively large, adding
>> new rpc framework support, need to add a new level of abstraction.
>>
>>
>> So ask if there is a need to add a new rpc frame.
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> 在 2020-05-07 21:04:25，"Sheng Wu" <wu...@gmail.com> 写道：
>> >The whole system is open for extension, you could implement this easily.
>> >If you want to push and host in the main repo, I think you need to answer
>> >the question of why we should add these?
>> >
>> >Because, on the other hand, you will make the distribution size bigger,
>> >including the image. I am wondering gRPC is a good RPC framework, why we
>> >need others?
>> >
>> >Sheng Wu 吴晟
>> >Twitter, wusheng1108
>> >
>> >
>> >ChenYao <br...@163.com> 于2020年5月7日周四 下午6:26写道：
>> >
>> >> @all dear
>> >>
>> >>
>> >>
>> >> Whether it is necessary to add new rpc communication (ex: thrift,
>> dubbo).
>> >>
>> >>
>> >>
>> >>
>> >> https://github.com/apache/skywalking/issues/4620
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>>
Re: Re: Whether it is necessary to add new rpc communication (ex:
thrift, dubbo).
Posted by Sheng Wu <wu...@gmail.com>.
As you said, the gRPC is everywhere, including agent<->backend, inside OAP
cluster, exporter, alert, dynamic configuration
Are you want to support other RPC in all cases? That seems very complex.
> Developers have a hard time solving sudden problems. For example, an
exception problem with the connected NO_ERROR. Provides multiple rpc
frameworks to make it easy for users to choose their own familiar rpc and
reduce learning costs.
HTTP is added, but not all agents change, so such as if you add Dubbo,
there is a same thing, agent need to support this new protocol.
Sheng Wu 吴晟
Twitter, wusheng1108
ChenYao <br...@163.com> 于2020年5月8日周五 上午9:59写道：
> @all dear
>
>
>
> 1. grpc is an excellent rpc frame, unfamiliar with grpc
>
> Developers have a hard time solving sudden problems. For example, an
> exception problem with the connected NO_ERROR. Provides multiple rpc
> frameworks to make it easy for users to choose their own familiar rpc and
> reduce learning costs.
>
>
>
>
> 2. Skywalking uses grpc coupling degree is still relatively large, adding
> new rpc framework support, need to add a new level of abstraction.
>
>
> So ask if there is a need to add a new rpc frame.
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
> 在 2020-05-07 21:04:25，"Sheng Wu" <wu...@gmail.com> 写道：
> >The whole system is open for extension, you could implement this easily.
> >If you want to push and host in the main repo, I think you need to answer
> >the question of why we should add these?
> >
> >Because, on the other hand, you will make the distribution size bigger,
> >including the image. I am wondering gRPC is a good RPC framework, why we
> >need others?
> >
> >Sheng Wu 吴晟
> >Twitter, wusheng1108
> >
> >
> >ChenYao <br...@163.com> 于2020年5月7日周四 下午6:26写道：
> >
> >> @all dear
> >>
> >>
> >>
> >> Whether it is necessary to add new rpc communication (ex: thrift,
> dubbo).
> >>
> >>
> >>
> >>
> >> https://github.com/apache/skywalking/issues/4620
> >>
> >>
> >>
> >>
> >>
> >>
>
Re:Re: Whether it is necessary to add new rpc communication (ex:
thrift, dubbo).
Posted by ChenYao <br...@163.com>.
@all dear
1. grpc is an excellent rpc frame, unfamiliar with grpc
Developers have a hard time solving sudden problems. For example, an exception problem with the connected NO_ERROR. Provides multiple rpc frameworks to make it easy for users to choose their own familiar rpc and reduce learning costs.
2. Skywalking uses grpc coupling degree is still relatively large, adding new rpc framework support, need to add a new level of abstraction.
So ask if there is a need to add a new rpc frame.
在 2020-05-07 21:04:25，"Sheng Wu" <wu...@gmail.com> 写道：
>The whole system is open for extension, you could implement this easily.
>If you want to push and host in the main repo, I think you need to answer
>the question of why we should add these?
>
>Because, on the other hand, you will make the distribution size bigger,
>including the image. I am wondering gRPC is a good RPC framework, why we
>need others?
>
>Sheng Wu 吴晟
>Twitter, wusheng1108
>
>
>ChenYao <br...@163.com> 于2020年5月7日周四 下午6:26写道：
>
>> @all dear
>>
>>
>>
>> Whether it is necessary to add new rpc communication (ex: thrift, dubbo).
>>
>>
>>
>>
>> https://github.com/apache/skywalking/issues/4620
>>
>>
>>
>>
>>
>>
Re: Whether it is necessary to add new rpc communication (ex: thrift, dubbo).
Posted by Sheng Wu <wu...@gmail.com>.
The whole system is open for extension, you could implement this easily.
If you want to push and host in the main repo, I think you need to answer
the question of why we should add these?
Because, on the other hand, you will make the distribution size bigger,
including the image. I am wondering gRPC is a good RPC framework, why we
need others?
Sheng Wu 吴晟
Twitter, wusheng1108
ChenYao <br...@163.com> 于2020年5月7日周四 下午6:26写道：
> @all dear
>
>
>
> Whether it is necessary to add new rpc communication (ex: thrift, dubbo).
>
>
>
>
> https://github.com/apache/skywalking/issues/4620
>
>
>
>
>
>
Whether it is necessary to add new rpc communication (ex: thrift,
dubbo).
Posted by ChenYao <br...@163.com>.
@all dear
Whether it is necessary to add new rpc communication (ex: thrift, dubbo).
https://github.com/apache/skywalking/issues/4620