You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Ildar Absalyamov (Code Review)" <do...@asterixdb.incubator.apache.org> on 2015/10/09 09:01:58 UTC

Change in asterixdb[master]: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory...

Ildar Absalyamov has posted comments on this change.

Change subject: ASTERIXDB-1058: make Asterix compatible with lazy LSM memory allocation
......................................................................


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/408/6/asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java
File asterix-common/src/test/java/org/apache/asterix/test/aql/TestsUtils.java:

Line 213:                 System.out.println("None JSON Error Mesesage : " + errorBody);
Could this exception instead be rethrown upwards with a proper message?
In cluster setup who know where would stdout be redirected? On the other hand the callsite already manages to properly log the thrown exception


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/408
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ea1eb129fe3043d43b077473dc29d17a97dfcc2
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <hu...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Ildar Absalyamov <il...@gmail.com>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Carey <dt...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Yingyi Bu <bu...@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <ki...@gmail.com>
Gerrit-HasComments: Yes