[GitHub] [superset] jfrag1 commented on a diff in pull request #22027: feat: Add 3 new extension points for inserting custom icons

[GitBox <gi...@apache.org>]

jfrag1 commented on code in PR #22027:
URL: https://github.com/apache/superset/pull/22027#discussion_r1013360242


##########
superset-frontend/src/components/ReportModal/HeaderReportDropdown/index.tsx:
##########
@@ -204,7 +223,14 @@ export default function HeaderReportDropDown({
     ) : (
       <Menu selectable={false} css={onMenuHover}>
         <Menu.Item onClick={handleShowMenu}>
-          {t('Set up an email report')}
+          {DropdownItemExtension ? (
+            <StyledDropdownItemWithIcon>
+              <div>{t('Set up an email report')}</div>
+              <DropdownItemExtension />

Review Comment:
   I'm not sure here.  On one hand having the extension be a whole replacement would allow for much more flexibility for anyone looking to use it.  On the other hand, having it be specific provides one rigid supported pattern for the extension, which could be seen as a benefit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org