You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2026/03/13 09:53:27 UTC

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24097


Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................

IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

IMPALA-14592 introduced the concept of "hidden columns". Kudu's
auto-incrementing columns were already treated as hidden even
before we introduced that concept.

With this patch KuduColumn overrides isHidden() and return true
if column is auto-incrementing. This helped us simplifying the code
at a few places.

Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
6 files changed, 18 insertions(+), 27 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24097/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@202
PS1, Line 202:     if (column.isHidden()) {
Why did you move this check to the end? Worth calling out in the commit message.


http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@986
PS1, Line 986:       if (!matchFound && !tblColumn.isHidden()) {
Is this a necessary change for Iceberg? I don't think it changes the Kudu logic to pull the check up here.


http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a4766
PS1, Line 4766: 
Can you mention in the commit message that getColumnsInHiveOrder omits hidden columns as of IMPALA-14592? I overlooked that change and had to search a bit to find it.



-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 16:38:00 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

We should run the test suite on this. There's some Kudu test coverage for auto_incrementing_id.

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@202
PS1, Line 202:     if (column.isHidden()) {
> It isn't very crucial, I just didn't want to change this error message for 
Ack


http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@986
PS1, Line 986:       if (!matchFound) {
> Actually we can remove this check completely as we are iterating over table
Ack



-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 17:10:44 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

> auto-incrementing columns in kudu tables are half-hidden. They are not shown in 'select *',  but could be explicitly selected as auto_incrementing_id. Agree to show the column in DESCRIBE EXTENDED output.

+1
The reason for this behavior is to allow users to access this column data, if needed. (for example when trying to identify a row which can only be done by the entire primary key column set). Exposing it in DESCRIBE/DESCRIBE EXTENDED output is to allow the end user to confirm the column exists.

> omitting it during CREATE TABLE LIKE

This could mean the new table would have unique key columns then? AFAIK Impala doesn't create the auto_incrementing_id column explicitly during CREATE TABLE LIKE (as Kudu blocks it). It only declares the primary key columns are non-unique and Kudu will create this column internally.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 25 Mar 2026 19:29:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21936/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 10:21:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24097

to look at the new patch set (#2).

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................

IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

IMPALA-14592 introduced the concept of "hidden columns". Kudu's
auto-incrementing columns were already treated as hidden even
before we introduced that concept.

With this patch KuduColumn overrides isHidden() and return true
if column is auto-incrementing. This helped us simplifying the code
at a few places.

Table.getColumnsInHiveOrder() doesn't return hidden columns, which
means it's necessary to call isHidden() on the returned columns.

Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
6 files changed, 17 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24097/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/21973/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 18:39:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/21946/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 17:26:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13230/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 14:27:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24097

to look at the new patch set (#3).

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................

IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

IMPALA-14592 introduced the concept of "hidden columns". Kudu's
auto-incrementing columns were already treated as hidden even
before we introduced that concept.

With this patch KuduColumn overrides isHidden() and return true
if column is auto-incrementing. This helped us simplifying the code
at a few places.

Table.getColumnsInHiveOrder() doesn't return hidden columns, which
means it's not necessary to call isHidden() on the returned columns.

Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
6 files changed, 17 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24097/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13230/


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 18:45:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

auto-incrementing columns in kudu tables are half-hidden. They are not shown in 'select *',  but could be explicitly selected as auto_incrementing_id. Agree to show the column in DESCRIBE EXTENDED output.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Mar 2026 22:37:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

Looping in the original implementers of non-unique primary key support.

Hidden columns can still be explicitly referenced. I think there should be some way to discover that; showing them in DESCRIBE EXTENDED output seems like it would help.

My understanding would be that doing CTAS from a table with auto_incrementing_id should create a new table that also uses non-unique primary keys, so it would continue to include auto_incrementing_id. The mechanism to support that could differ.


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 15:26:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13241/


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 22:39:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

Seems like auto-incrementing columns are half-hidden only, as they appear in the DESCRIBE output: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/kudu_describe.test#L139

Removing them would be a breaking change, but it's probably the right thing to do.

CREATE TABLE LIKE also clones auto_incrementing_id, but I think it's a bug, even if we have a test for it: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/kudu_create_table_like_table.test#L112

I think the cleanest way to move forward is to remove auto_incrementing_id from the DESCRIBE output and omitting it during CREATE TABLE LIKE. What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 11:53:01 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24097

to look at the new patch set (#4).

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................

IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

IMPALA-14592 introduced the concept of "hidden columns". Kudu's
auto-incrementing columns were already treated as hidden even
before we introduced that concept.

With this patch KuduColumn overrides isHidden() and return true
if column is auto-incrementing. This helped us simplifying the code
at a few places.

Table.getColumnsInHiveOrder() doesn't return hidden columns, which
means it's not necessary to call isHidden() on the returned columns.

Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
---
M fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/analysis/KuduModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/SelectStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeTable.java
M fe/src/main/java/org/apache/impala/catalog/KuduColumn.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
7 files changed, 20 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24097/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13241/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Mar 2026 18:13:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24097 )

Change subject: IMPALA-14832: Make auto-incrementing Kudu columns hidden and simplify code
......................................................................


Patch Set 3:

(3 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java
File fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java@202
PS1, Line 202:     if (column.isHidden()) {
> Why did you move this check to the end? Worth calling out in the commit mes
It isn't very crucial, I just didn't want to change this error message for Kudu tables:

 "Cannot %s default value for %sprimary key column '%s'",
 isDropDefault_ ? "drop" : "set",
 col.isHidden() ? "system generated " : "", colName_));


http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
File fe/src/main/java/org/apache/impala/analysis/InsertStmt.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/analysis/InsertStmt.java@986
PS1, Line 986:       if (!matchFound) {
> Is this a necessary change for Iceberg? I don't think it changes the Kudu l
Actually we can remove this check completely as we are iterating over table_.getColumnsInHiveOrder(), which doesn't include hidden columns.


http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/24097/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@a4766
PS1, Line 4766: 
> Can you mention in the commit message that getColumnsInHiveOrder omits hidd
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5da031c5dcd93ed02a6f9a21006325c2077be1e9
Gerrit-Change-Number: 24097
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Mar 2026 17:00:40 +0000
Gerrit-HasComments: Yes