You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/23 12:11:54 UTC
[GitHub] [apisix-dashboard] Rushabh-Sukhadia opened a new pull request #2390: feat: keycloak password grant token generation uri property #2374
Rushabh-Sukhadia opened a new pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Keycloak plugin settings about "password grant type for token generation" are incorporated which are already merged in API SIX implementation.
Please refer:
**apache/apisix/issues/6574**
**apache/apisix/pull/6586**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2390: feat: keycloak password grant token generation uri property
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390#issuecomment-1085731173
> > Hi @Rushabh-Sukhadia, the `schema.json` file is automatically generated by the [Control API](https://apisix.apache.org/docs/apisix/control-api#get-v1schema), we prefer not to make manual changes. Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard
>
> We may need to replace the `schema.json` in this way. cc @bzp2010
Use this method to get the schema.json file and replace the file in the conf directory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Rushabh-Sukhadia commented on pull request #2390: feat: keycloak password grant token generation uri property
Posted by GitBox <gi...@apache.org>.
Rushabh-Sukhadia commented on pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390#issuecomment-1077260989
@Baoyuantop
I understood, reverted manual changes from schema.json file. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Rushabh-Sukhadia commented on pull request #2390: feat: keycloak password grant token generation uri property
Posted by GitBox <gi...@apache.org>.
Rushabh-Sukhadia commented on pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390#issuecomment-1084068284
Hi,
[@Baoyuantop](https://github.com/Baoyuantop)
[@bzp2010](https://github.com/bzp2010)
kindly review this PR or guide us a little if any changes needed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2390: feat: keycloak password grant token generation uri property
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390#issuecomment-1077328505
> Hi @Rushabh-Sukhadia, the `schema.json` file is automatically generated by the [Control API](https://apisix.apache.org/docs/apisix/control-api#get-v1schema), we prefer not to make manual changes. Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard
We may need to replace the `schema.json` in this way. cc @bzp2010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on pull request #2390: feat: keycloak password grant token generation uri property
Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on pull request #2390:
URL: https://github.com/apache/apisix-dashboard/pull/2390#issuecomment-1076988274
Hi @Rushabh-Sukhadia, the `schema.json` file is automatically generated by the [Control API](https://apisix.apache.org/docs/apisix/control-api#get-v1schema), we prefer not to make manual changes.
Also you can refer to https://apisix.apache.org/docs/dashboard/FAQ#4-after-modifying-the-plugin-schema-or-creating-a-custom-plugin-in-apache-apisix-why-cant-i-find-it-on-the-dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org