You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/11/13 14:52:07 UTC
[02/26] hbase-site git commit: Published site at
64c4861272aa03f714b4029ae7725f4286b77062.
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b9b09fec/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.AssignmentManagerForTest.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.AssignmentManagerForTest.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.AssignmentManagerForTest.html
new file mode 100644
index 0000000..2801fe4
--- /dev/null
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.AssignmentManagerForTest.html
@@ -0,0 +1,260 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html lang="en">
+<head>
+<title>Source code</title>
+<link rel="stylesheet" type="text/css" href="../../../../../../../stylesheet.css" title="Style">
+</head>
+<body>
+<div class="sourceContainer">
+<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
+<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
+<span class="sourceLineNo">003</span> * or more contributor license agreements. See the NOTICE file<a name="line.3"></a>
+<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
+<span class="sourceLineNo">005</span> * regarding copyright ownership. The ASF licenses this file<a name="line.5"></a>
+<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
+<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
+<span class="sourceLineNo">008</span> * with the License. You may obtain a copy of the License at<a name="line.8"></a>
+<span class="sourceLineNo">009</span> *<a name="line.9"></a>
+<span class="sourceLineNo">010</span> * http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
+<span class="sourceLineNo">011</span> *<a name="line.11"></a>
+<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
+<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
+<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
+<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
+<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
+<span class="sourceLineNo">017</span> */<a name="line.17"></a>
+<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.master.assignment;<a name="line.18"></a>
+<span class="sourceLineNo">019</span><a name="line.19"></a>
+<span class="sourceLineNo">020</span>import static org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.RegionStateTransitionState.REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE;<a name="line.20"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.assertEquals;<a name="line.21"></a>
+<span class="sourceLineNo">022</span><a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import java.util.Set;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import java.util.concurrent.CountDownLatch;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.util.concurrent.Future;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.conf.Configuration;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.HConstants;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.PleaseHoldException;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.ServerName;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.client.Put;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.client.Table;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.master.HMaster;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.master.MasterServices;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.master.RegionPlan;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.IdLock;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.zookeeper.KeeperException;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.AfterClass;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.BeforeClass;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.ClassRule;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Test;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.experimental.categories.Category;<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionRequest;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionResponse;<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.57"></a>
+<span class="sourceLineNo">058</span>public class TestReportOnlineRegionsRace {<a name="line.58"></a>
+<span class="sourceLineNo">059</span><a name="line.59"></a>
+<span class="sourceLineNo">060</span> @ClassRule<a name="line.60"></a>
+<span class="sourceLineNo">061</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.61"></a>
+<span class="sourceLineNo">062</span> HBaseClassTestRule.forClass(TestReportOnlineRegionsRace.class);<a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span> private static volatile CountDownLatch ARRIVE_RS_REPORT;<a name="line.64"></a>
+<span class="sourceLineNo">065</span> private static volatile CountDownLatch RESUME_RS_REPORT;<a name="line.65"></a>
+<span class="sourceLineNo">066</span> private static volatile CountDownLatch FINISH_RS_REPORT;<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span> private static volatile CountDownLatch RESUME_REPORT_STATE;<a name="line.68"></a>
+<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">070</span> private static final class AssignmentManagerForTest extends AssignmentManager {<a name="line.70"></a>
+<span class="sourceLineNo">071</span><a name="line.71"></a>
+<span class="sourceLineNo">072</span> public AssignmentManagerForTest(MasterServices master) {<a name="line.72"></a>
+<span class="sourceLineNo">073</span> super(master);<a name="line.73"></a>
+<span class="sourceLineNo">074</span> }<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span> @Override<a name="line.76"></a>
+<span class="sourceLineNo">077</span> public void reportOnlineRegions(ServerName serverName, Set<byte[]> regionNames) {<a name="line.77"></a>
+<span class="sourceLineNo">078</span> if (ARRIVE_RS_REPORT != null) {<a name="line.78"></a>
+<span class="sourceLineNo">079</span> ARRIVE_RS_REPORT.countDown();<a name="line.79"></a>
+<span class="sourceLineNo">080</span> try {<a name="line.80"></a>
+<span class="sourceLineNo">081</span> RESUME_RS_REPORT.await();<a name="line.81"></a>
+<span class="sourceLineNo">082</span> } catch (InterruptedException e) {<a name="line.82"></a>
+<span class="sourceLineNo">083</span> throw new RuntimeException(e);<a name="line.83"></a>
+<span class="sourceLineNo">084</span> }<a name="line.84"></a>
+<span class="sourceLineNo">085</span> }<a name="line.85"></a>
+<span class="sourceLineNo">086</span> super.reportOnlineRegions(serverName, regionNames);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> if (FINISH_RS_REPORT != null) {<a name="line.87"></a>
+<span class="sourceLineNo">088</span> FINISH_RS_REPORT.countDown();<a name="line.88"></a>
+<span class="sourceLineNo">089</span> }<a name="line.89"></a>
+<span class="sourceLineNo">090</span> }<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span> @Override<a name="line.92"></a>
+<span class="sourceLineNo">093</span> public ReportRegionStateTransitionResponse reportRegionStateTransition(<a name="line.93"></a>
+<span class="sourceLineNo">094</span> ReportRegionStateTransitionRequest req) throws PleaseHoldException {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> if (RESUME_REPORT_STATE != null) {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> try {<a name="line.96"></a>
+<span class="sourceLineNo">097</span> RESUME_REPORT_STATE.await();<a name="line.97"></a>
+<span class="sourceLineNo">098</span> } catch (InterruptedException e) {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> throw new RuntimeException(e);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> }<a name="line.100"></a>
+<span class="sourceLineNo">101</span> }<a name="line.101"></a>
+<span class="sourceLineNo">102</span> return super.reportRegionStateTransition(req);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> }<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span> }<a name="line.105"></a>
+<span class="sourceLineNo">106</span><a name="line.106"></a>
+<span class="sourceLineNo">107</span> public static final class HMasterForTest extends HMaster {<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span> public HMasterForTest(Configuration conf) throws IOException, KeeperException {<a name="line.109"></a>
+<span class="sourceLineNo">110</span> super(conf);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> }<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> @Override<a name="line.113"></a>
+<span class="sourceLineNo">114</span> protected AssignmentManager createAssignmentManager(MasterServices master) {<a name="line.114"></a>
+<span class="sourceLineNo">115</span> return new AssignmentManagerForTest(master);<a name="line.115"></a>
+<span class="sourceLineNo">116</span> }<a name="line.116"></a>
+<span class="sourceLineNo">117</span> }<a name="line.117"></a>
+<span class="sourceLineNo">118</span><a name="line.118"></a>
+<span class="sourceLineNo">119</span> private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.119"></a>
+<span class="sourceLineNo">120</span><a name="line.120"></a>
+<span class="sourceLineNo">121</span> private static TableName NAME = TableName.valueOf("Race");<a name="line.121"></a>
+<span class="sourceLineNo">122</span><a name="line.122"></a>
+<span class="sourceLineNo">123</span> private static byte[] CF = Bytes.toBytes("cf");<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span> @BeforeClass<a name="line.125"></a>
+<span class="sourceLineNo">126</span> public static void setUp() throws Exception {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> UTIL.getConfiguration().setClass(HConstants.MASTER_IMPL, HMasterForTest.class, HMaster.class);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> UTIL.getConfiguration().setInt("hbase.regionserver.msginterval", 1000);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> UTIL.startMiniCluster(1);<a name="line.129"></a>
+<span class="sourceLineNo">130</span> UTIL.createTable(NAME, CF);<a name="line.130"></a>
+<span class="sourceLineNo">131</span> UTIL.waitTableAvailable(NAME);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> }<a name="line.132"></a>
+<span class="sourceLineNo">133</span><a name="line.133"></a>
+<span class="sourceLineNo">134</span> @AfterClass<a name="line.134"></a>
+<span class="sourceLineNo">135</span> public static void tearDown() throws Exception {<a name="line.135"></a>
+<span class="sourceLineNo">136</span> UTIL.shutdownMiniCluster();<a name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span> @Test<a name="line.139"></a>
+<span class="sourceLineNo">140</span> public void testRace() throws Exception {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> RegionInfo region = UTIL.getMiniHBaseCluster().getRegions(NAME).get(0).getRegionInfo();<a name="line.141"></a>
+<span class="sourceLineNo">142</span> ProcedureExecutor<MasterProcedureEnv> procExec =<a name="line.142"></a>
+<span class="sourceLineNo">143</span> UTIL.getMiniHBaseCluster().getMaster().getMasterProcedureExecutor();<a name="line.143"></a>
+<span class="sourceLineNo">144</span> AssignmentManager am = UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager();<a name="line.144"></a>
+<span class="sourceLineNo">145</span> RegionStateNode rsn = am.getRegionStates().getRegionStateNode(region);<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span> // halt a regionServerReport<a name="line.147"></a>
+<span class="sourceLineNo">148</span> RESUME_RS_REPORT = new CountDownLatch(1);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> ARRIVE_RS_REPORT = new CountDownLatch(1);<a name="line.149"></a>
+<span class="sourceLineNo">150</span> FINISH_RS_REPORT = new CountDownLatch(1);<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span> ARRIVE_RS_REPORT.await();<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span> // schedule a TRSP to REOPEN the region<a name="line.154"></a>
+<span class="sourceLineNo">155</span> RESUME_REPORT_STATE = new CountDownLatch(1);<a name="line.155"></a>
+<span class="sourceLineNo">156</span> Future<byte[]> future =<a name="line.156"></a>
+<span class="sourceLineNo">157</span> am.moveAsync(new RegionPlan(region, rsn.getRegionLocation(), rsn.getRegionLocation()));<a name="line.157"></a>
+<span class="sourceLineNo">158</span> TransitRegionStateProcedure proc =<a name="line.158"></a>
+<span class="sourceLineNo">159</span> procExec.getProcedures().stream().filter(p -> p instanceof TransitRegionStateProcedure)<a name="line.159"></a>
+<span class="sourceLineNo">160</span> .filter(p -> !p.isFinished()).map(p -> (TransitRegionStateProcedure) p).findAny().get();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> IdLock procExecLock = procExec.getProcExecutionLock();<a name="line.161"></a>
+<span class="sourceLineNo">162</span> // a CloseRegionProcedure and then the OpenRegionProcedure we want to block<a name="line.162"></a>
+<span class="sourceLineNo">163</span> IdLock.Entry lockEntry = procExecLock.getLockEntry(proc.getProcId() + 2);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> // resume the reportRegionStateTransition to finish the CloseRegionProcedure<a name="line.164"></a>
+<span class="sourceLineNo">165</span> RESUME_REPORT_STATE.countDown();<a name="line.165"></a>
+<span class="sourceLineNo">166</span> // wait until we schedule the OpenRegionProcedure<a name="line.166"></a>
+<span class="sourceLineNo">167</span> UTIL.waitFor(10000,<a name="line.167"></a>
+<span class="sourceLineNo">168</span> () -> proc.getCurrentStateId() == REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE);<a name="line.168"></a>
+<span class="sourceLineNo">169</span> // the region should be in OPENING state<a name="line.169"></a>
+<span class="sourceLineNo">170</span> assertEquals(RegionState.State.OPENING, rsn.getState());<a name="line.170"></a>
+<span class="sourceLineNo">171</span> // resume the region server report<a name="line.171"></a>
+<span class="sourceLineNo">172</span> RESUME_RS_REPORT.countDown();<a name="line.172"></a>
+<span class="sourceLineNo">173</span> // wait until it finishes, it will find that the region is opened on the rs<a name="line.173"></a>
+<span class="sourceLineNo">174</span> FINISH_RS_REPORT.await();<a name="line.174"></a>
+<span class="sourceLineNo">175</span> // let the OpenRegionProcedure go<a name="line.175"></a>
+<span class="sourceLineNo">176</span> procExecLock.releaseLockEntry(lockEntry);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> // wait until the TRSP is done<a name="line.177"></a>
+<span class="sourceLineNo">178</span> future.get();<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> // confirm that the region can still be write, i.e, the regionServerReport method should not<a name="line.180"></a>
+<span class="sourceLineNo">181</span> // change the region state to OPEN<a name="line.181"></a>
+<span class="sourceLineNo">182</span> try (Table table = UTIL.getConnection().getTableBuilder(NAME, null).setWriteRpcTimeout(1000)<a name="line.182"></a>
+<span class="sourceLineNo">183</span> .setOperationTimeout(2000).build()) {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> table.put(<a name="line.184"></a>
+<span class="sourceLineNo">185</span> new Put(Bytes.toBytes("key")).addColumn(CF, Bytes.toBytes("cq"), Bytes.toBytes("val")));<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span>}<a name="line.188"></a>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+</pre>
+</div>
+</body>
+</html>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b9b09fec/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.HMasterForTest.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.HMasterForTest.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.HMasterForTest.html
new file mode 100644
index 0000000..2801fe4
--- /dev/null
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.HMasterForTest.html
@@ -0,0 +1,260 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html lang="en">
+<head>
+<title>Source code</title>
+<link rel="stylesheet" type="text/css" href="../../../../../../../stylesheet.css" title="Style">
+</head>
+<body>
+<div class="sourceContainer">
+<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
+<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
+<span class="sourceLineNo">003</span> * or more contributor license agreements. See the NOTICE file<a name="line.3"></a>
+<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
+<span class="sourceLineNo">005</span> * regarding copyright ownership. The ASF licenses this file<a name="line.5"></a>
+<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
+<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
+<span class="sourceLineNo">008</span> * with the License. You may obtain a copy of the License at<a name="line.8"></a>
+<span class="sourceLineNo">009</span> *<a name="line.9"></a>
+<span class="sourceLineNo">010</span> * http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
+<span class="sourceLineNo">011</span> *<a name="line.11"></a>
+<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
+<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
+<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
+<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
+<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
+<span class="sourceLineNo">017</span> */<a name="line.17"></a>
+<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.master.assignment;<a name="line.18"></a>
+<span class="sourceLineNo">019</span><a name="line.19"></a>
+<span class="sourceLineNo">020</span>import static org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.RegionStateTransitionState.REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE;<a name="line.20"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.assertEquals;<a name="line.21"></a>
+<span class="sourceLineNo">022</span><a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import java.util.Set;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import java.util.concurrent.CountDownLatch;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.util.concurrent.Future;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.conf.Configuration;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.HConstants;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.PleaseHoldException;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.ServerName;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.client.Put;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.client.Table;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.master.HMaster;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.master.MasterServices;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.master.RegionPlan;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.IdLock;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.zookeeper.KeeperException;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.AfterClass;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.BeforeClass;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.ClassRule;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Test;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.experimental.categories.Category;<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionRequest;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionResponse;<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.57"></a>
+<span class="sourceLineNo">058</span>public class TestReportOnlineRegionsRace {<a name="line.58"></a>
+<span class="sourceLineNo">059</span><a name="line.59"></a>
+<span class="sourceLineNo">060</span> @ClassRule<a name="line.60"></a>
+<span class="sourceLineNo">061</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.61"></a>
+<span class="sourceLineNo">062</span> HBaseClassTestRule.forClass(TestReportOnlineRegionsRace.class);<a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span> private static volatile CountDownLatch ARRIVE_RS_REPORT;<a name="line.64"></a>
+<span class="sourceLineNo">065</span> private static volatile CountDownLatch RESUME_RS_REPORT;<a name="line.65"></a>
+<span class="sourceLineNo">066</span> private static volatile CountDownLatch FINISH_RS_REPORT;<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span> private static volatile CountDownLatch RESUME_REPORT_STATE;<a name="line.68"></a>
+<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">070</span> private static final class AssignmentManagerForTest extends AssignmentManager {<a name="line.70"></a>
+<span class="sourceLineNo">071</span><a name="line.71"></a>
+<span class="sourceLineNo">072</span> public AssignmentManagerForTest(MasterServices master) {<a name="line.72"></a>
+<span class="sourceLineNo">073</span> super(master);<a name="line.73"></a>
+<span class="sourceLineNo">074</span> }<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span> @Override<a name="line.76"></a>
+<span class="sourceLineNo">077</span> public void reportOnlineRegions(ServerName serverName, Set<byte[]> regionNames) {<a name="line.77"></a>
+<span class="sourceLineNo">078</span> if (ARRIVE_RS_REPORT != null) {<a name="line.78"></a>
+<span class="sourceLineNo">079</span> ARRIVE_RS_REPORT.countDown();<a name="line.79"></a>
+<span class="sourceLineNo">080</span> try {<a name="line.80"></a>
+<span class="sourceLineNo">081</span> RESUME_RS_REPORT.await();<a name="line.81"></a>
+<span class="sourceLineNo">082</span> } catch (InterruptedException e) {<a name="line.82"></a>
+<span class="sourceLineNo">083</span> throw new RuntimeException(e);<a name="line.83"></a>
+<span class="sourceLineNo">084</span> }<a name="line.84"></a>
+<span class="sourceLineNo">085</span> }<a name="line.85"></a>
+<span class="sourceLineNo">086</span> super.reportOnlineRegions(serverName, regionNames);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> if (FINISH_RS_REPORT != null) {<a name="line.87"></a>
+<span class="sourceLineNo">088</span> FINISH_RS_REPORT.countDown();<a name="line.88"></a>
+<span class="sourceLineNo">089</span> }<a name="line.89"></a>
+<span class="sourceLineNo">090</span> }<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span> @Override<a name="line.92"></a>
+<span class="sourceLineNo">093</span> public ReportRegionStateTransitionResponse reportRegionStateTransition(<a name="line.93"></a>
+<span class="sourceLineNo">094</span> ReportRegionStateTransitionRequest req) throws PleaseHoldException {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> if (RESUME_REPORT_STATE != null) {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> try {<a name="line.96"></a>
+<span class="sourceLineNo">097</span> RESUME_REPORT_STATE.await();<a name="line.97"></a>
+<span class="sourceLineNo">098</span> } catch (InterruptedException e) {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> throw new RuntimeException(e);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> }<a name="line.100"></a>
+<span class="sourceLineNo">101</span> }<a name="line.101"></a>
+<span class="sourceLineNo">102</span> return super.reportRegionStateTransition(req);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> }<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span> }<a name="line.105"></a>
+<span class="sourceLineNo">106</span><a name="line.106"></a>
+<span class="sourceLineNo">107</span> public static final class HMasterForTest extends HMaster {<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span> public HMasterForTest(Configuration conf) throws IOException, KeeperException {<a name="line.109"></a>
+<span class="sourceLineNo">110</span> super(conf);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> }<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> @Override<a name="line.113"></a>
+<span class="sourceLineNo">114</span> protected AssignmentManager createAssignmentManager(MasterServices master) {<a name="line.114"></a>
+<span class="sourceLineNo">115</span> return new AssignmentManagerForTest(master);<a name="line.115"></a>
+<span class="sourceLineNo">116</span> }<a name="line.116"></a>
+<span class="sourceLineNo">117</span> }<a name="line.117"></a>
+<span class="sourceLineNo">118</span><a name="line.118"></a>
+<span class="sourceLineNo">119</span> private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.119"></a>
+<span class="sourceLineNo">120</span><a name="line.120"></a>
+<span class="sourceLineNo">121</span> private static TableName NAME = TableName.valueOf("Race");<a name="line.121"></a>
+<span class="sourceLineNo">122</span><a name="line.122"></a>
+<span class="sourceLineNo">123</span> private static byte[] CF = Bytes.toBytes("cf");<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span> @BeforeClass<a name="line.125"></a>
+<span class="sourceLineNo">126</span> public static void setUp() throws Exception {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> UTIL.getConfiguration().setClass(HConstants.MASTER_IMPL, HMasterForTest.class, HMaster.class);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> UTIL.getConfiguration().setInt("hbase.regionserver.msginterval", 1000);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> UTIL.startMiniCluster(1);<a name="line.129"></a>
+<span class="sourceLineNo">130</span> UTIL.createTable(NAME, CF);<a name="line.130"></a>
+<span class="sourceLineNo">131</span> UTIL.waitTableAvailable(NAME);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> }<a name="line.132"></a>
+<span class="sourceLineNo">133</span><a name="line.133"></a>
+<span class="sourceLineNo">134</span> @AfterClass<a name="line.134"></a>
+<span class="sourceLineNo">135</span> public static void tearDown() throws Exception {<a name="line.135"></a>
+<span class="sourceLineNo">136</span> UTIL.shutdownMiniCluster();<a name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span> @Test<a name="line.139"></a>
+<span class="sourceLineNo">140</span> public void testRace() throws Exception {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> RegionInfo region = UTIL.getMiniHBaseCluster().getRegions(NAME).get(0).getRegionInfo();<a name="line.141"></a>
+<span class="sourceLineNo">142</span> ProcedureExecutor<MasterProcedureEnv> procExec =<a name="line.142"></a>
+<span class="sourceLineNo">143</span> UTIL.getMiniHBaseCluster().getMaster().getMasterProcedureExecutor();<a name="line.143"></a>
+<span class="sourceLineNo">144</span> AssignmentManager am = UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager();<a name="line.144"></a>
+<span class="sourceLineNo">145</span> RegionStateNode rsn = am.getRegionStates().getRegionStateNode(region);<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span> // halt a regionServerReport<a name="line.147"></a>
+<span class="sourceLineNo">148</span> RESUME_RS_REPORT = new CountDownLatch(1);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> ARRIVE_RS_REPORT = new CountDownLatch(1);<a name="line.149"></a>
+<span class="sourceLineNo">150</span> FINISH_RS_REPORT = new CountDownLatch(1);<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span> ARRIVE_RS_REPORT.await();<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span> // schedule a TRSP to REOPEN the region<a name="line.154"></a>
+<span class="sourceLineNo">155</span> RESUME_REPORT_STATE = new CountDownLatch(1);<a name="line.155"></a>
+<span class="sourceLineNo">156</span> Future<byte[]> future =<a name="line.156"></a>
+<span class="sourceLineNo">157</span> am.moveAsync(new RegionPlan(region, rsn.getRegionLocation(), rsn.getRegionLocation()));<a name="line.157"></a>
+<span class="sourceLineNo">158</span> TransitRegionStateProcedure proc =<a name="line.158"></a>
+<span class="sourceLineNo">159</span> procExec.getProcedures().stream().filter(p -> p instanceof TransitRegionStateProcedure)<a name="line.159"></a>
+<span class="sourceLineNo">160</span> .filter(p -> !p.isFinished()).map(p -> (TransitRegionStateProcedure) p).findAny().get();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> IdLock procExecLock = procExec.getProcExecutionLock();<a name="line.161"></a>
+<span class="sourceLineNo">162</span> // a CloseRegionProcedure and then the OpenRegionProcedure we want to block<a name="line.162"></a>
+<span class="sourceLineNo">163</span> IdLock.Entry lockEntry = procExecLock.getLockEntry(proc.getProcId() + 2);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> // resume the reportRegionStateTransition to finish the CloseRegionProcedure<a name="line.164"></a>
+<span class="sourceLineNo">165</span> RESUME_REPORT_STATE.countDown();<a name="line.165"></a>
+<span class="sourceLineNo">166</span> // wait until we schedule the OpenRegionProcedure<a name="line.166"></a>
+<span class="sourceLineNo">167</span> UTIL.waitFor(10000,<a name="line.167"></a>
+<span class="sourceLineNo">168</span> () -> proc.getCurrentStateId() == REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE);<a name="line.168"></a>
+<span class="sourceLineNo">169</span> // the region should be in OPENING state<a name="line.169"></a>
+<span class="sourceLineNo">170</span> assertEquals(RegionState.State.OPENING, rsn.getState());<a name="line.170"></a>
+<span class="sourceLineNo">171</span> // resume the region server report<a name="line.171"></a>
+<span class="sourceLineNo">172</span> RESUME_RS_REPORT.countDown();<a name="line.172"></a>
+<span class="sourceLineNo">173</span> // wait until it finishes, it will find that the region is opened on the rs<a name="line.173"></a>
+<span class="sourceLineNo">174</span> FINISH_RS_REPORT.await();<a name="line.174"></a>
+<span class="sourceLineNo">175</span> // let the OpenRegionProcedure go<a name="line.175"></a>
+<span class="sourceLineNo">176</span> procExecLock.releaseLockEntry(lockEntry);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> // wait until the TRSP is done<a name="line.177"></a>
+<span class="sourceLineNo">178</span> future.get();<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> // confirm that the region can still be write, i.e, the regionServerReport method should not<a name="line.180"></a>
+<span class="sourceLineNo">181</span> // change the region state to OPEN<a name="line.181"></a>
+<span class="sourceLineNo">182</span> try (Table table = UTIL.getConnection().getTableBuilder(NAME, null).setWriteRpcTimeout(1000)<a name="line.182"></a>
+<span class="sourceLineNo">183</span> .setOperationTimeout(2000).build()) {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> table.put(<a name="line.184"></a>
+<span class="sourceLineNo">185</span> new Put(Bytes.toBytes("key")).addColumn(CF, Bytes.toBytes("cq"), Bytes.toBytes("val")));<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span>}<a name="line.188"></a>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+</pre>
+</div>
+</body>
+</html>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b9b09fec/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.html
new file mode 100644
index 0000000..2801fe4
--- /dev/null
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/assignment/TestReportOnlineRegionsRace.html
@@ -0,0 +1,260 @@
+<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
+<html lang="en">
+<head>
+<title>Source code</title>
+<link rel="stylesheet" type="text/css" href="../../../../../../../stylesheet.css" title="Style">
+</head>
+<body>
+<div class="sourceContainer">
+<pre><span class="sourceLineNo">001</span>/**<a name="line.1"></a>
+<span class="sourceLineNo">002</span> * Licensed to the Apache Software Foundation (ASF) under one<a name="line.2"></a>
+<span class="sourceLineNo">003</span> * or more contributor license agreements. See the NOTICE file<a name="line.3"></a>
+<span class="sourceLineNo">004</span> * distributed with this work for additional information<a name="line.4"></a>
+<span class="sourceLineNo">005</span> * regarding copyright ownership. The ASF licenses this file<a name="line.5"></a>
+<span class="sourceLineNo">006</span> * to you under the Apache License, Version 2.0 (the<a name="line.6"></a>
+<span class="sourceLineNo">007</span> * "License"); you may not use this file except in compliance<a name="line.7"></a>
+<span class="sourceLineNo">008</span> * with the License. You may obtain a copy of the License at<a name="line.8"></a>
+<span class="sourceLineNo">009</span> *<a name="line.9"></a>
+<span class="sourceLineNo">010</span> * http://www.apache.org/licenses/LICENSE-2.0<a name="line.10"></a>
+<span class="sourceLineNo">011</span> *<a name="line.11"></a>
+<span class="sourceLineNo">012</span> * Unless required by applicable law or agreed to in writing, software<a name="line.12"></a>
+<span class="sourceLineNo">013</span> * distributed under the License is distributed on an "AS IS" BASIS,<a name="line.13"></a>
+<span class="sourceLineNo">014</span> * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.<a name="line.14"></a>
+<span class="sourceLineNo">015</span> * See the License for the specific language governing permissions and<a name="line.15"></a>
+<span class="sourceLineNo">016</span> * limitations under the License.<a name="line.16"></a>
+<span class="sourceLineNo">017</span> */<a name="line.17"></a>
+<span class="sourceLineNo">018</span>package org.apache.hadoop.hbase.master.assignment;<a name="line.18"></a>
+<span class="sourceLineNo">019</span><a name="line.19"></a>
+<span class="sourceLineNo">020</span>import static org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProcedureProtos.RegionStateTransitionState.REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE;<a name="line.20"></a>
+<span class="sourceLineNo">021</span>import static org.junit.Assert.assertEquals;<a name="line.21"></a>
+<span class="sourceLineNo">022</span><a name="line.22"></a>
+<span class="sourceLineNo">023</span>import java.io.IOException;<a name="line.23"></a>
+<span class="sourceLineNo">024</span>import java.util.Set;<a name="line.24"></a>
+<span class="sourceLineNo">025</span>import java.util.concurrent.CountDownLatch;<a name="line.25"></a>
+<span class="sourceLineNo">026</span>import java.util.concurrent.Future;<a name="line.26"></a>
+<span class="sourceLineNo">027</span>import org.apache.hadoop.conf.Configuration;<a name="line.27"></a>
+<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.HBaseClassTestRule;<a name="line.28"></a>
+<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.HBaseTestingUtility;<a name="line.29"></a>
+<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.HConstants;<a name="line.30"></a>
+<span class="sourceLineNo">031</span>import org.apache.hadoop.hbase.PleaseHoldException;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.apache.hadoop.hbase.ServerName;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.apache.hadoop.hbase.TableName;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.apache.hadoop.hbase.client.Put;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.apache.hadoop.hbase.client.RegionInfo;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.apache.hadoop.hbase.client.Table;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.apache.hadoop.hbase.master.HMaster;<a name="line.37"></a>
+<span class="sourceLineNo">038</span>import org.apache.hadoop.hbase.master.MasterServices;<a name="line.38"></a>
+<span class="sourceLineNo">039</span>import org.apache.hadoop.hbase.master.RegionPlan;<a name="line.39"></a>
+<span class="sourceLineNo">040</span>import org.apache.hadoop.hbase.master.RegionState;<a name="line.40"></a>
+<span class="sourceLineNo">041</span>import org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv;<a name="line.41"></a>
+<span class="sourceLineNo">042</span>import org.apache.hadoop.hbase.procedure2.ProcedureExecutor;<a name="line.42"></a>
+<span class="sourceLineNo">043</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.43"></a>
+<span class="sourceLineNo">044</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.44"></a>
+<span class="sourceLineNo">045</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.45"></a>
+<span class="sourceLineNo">046</span>import org.apache.hadoop.hbase.util.IdLock;<a name="line.46"></a>
+<span class="sourceLineNo">047</span>import org.apache.zookeeper.KeeperException;<a name="line.47"></a>
+<span class="sourceLineNo">048</span>import org.junit.AfterClass;<a name="line.48"></a>
+<span class="sourceLineNo">049</span>import org.junit.BeforeClass;<a name="line.49"></a>
+<span class="sourceLineNo">050</span>import org.junit.ClassRule;<a name="line.50"></a>
+<span class="sourceLineNo">051</span>import org.junit.Test;<a name="line.51"></a>
+<span class="sourceLineNo">052</span>import org.junit.experimental.categories.Category;<a name="line.52"></a>
+<span class="sourceLineNo">053</span><a name="line.53"></a>
+<span class="sourceLineNo">054</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionRequest;<a name="line.54"></a>
+<span class="sourceLineNo">055</span>import org.apache.hadoop.hbase.shaded.protobuf.generated.RegionServerStatusProtos.ReportRegionStateTransitionResponse;<a name="line.55"></a>
+<span class="sourceLineNo">056</span><a name="line.56"></a>
+<span class="sourceLineNo">057</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.57"></a>
+<span class="sourceLineNo">058</span>public class TestReportOnlineRegionsRace {<a name="line.58"></a>
+<span class="sourceLineNo">059</span><a name="line.59"></a>
+<span class="sourceLineNo">060</span> @ClassRule<a name="line.60"></a>
+<span class="sourceLineNo">061</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.61"></a>
+<span class="sourceLineNo">062</span> HBaseClassTestRule.forClass(TestReportOnlineRegionsRace.class);<a name="line.62"></a>
+<span class="sourceLineNo">063</span><a name="line.63"></a>
+<span class="sourceLineNo">064</span> private static volatile CountDownLatch ARRIVE_RS_REPORT;<a name="line.64"></a>
+<span class="sourceLineNo">065</span> private static volatile CountDownLatch RESUME_RS_REPORT;<a name="line.65"></a>
+<span class="sourceLineNo">066</span> private static volatile CountDownLatch FINISH_RS_REPORT;<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span> private static volatile CountDownLatch RESUME_REPORT_STATE;<a name="line.68"></a>
+<span class="sourceLineNo">069</span><a name="line.69"></a>
+<span class="sourceLineNo">070</span> private static final class AssignmentManagerForTest extends AssignmentManager {<a name="line.70"></a>
+<span class="sourceLineNo">071</span><a name="line.71"></a>
+<span class="sourceLineNo">072</span> public AssignmentManagerForTest(MasterServices master) {<a name="line.72"></a>
+<span class="sourceLineNo">073</span> super(master);<a name="line.73"></a>
+<span class="sourceLineNo">074</span> }<a name="line.74"></a>
+<span class="sourceLineNo">075</span><a name="line.75"></a>
+<span class="sourceLineNo">076</span> @Override<a name="line.76"></a>
+<span class="sourceLineNo">077</span> public void reportOnlineRegions(ServerName serverName, Set<byte[]> regionNames) {<a name="line.77"></a>
+<span class="sourceLineNo">078</span> if (ARRIVE_RS_REPORT != null) {<a name="line.78"></a>
+<span class="sourceLineNo">079</span> ARRIVE_RS_REPORT.countDown();<a name="line.79"></a>
+<span class="sourceLineNo">080</span> try {<a name="line.80"></a>
+<span class="sourceLineNo">081</span> RESUME_RS_REPORT.await();<a name="line.81"></a>
+<span class="sourceLineNo">082</span> } catch (InterruptedException e) {<a name="line.82"></a>
+<span class="sourceLineNo">083</span> throw new RuntimeException(e);<a name="line.83"></a>
+<span class="sourceLineNo">084</span> }<a name="line.84"></a>
+<span class="sourceLineNo">085</span> }<a name="line.85"></a>
+<span class="sourceLineNo">086</span> super.reportOnlineRegions(serverName, regionNames);<a name="line.86"></a>
+<span class="sourceLineNo">087</span> if (FINISH_RS_REPORT != null) {<a name="line.87"></a>
+<span class="sourceLineNo">088</span> FINISH_RS_REPORT.countDown();<a name="line.88"></a>
+<span class="sourceLineNo">089</span> }<a name="line.89"></a>
+<span class="sourceLineNo">090</span> }<a name="line.90"></a>
+<span class="sourceLineNo">091</span><a name="line.91"></a>
+<span class="sourceLineNo">092</span> @Override<a name="line.92"></a>
+<span class="sourceLineNo">093</span> public ReportRegionStateTransitionResponse reportRegionStateTransition(<a name="line.93"></a>
+<span class="sourceLineNo">094</span> ReportRegionStateTransitionRequest req) throws PleaseHoldException {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> if (RESUME_REPORT_STATE != null) {<a name="line.95"></a>
+<span class="sourceLineNo">096</span> try {<a name="line.96"></a>
+<span class="sourceLineNo">097</span> RESUME_REPORT_STATE.await();<a name="line.97"></a>
+<span class="sourceLineNo">098</span> } catch (InterruptedException e) {<a name="line.98"></a>
+<span class="sourceLineNo">099</span> throw new RuntimeException(e);<a name="line.99"></a>
+<span class="sourceLineNo">100</span> }<a name="line.100"></a>
+<span class="sourceLineNo">101</span> }<a name="line.101"></a>
+<span class="sourceLineNo">102</span> return super.reportRegionStateTransition(req);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> }<a name="line.103"></a>
+<span class="sourceLineNo">104</span><a name="line.104"></a>
+<span class="sourceLineNo">105</span> }<a name="line.105"></a>
+<span class="sourceLineNo">106</span><a name="line.106"></a>
+<span class="sourceLineNo">107</span> public static final class HMasterForTest extends HMaster {<a name="line.107"></a>
+<span class="sourceLineNo">108</span><a name="line.108"></a>
+<span class="sourceLineNo">109</span> public HMasterForTest(Configuration conf) throws IOException, KeeperException {<a name="line.109"></a>
+<span class="sourceLineNo">110</span> super(conf);<a name="line.110"></a>
+<span class="sourceLineNo">111</span> }<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> @Override<a name="line.113"></a>
+<span class="sourceLineNo">114</span> protected AssignmentManager createAssignmentManager(MasterServices master) {<a name="line.114"></a>
+<span class="sourceLineNo">115</span> return new AssignmentManagerForTest(master);<a name="line.115"></a>
+<span class="sourceLineNo">116</span> }<a name="line.116"></a>
+<span class="sourceLineNo">117</span> }<a name="line.117"></a>
+<span class="sourceLineNo">118</span><a name="line.118"></a>
+<span class="sourceLineNo">119</span> private static final HBaseTestingUtility UTIL = new HBaseTestingUtility();<a name="line.119"></a>
+<span class="sourceLineNo">120</span><a name="line.120"></a>
+<span class="sourceLineNo">121</span> private static TableName NAME = TableName.valueOf("Race");<a name="line.121"></a>
+<span class="sourceLineNo">122</span><a name="line.122"></a>
+<span class="sourceLineNo">123</span> private static byte[] CF = Bytes.toBytes("cf");<a name="line.123"></a>
+<span class="sourceLineNo">124</span><a name="line.124"></a>
+<span class="sourceLineNo">125</span> @BeforeClass<a name="line.125"></a>
+<span class="sourceLineNo">126</span> public static void setUp() throws Exception {<a name="line.126"></a>
+<span class="sourceLineNo">127</span> UTIL.getConfiguration().setClass(HConstants.MASTER_IMPL, HMasterForTest.class, HMaster.class);<a name="line.127"></a>
+<span class="sourceLineNo">128</span> UTIL.getConfiguration().setInt("hbase.regionserver.msginterval", 1000);<a name="line.128"></a>
+<span class="sourceLineNo">129</span> UTIL.startMiniCluster(1);<a name="line.129"></a>
+<span class="sourceLineNo">130</span> UTIL.createTable(NAME, CF);<a name="line.130"></a>
+<span class="sourceLineNo">131</span> UTIL.waitTableAvailable(NAME);<a name="line.131"></a>
+<span class="sourceLineNo">132</span> }<a name="line.132"></a>
+<span class="sourceLineNo">133</span><a name="line.133"></a>
+<span class="sourceLineNo">134</span> @AfterClass<a name="line.134"></a>
+<span class="sourceLineNo">135</span> public static void tearDown() throws Exception {<a name="line.135"></a>
+<span class="sourceLineNo">136</span> UTIL.shutdownMiniCluster();<a name="line.136"></a>
+<span class="sourceLineNo">137</span> }<a name="line.137"></a>
+<span class="sourceLineNo">138</span><a name="line.138"></a>
+<span class="sourceLineNo">139</span> @Test<a name="line.139"></a>
+<span class="sourceLineNo">140</span> public void testRace() throws Exception {<a name="line.140"></a>
+<span class="sourceLineNo">141</span> RegionInfo region = UTIL.getMiniHBaseCluster().getRegions(NAME).get(0).getRegionInfo();<a name="line.141"></a>
+<span class="sourceLineNo">142</span> ProcedureExecutor<MasterProcedureEnv> procExec =<a name="line.142"></a>
+<span class="sourceLineNo">143</span> UTIL.getMiniHBaseCluster().getMaster().getMasterProcedureExecutor();<a name="line.143"></a>
+<span class="sourceLineNo">144</span> AssignmentManager am = UTIL.getMiniHBaseCluster().getMaster().getAssignmentManager();<a name="line.144"></a>
+<span class="sourceLineNo">145</span> RegionStateNode rsn = am.getRegionStates().getRegionStateNode(region);<a name="line.145"></a>
+<span class="sourceLineNo">146</span><a name="line.146"></a>
+<span class="sourceLineNo">147</span> // halt a regionServerReport<a name="line.147"></a>
+<span class="sourceLineNo">148</span> RESUME_RS_REPORT = new CountDownLatch(1);<a name="line.148"></a>
+<span class="sourceLineNo">149</span> ARRIVE_RS_REPORT = new CountDownLatch(1);<a name="line.149"></a>
+<span class="sourceLineNo">150</span> FINISH_RS_REPORT = new CountDownLatch(1);<a name="line.150"></a>
+<span class="sourceLineNo">151</span><a name="line.151"></a>
+<span class="sourceLineNo">152</span> ARRIVE_RS_REPORT.await();<a name="line.152"></a>
+<span class="sourceLineNo">153</span><a name="line.153"></a>
+<span class="sourceLineNo">154</span> // schedule a TRSP to REOPEN the region<a name="line.154"></a>
+<span class="sourceLineNo">155</span> RESUME_REPORT_STATE = new CountDownLatch(1);<a name="line.155"></a>
+<span class="sourceLineNo">156</span> Future<byte[]> future =<a name="line.156"></a>
+<span class="sourceLineNo">157</span> am.moveAsync(new RegionPlan(region, rsn.getRegionLocation(), rsn.getRegionLocation()));<a name="line.157"></a>
+<span class="sourceLineNo">158</span> TransitRegionStateProcedure proc =<a name="line.158"></a>
+<span class="sourceLineNo">159</span> procExec.getProcedures().stream().filter(p -> p instanceof TransitRegionStateProcedure)<a name="line.159"></a>
+<span class="sourceLineNo">160</span> .filter(p -> !p.isFinished()).map(p -> (TransitRegionStateProcedure) p).findAny().get();<a name="line.160"></a>
+<span class="sourceLineNo">161</span> IdLock procExecLock = procExec.getProcExecutionLock();<a name="line.161"></a>
+<span class="sourceLineNo">162</span> // a CloseRegionProcedure and then the OpenRegionProcedure we want to block<a name="line.162"></a>
+<span class="sourceLineNo">163</span> IdLock.Entry lockEntry = procExecLock.getLockEntry(proc.getProcId() + 2);<a name="line.163"></a>
+<span class="sourceLineNo">164</span> // resume the reportRegionStateTransition to finish the CloseRegionProcedure<a name="line.164"></a>
+<span class="sourceLineNo">165</span> RESUME_REPORT_STATE.countDown();<a name="line.165"></a>
+<span class="sourceLineNo">166</span> // wait until we schedule the OpenRegionProcedure<a name="line.166"></a>
+<span class="sourceLineNo">167</span> UTIL.waitFor(10000,<a name="line.167"></a>
+<span class="sourceLineNo">168</span> () -> proc.getCurrentStateId() == REGION_STATE_TRANSITION_CONFIRM_OPENED_VALUE);<a name="line.168"></a>
+<span class="sourceLineNo">169</span> // the region should be in OPENING state<a name="line.169"></a>
+<span class="sourceLineNo">170</span> assertEquals(RegionState.State.OPENING, rsn.getState());<a name="line.170"></a>
+<span class="sourceLineNo">171</span> // resume the region server report<a name="line.171"></a>
+<span class="sourceLineNo">172</span> RESUME_RS_REPORT.countDown();<a name="line.172"></a>
+<span class="sourceLineNo">173</span> // wait until it finishes, it will find that the region is opened on the rs<a name="line.173"></a>
+<span class="sourceLineNo">174</span> FINISH_RS_REPORT.await();<a name="line.174"></a>
+<span class="sourceLineNo">175</span> // let the OpenRegionProcedure go<a name="line.175"></a>
+<span class="sourceLineNo">176</span> procExecLock.releaseLockEntry(lockEntry);<a name="line.176"></a>
+<span class="sourceLineNo">177</span> // wait until the TRSP is done<a name="line.177"></a>
+<span class="sourceLineNo">178</span> future.get();<a name="line.178"></a>
+<span class="sourceLineNo">179</span><a name="line.179"></a>
+<span class="sourceLineNo">180</span> // confirm that the region can still be write, i.e, the regionServerReport method should not<a name="line.180"></a>
+<span class="sourceLineNo">181</span> // change the region state to OPEN<a name="line.181"></a>
+<span class="sourceLineNo">182</span> try (Table table = UTIL.getConnection().getTableBuilder(NAME, null).setWriteRpcTimeout(1000)<a name="line.182"></a>
+<span class="sourceLineNo">183</span> .setOperationTimeout(2000).build()) {<a name="line.183"></a>
+<span class="sourceLineNo">184</span> table.put(<a name="line.184"></a>
+<span class="sourceLineNo">185</span> new Put(Bytes.toBytes("key")).addColumn(CF, Bytes.toBytes("cq"), Bytes.toBytes("val")));<a name="line.185"></a>
+<span class="sourceLineNo">186</span> }<a name="line.186"></a>
+<span class="sourceLineNo">187</span> }<a name="line.187"></a>
+<span class="sourceLineNo">188</span>}<a name="line.188"></a>
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+</pre>
+</div>
+</body>
+</html>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b9b09fec/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestEnableTableProcedure.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestEnableTableProcedure.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestEnableTableProcedure.html
index 542f9de..ae16c06 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestEnableTableProcedure.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestEnableTableProcedure.html
@@ -36,121 +36,112 @@
<span class="sourceLineNo">028</span>import org.apache.hadoop.hbase.testclassification.MasterTests;<a name="line.28"></a>
<span class="sourceLineNo">029</span>import org.apache.hadoop.hbase.testclassification.MediumTests;<a name="line.29"></a>
<span class="sourceLineNo">030</span>import org.apache.hadoop.hbase.util.Bytes;<a name="line.30"></a>
-<span class="sourceLineNo">031</span>import org.junit.Assert;<a name="line.31"></a>
-<span class="sourceLineNo">032</span>import org.junit.ClassRule;<a name="line.32"></a>
-<span class="sourceLineNo">033</span>import org.junit.Rule;<a name="line.33"></a>
-<span class="sourceLineNo">034</span>import org.junit.Test;<a name="line.34"></a>
-<span class="sourceLineNo">035</span>import org.junit.experimental.categories.Category;<a name="line.35"></a>
-<span class="sourceLineNo">036</span>import org.junit.rules.TestName;<a name="line.36"></a>
-<span class="sourceLineNo">037</span>import org.slf4j.Logger;<a name="line.37"></a>
-<span class="sourceLineNo">038</span>import org.slf4j.LoggerFactory;<a name="line.38"></a>
-<span class="sourceLineNo">039</span><a name="line.39"></a>
-<span class="sourceLineNo">040</span>@Category({MasterTests.class, MediumTests.class})<a name="line.40"></a>
-<span class="sourceLineNo">041</span>public class TestEnableTableProcedure extends TestTableDDLProcedureBase {<a name="line.41"></a>
-<span class="sourceLineNo">042</span><a name="line.42"></a>
-<span class="sourceLineNo">043</span> @ClassRule<a name="line.43"></a>
-<span class="sourceLineNo">044</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.44"></a>
-<span class="sourceLineNo">045</span> HBaseClassTestRule.forClass(TestEnableTableProcedure.class);<a name="line.45"></a>
-<span class="sourceLineNo">046</span><a name="line.46"></a>
-<span class="sourceLineNo">047</span> private static final Logger LOG = LoggerFactory.getLogger(TestEnableTableProcedure.class);<a name="line.47"></a>
-<span class="sourceLineNo">048</span> @Rule public TestName name = new TestName();<a name="line.48"></a>
-<span class="sourceLineNo">049</span><a name="line.49"></a>
-<span class="sourceLineNo">050</span> @Test<a name="line.50"></a>
-<span class="sourceLineNo">051</span> public void testEnableTable() throws Exception {<a name="line.51"></a>
-<span class="sourceLineNo">052</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.52"></a>
-<span class="sourceLineNo">053</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.53"></a>
-<span class="sourceLineNo">054</span><a name="line.54"></a>
-<span class="sourceLineNo">055</span> MasterProcedureTestingUtility.createTable(procExec, tableName, null, "f1", "f2");<a name="line.55"></a>
-<span class="sourceLineNo">056</span> UTIL.getAdmin().disableTable(tableName);<a name="line.56"></a>
-<span class="sourceLineNo">057</span><a name="line.57"></a>
-<span class="sourceLineNo">058</span> // Enable the table<a name="line.58"></a>
-<span class="sourceLineNo">059</span> long procId = procExec.submitProcedure(<a name="line.59"></a>
-<span class="sourceLineNo">060</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false));<a name="line.60"></a>
-<span class="sourceLineNo">061</span> // Wait the completion<a name="line.61"></a>
-<span class="sourceLineNo">062</span> ProcedureTestingUtility.waitProcedure(procExec, procId);<a name="line.62"></a>
-<span class="sourceLineNo">063</span> ProcedureTestingUtility.assertProcNotFailed(procExec, procId);<a name="line.63"></a>
-<span class="sourceLineNo">064</span> MasterProcedureTestingUtility.validateTableIsEnabled(getMaster(), tableName);<a name="line.64"></a>
-<span class="sourceLineNo">065</span> }<a name="line.65"></a>
-<span class="sourceLineNo">066</span><a name="line.66"></a>
-<span class="sourceLineNo">067</span> @Test(expected=TableNotDisabledException.class)<a name="line.67"></a>
-<span class="sourceLineNo">068</span> public void testEnableNonDisabledTable() throws Exception {<a name="line.68"></a>
-<span class="sourceLineNo">069</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.69"></a>
-<span class="sourceLineNo">070</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.70"></a>
-<span class="sourceLineNo">071</span><a name="line.71"></a>
-<span class="sourceLineNo">072</span> MasterProcedureTestingUtility.createTable(procExec, tableName, null, "f1", "f2");<a name="line.72"></a>
-<span class="sourceLineNo">073</span><a name="line.73"></a>
-<span class="sourceLineNo">074</span> // Enable the table - expect failure<a name="line.74"></a>
-<span class="sourceLineNo">075</span> long procId1 = procExec.submitProcedure(<a name="line.75"></a>
-<span class="sourceLineNo">076</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false));<a name="line.76"></a>
-<span class="sourceLineNo">077</span> ProcedureTestingUtility.waitProcedure(procExec, procId1);<a name="line.77"></a>
-<span class="sourceLineNo">078</span><a name="line.78"></a>
-<span class="sourceLineNo">079</span> Procedure<?> result = procExec.getResult(procId1);<a name="line.79"></a>
-<span class="sourceLineNo">080</span> assertTrue(result.isFailed());<a name="line.80"></a>
-<span class="sourceLineNo">081</span> LOG.debug("Enable failed with exception: " + result.getException());<a name="line.81"></a>
-<span class="sourceLineNo">082</span> assertTrue(<a name="line.82"></a>
-<span class="sourceLineNo">083</span> ProcedureTestingUtility.getExceptionCause(result) instanceof TableNotDisabledException);<a name="line.83"></a>
-<span class="sourceLineNo">084</span><a name="line.84"></a>
-<span class="sourceLineNo">085</span> // Enable the table with skipping table state check flag (simulate recovery scenario)<a name="line.85"></a>
-<span class="sourceLineNo">086</span> long procId2 = procExec.submitProcedure(<a name="line.86"></a>
-<span class="sourceLineNo">087</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, true));<a name="line.87"></a>
-<span class="sourceLineNo">088</span> // Wait the completion<a name="line.88"></a>
-<span class="sourceLineNo">089</span> ProcedureTestingUtility.waitProcedure(procExec, procId2);<a name="line.89"></a>
-<span class="sourceLineNo">090</span> ProcedureTestingUtility.assertProcNotFailed(procExec, procId2);<a name="line.90"></a>
-<span class="sourceLineNo">091</span><a name="line.91"></a>
-<span class="sourceLineNo">092</span> // Enable the table - expect failure from ProcedurePrepareLatch<a name="line.92"></a>
-<span class="sourceLineNo">093</span> final ProcedurePrepareLatch prepareLatch = new ProcedurePrepareLatch.CompatibilityLatch();<a name="line.93"></a>
-<span class="sourceLineNo">094</span> procExec.submitProcedure(<a name="line.94"></a>
-<span class="sourceLineNo">095</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false, prepareLatch));<a name="line.95"></a>
-<span class="sourceLineNo">096</span> prepareLatch.await();<a name="line.96"></a>
-<span class="sourceLineNo">097</span> Assert.fail("Enable should throw exception through latch.");<a name="line.97"></a>
-<span class="sourceLineNo">098</span> }<a name="line.98"></a>
-<span class="sourceLineNo">099</span><a name="line.99"></a>
-<span class="sourceLineNo">100</span> @Test<a name="line.100"></a>
-<span class="sourceLineNo">101</span> public void testRecoveryAndDoubleExecution() throws Exception {<a name="line.101"></a>
-<span class="sourceLineNo">102</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.102"></a>
-<span class="sourceLineNo">103</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.103"></a>
-<span class="sourceLineNo">104</span><a name="line.104"></a>
-<span class="sourceLineNo">105</span> final byte[][] splitKeys = new byte[][] {<a name="line.105"></a>
-<span class="sourceLineNo">106</span> Bytes.toBytes("a"), Bytes.toBytes("b"), Bytes.toBytes("c")<a name="line.106"></a>
-<span class="sourceLineNo">107</span> };<a name="line.107"></a>
-<span class="sourceLineNo">108</span> MasterProcedureTestingUtility.createTable(procExec, tableName, splitKeys, "f1", "f2");<a name="line.108"></a>
-<span class="sourceLineNo">109</span> UTIL.getAdmin().disableTable(tableName);<a name="line.109"></a>
-<span class="sourceLineNo">110</span> ProcedureTestingUtility.waitNoProcedureRunning(procExec);<a name="line.110"></a>
-<span class="sourceLineNo">111</span> ProcedureTestingUtility.setKillIfHasParent(procExec, false);<a name="line.111"></a>
-<span class="sourceLineNo">112</span> ProcedureTestingUtility.setKillAndToggleBeforeStoreUpdate(procExec, true);<a name="line.112"></a>
-<span class="sourceLineNo">113</span><a name="line.113"></a>
-<span class="sourceLineNo">114</span> // Start the Enable procedure && kill the executor<a name="line.114"></a>
-<span class="sourceLineNo">115</span> long procId = procExec.submitProcedure(<a name="line.115"></a>
-<span class="sourceLineNo">116</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false));<a name="line.116"></a>
-<span class="sourceLineNo">117</span><a name="line.117"></a>
-<span class="sourceLineNo">118</span> // Restart the executor and execute the step twice<a name="line.118"></a>
-<span class="sourceLineNo">119</span> MasterProcedureTestingUtility.testRecoveryAndDoubleExecution(procExec, procId);<a name="line.119"></a>
+<span class="sourceLineNo">031</span>import org.junit.ClassRule;<a name="line.31"></a>
+<span class="sourceLineNo">032</span>import org.junit.Rule;<a name="line.32"></a>
+<span class="sourceLineNo">033</span>import org.junit.Test;<a name="line.33"></a>
+<span class="sourceLineNo">034</span>import org.junit.experimental.categories.Category;<a name="line.34"></a>
+<span class="sourceLineNo">035</span>import org.junit.rules.TestName;<a name="line.35"></a>
+<span class="sourceLineNo">036</span>import org.slf4j.Logger;<a name="line.36"></a>
+<span class="sourceLineNo">037</span>import org.slf4j.LoggerFactory;<a name="line.37"></a>
+<span class="sourceLineNo">038</span><a name="line.38"></a>
+<span class="sourceLineNo">039</span>@Category({ MasterTests.class, MediumTests.class })<a name="line.39"></a>
+<span class="sourceLineNo">040</span>public class TestEnableTableProcedure extends TestTableDDLProcedureBase {<a name="line.40"></a>
+<span class="sourceLineNo">041</span><a name="line.41"></a>
+<span class="sourceLineNo">042</span> @ClassRule<a name="line.42"></a>
+<span class="sourceLineNo">043</span> public static final HBaseClassTestRule CLASS_RULE =<a name="line.43"></a>
+<span class="sourceLineNo">044</span> HBaseClassTestRule.forClass(TestEnableTableProcedure.class);<a name="line.44"></a>
+<span class="sourceLineNo">045</span><a name="line.45"></a>
+<span class="sourceLineNo">046</span> private static final Logger LOG = LoggerFactory.getLogger(TestEnableTableProcedure.class);<a name="line.46"></a>
+<span class="sourceLineNo">047</span><a name="line.47"></a>
+<span class="sourceLineNo">048</span> @Rule<a name="line.48"></a>
+<span class="sourceLineNo">049</span> public TestName name = new TestName();<a name="line.49"></a>
+<span class="sourceLineNo">050</span><a name="line.50"></a>
+<span class="sourceLineNo">051</span> @Test<a name="line.51"></a>
+<span class="sourceLineNo">052</span> public void testEnableTable() throws Exception {<a name="line.52"></a>
+<span class="sourceLineNo">053</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.53"></a>
+<span class="sourceLineNo">054</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.54"></a>
+<span class="sourceLineNo">055</span><a name="line.55"></a>
+<span class="sourceLineNo">056</span> MasterProcedureTestingUtility.createTable(procExec, tableName, null, "f1", "f2");<a name="line.56"></a>
+<span class="sourceLineNo">057</span> UTIL.getAdmin().disableTable(tableName);<a name="line.57"></a>
+<span class="sourceLineNo">058</span><a name="line.58"></a>
+<span class="sourceLineNo">059</span> // Enable the table<a name="line.59"></a>
+<span class="sourceLineNo">060</span> long procId =<a name="line.60"></a>
+<span class="sourceLineNo">061</span> procExec.submitProcedure(new EnableTableProcedure(procExec.getEnvironment(), tableName));<a name="line.61"></a>
+<span class="sourceLineNo">062</span> // Wait the completion<a name="line.62"></a>
+<span class="sourceLineNo">063</span> ProcedureTestingUtility.waitProcedure(procExec, procId);<a name="line.63"></a>
+<span class="sourceLineNo">064</span> ProcedureTestingUtility.assertProcNotFailed(procExec, procId);<a name="line.64"></a>
+<span class="sourceLineNo">065</span> MasterProcedureTestingUtility.validateTableIsEnabled(getMaster(), tableName);<a name="line.65"></a>
+<span class="sourceLineNo">066</span> }<a name="line.66"></a>
+<span class="sourceLineNo">067</span><a name="line.67"></a>
+<span class="sourceLineNo">068</span> @Test(expected = TableNotDisabledException.class)<a name="line.68"></a>
+<span class="sourceLineNo">069</span> public void testEnableNonDisabledTable() throws Exception {<a name="line.69"></a>
+<span class="sourceLineNo">070</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.70"></a>
+<span class="sourceLineNo">071</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.71"></a>
+<span class="sourceLineNo">072</span><a name="line.72"></a>
+<span class="sourceLineNo">073</span> MasterProcedureTestingUtility.createTable(procExec, tableName, null, "f1", "f2");<a name="line.73"></a>
+<span class="sourceLineNo">074</span><a name="line.74"></a>
+<span class="sourceLineNo">075</span> // Enable the table - expect failure<a name="line.75"></a>
+<span class="sourceLineNo">076</span> long procId1 =<a name="line.76"></a>
+<span class="sourceLineNo">077</span> procExec.submitProcedure(new EnableTableProcedure(procExec.getEnvironment(), tableName));<a name="line.77"></a>
+<span class="sourceLineNo">078</span> ProcedureTestingUtility.waitProcedure(procExec, procId1);<a name="line.78"></a>
+<span class="sourceLineNo">079</span><a name="line.79"></a>
+<span class="sourceLineNo">080</span> Procedure<?> result = procExec.getResult(procId1);<a name="line.80"></a>
+<span class="sourceLineNo">081</span> assertTrue(result.isFailed());<a name="line.81"></a>
+<span class="sourceLineNo">082</span> LOG.debug("Enable failed with exception: " + result.getException());<a name="line.82"></a>
+<span class="sourceLineNo">083</span> assertTrue(<a name="line.83"></a>
+<span class="sourceLineNo">084</span> ProcedureTestingUtility.getExceptionCause(result) instanceof TableNotDisabledException);<a name="line.84"></a>
+<span class="sourceLineNo">085</span><a name="line.85"></a>
+<span class="sourceLineNo">086</span> // Enable the table - expect failure from ProcedurePrepareLatch<a name="line.86"></a>
+<span class="sourceLineNo">087</span> final ProcedurePrepareLatch prepareLatch = new ProcedurePrepareLatch.CompatibilityLatch();<a name="line.87"></a>
+<span class="sourceLineNo">088</span> procExec.submitProcedure(<a name="line.88"></a>
+<span class="sourceLineNo">089</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, prepareLatch));<a name="line.89"></a>
+<span class="sourceLineNo">090</span> prepareLatch.await();<a name="line.90"></a>
+<span class="sourceLineNo">091</span> }<a name="line.91"></a>
+<span class="sourceLineNo">092</span><a name="line.92"></a>
+<span class="sourceLineNo">093</span> @Test<a name="line.93"></a>
+<span class="sourceLineNo">094</span> public void testRecoveryAndDoubleExecution() throws Exception {<a name="line.94"></a>
+<span class="sourceLineNo">095</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.95"></a>
+<span class="sourceLineNo">096</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.96"></a>
+<span class="sourceLineNo">097</span><a name="line.97"></a>
+<span class="sourceLineNo">098</span> final byte[][] splitKeys =<a name="line.98"></a>
+<span class="sourceLineNo">099</span> new byte[][] { Bytes.toBytes("a"), Bytes.toBytes("b"), Bytes.toBytes("c") };<a name="line.99"></a>
+<span class="sourceLineNo">100</span> MasterProcedureTestingUtility.createTable(procExec, tableName, splitKeys, "f1", "f2");<a name="line.100"></a>
+<span class="sourceLineNo">101</span> UTIL.getAdmin().disableTable(tableName);<a name="line.101"></a>
+<span class="sourceLineNo">102</span> ProcedureTestingUtility.waitNoProcedureRunning(procExec);<a name="line.102"></a>
+<span class="sourceLineNo">103</span> ProcedureTestingUtility.setKillIfHasParent(procExec, false);<a name="line.103"></a>
+<span class="sourceLineNo">104</span> ProcedureTestingUtility.setKillAndToggleBeforeStoreUpdate(procExec, true);<a name="line.104"></a>
+<span class="sourceLineNo">105</span><a name="line.105"></a>
+<span class="sourceLineNo">106</span> // Start the Enable procedure && kill the executor<a name="line.106"></a>
+<span class="sourceLineNo">107</span> long procId =<a name="line.107"></a>
+<span class="sourceLineNo">108</span> procExec.submitProcedure(new EnableTableProcedure(procExec.getEnvironment(), tableName));<a name="line.108"></a>
+<span class="sourceLineNo">109</span><a name="line.109"></a>
+<span class="sourceLineNo">110</span> // Restart the executor and execute the step twice<a name="line.110"></a>
+<span class="sourceLineNo">111</span> MasterProcedureTestingUtility.testRecoveryAndDoubleExecution(procExec, procId);<a name="line.111"></a>
+<span class="sourceLineNo">112</span><a name="line.112"></a>
+<span class="sourceLineNo">113</span> MasterProcedureTestingUtility.validateTableIsEnabled(getMaster(), tableName);<a name="line.113"></a>
+<span class="sourceLineNo">114</span> }<a name="line.114"></a>
+<span class="sourceLineNo">115</span><a name="line.115"></a>
+<span class="sourceLineNo">116</span> @Test<a name="line.116"></a>
+<span class="sourceLineNo">117</span> public void testRollbackAndDoubleExecution() throws Exception {<a name="line.117"></a>
+<span class="sourceLineNo">118</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.118"></a>
+<span class="sourceLineNo">119</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.119"></a>
<span class="sourceLineNo">120</span><a name="line.120"></a>
-<span class="sourceLineNo">121</span> MasterProcedureTestingUtility.validateTableIsEnabled(getMaster(), tableName);<a name="line.121"></a>
-<span class="sourceLineNo">122</span> }<a name="line.122"></a>
-<span class="sourceLineNo">123</span><a name="line.123"></a>
-<span class="sourceLineNo">124</span> @Test<a name="line.124"></a>
-<span class="sourceLineNo">125</span> public void testRollbackAndDoubleExecution() throws Exception {<a name="line.125"></a>
-<span class="sourceLineNo">126</span> final TableName tableName = TableName.valueOf(name.getMethodName());<a name="line.126"></a>
-<span class="sourceLineNo">127</span> final ProcedureExecutor<MasterProcedureEnv> procExec = getMasterProcedureExecutor();<a name="line.127"></a>
-<span class="sourceLineNo">128</span><a name="line.128"></a>
-<span class="sourceLineNo">129</span> final byte[][] splitKeys = new byte[][] {<a name="line.129"></a>
-<span class="sourceLineNo">130</span> Bytes.toBytes("a"), Bytes.toBytes("b"), Bytes.toBytes("c")<a name="line.130"></a>
-<span class="sourceLineNo">131</span> };<a name="line.131"></a>
-<span class="sourceLineNo">132</span> MasterProcedureTestingUtility.createTable(procExec, tableName, splitKeys, "f1", "f2");<a name="line.132"></a>
-<span class="sourceLineNo">133</span> UTIL.getAdmin().disableTable(tableName);<a name="line.133"></a>
-<span class="sourceLineNo">134</span> ProcedureTestingUtility.waitNoProcedureRunning(procExec);<a name="line.134"></a>
-<span class="sourceLineNo">135</span> ProcedureTestingUtility.setKillAndToggleBeforeStoreUpdate(procExec, true);<a name="line.135"></a>
-<span class="sourceLineNo">136</span><a name="line.136"></a>
-<span class="sourceLineNo">137</span> // Start the Enable procedure && kill the executor<a name="line.137"></a>
-<span class="sourceLineNo">138</span> long procId = procExec.submitProcedure(<a name="line.138"></a>
-<span class="sourceLineNo">139</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false));<a name="line.139"></a>
-<span class="sourceLineNo">140</span><a name="line.140"></a>
-<span class="sourceLineNo">141</span> int lastStep = 3; // fail before ENABLE_TABLE_SET_ENABLING_TABLE_STATE<a name="line.141"></a>
-<span class="sourceLineNo">142</span> MasterProcedureTestingUtility.testRollbackAndDoubleExecution(procExec, procId, lastStep);<a name="line.142"></a>
-<span class="sourceLineNo">143</span> MasterProcedureTestingUtility.validateTableIsDisabled(getMaster(), tableName);<a name="line.143"></a>
-<span class="sourceLineNo">144</span> }<a name="line.144"></a>
-<span class="sourceLineNo">145</span>}<a name="line.145"></a>
+<span class="sourceLineNo">121</span> final byte[][] splitKeys =<a name="line.121"></a>
+<span class="sourceLineNo">122</span> new byte[][] { Bytes.toBytes("a"), Bytes.toBytes("b"), Bytes.toBytes("c") };<a name="line.122"></a>
+<span class="sourceLineNo">123</span> MasterProcedureTestingUtility.createTable(procExec, tableName, splitKeys, "f1", "f2");<a name="line.123"></a>
+<span class="sourceLineNo">124</span> UTIL.getAdmin().disableTable(tableName);<a name="line.124"></a>
+<span class="sourceLineNo">125</span> ProcedureTestingUtility.waitNoProcedureRunning(procExec);<a name="line.125"></a>
+<span class="sourceLineNo">126</span> ProcedureTestingUtility.setKillAndToggleBeforeStoreUpdate(procExec, true);<a name="line.126"></a>
+<span class="sourceLineNo">127</span><a name="line.127"></a>
+<span class="sourceLineNo">128</span> // Start the Enable procedure && kill the executor<a name="line.128"></a>
+<span class="sourceLineNo">129</span> long procId =<a name="line.129"></a>
+<span class="sourceLineNo">130</span> procExec.submitProcedure(new EnableTableProcedure(procExec.getEnvironment(), tableName));<a name="line.130"></a>
+<span class="sourceLineNo">131</span><a name="line.131"></a>
+<span class="sourceLineNo">132</span> int lastStep = 3; // fail before ENABLE_TABLE_SET_ENABLING_TABLE_STATE<a name="line.132"></a>
+<span class="sourceLineNo">133</span> MasterProcedureTestingUtility.testRollbackAndDoubleExecution(procExec, procId, lastStep);<a name="line.133"></a>
+<span class="sourceLineNo">134</span> MasterProcedureTestingUtility.validateTableIsDisabled(getMaster(), tableName);<a name="line.134"></a>
+<span class="sourceLineNo">135</span> }<a name="line.135"></a>
+<span class="sourceLineNo">136</span>}<a name="line.136"></a>
http://git-wip-us.apache.org/repos/asf/hbase-site/blob/b9b09fec/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestMasterFailoverWithProcedures.html
----------------------------------------------------------------------
diff --git a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestMasterFailoverWithProcedures.html b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestMasterFailoverWithProcedures.html
index 2125f6d..6763149 100644
--- a/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestMasterFailoverWithProcedures.html
+++ b/testdevapidocs/src-html/org/apache/hadoop/hbase/master/procedure/TestMasterFailoverWithProcedures.html
@@ -297,7 +297,7 @@
<span class="sourceLineNo">289</span><a name="line.289"></a>
<span class="sourceLineNo">290</span> // Start the Delete procedure && kill the executor<a name="line.290"></a>
<span class="sourceLineNo">291</span> long procId = procExec.submitProcedure(<a name="line.291"></a>
-<span class="sourceLineNo">292</span> new EnableTableProcedure(procExec.getEnvironment(), tableName, false));<a name="line.292"></a>
+<span class="sourceLineNo">292</span> new EnableTableProcedure(procExec.getEnvironment(), tableName));<a name="line.292"></a>
<span class="sourceLineNo">293</span> testRecoveryAndDoubleExecution(UTIL, procId, step);<a name="line.293"></a>
<span class="sourceLineNo">294</span><a name="line.294"></a>
<span class="sourceLineNo">295</span> MasterProcedureTestingUtility.validateTableIsEnabled(<a name="line.295"></a>