[jira] [Comment Edited] (OAK-6407) Refactor oak.spi.query into a separate module/bundle

["angela (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094644#comment-16094644 ] 

angela edited comment on OAK-6407 at 7/20/17 3:15 PM:
------------------------------------------------------

regarding the dependencies from other modules you are wondering about:

* _oak-jcr_: 2 classes make use of query-spi but i didn't check if they are properly located in the _oak-jcr_ module
** {{org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager}} : uses various classes from the query-spi 
** {{org.apache.jackrabbit.oak.jcr.Jcr}} utility: uses various classes from the query-spi 

* _oak-store-composite_
** {{CrossMountReferenceValidator}}: uses {{org.apache.jackrabbit.oak.spi.query.Filter}}; if you feel that this is a mistake, we should probably raise an issue with the multiplexing to make sure we get that addressed.

* _oak-authorization-cug_
** i have to recheck that one... looking at the code it seems that query-spi is only used in tests.... but i vaguely remember having a failing build with the test-scope only dependency.

* _oak-auth-external_
** {{ExternalIdentityRepositoryInitializer}} uses {{RootFactory.createSystemRoot}}, which has a dependency to {{QueryIndexProvider}} (even if the param passed in this case is {{null}}).


was (Author: anchela):
regarding the dependencies from other modules you are wondering about:

* _oak-jcr_: 2 classes make use of query-spi but i didn't check if they are properly located in the _oak-jcr_ module
** {{org.apache.jackrabbit.oak.jcr.osgi.RepositoryManager}} : uses various classes from the query-spi 
** {{org.apache.jackrabbit.oak.jcr.Jcr}} utility: uses various classes from the query-spi 

* _oak-store-composite_
** {{CrossMountReferenceValidator}}: uses {{org.apache.jackrabbit.oak.spi.query.Filter}}; if you feel that this is a mistake, we should probably raise an issue with the multiplexing to make sure we get that addressed.

* _oak-authorization-cug_
** i have to recheck that one... looking at the code it seems that query-spi is only used in tests.... but i vaguely remember having a failing build with the test-scope only dependency.

* _oak-auth-external_
** same here. will recheck if it really can't be limited to test-scope.

>  Refactor oak.spi.query into a separate module/bundle 
> ------------------------------------------------------
>
>                 Key: OAK-6407
>                 URL: https://issues.apache.org/jira/browse/OAK-6407
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, indexing, query
>            Reporter: angela
>            Assignee: angela
>              Labels: modularization
>             Fix For: 1.8
>
>         Attachments: OAK-6407.patch
>
>
> now that OAK-6304 and OAK-6355 have been resolved, i would like to suggest that we move the _o.a.j.oak.spi.query_ code base into a separate module/bundle in order to prevent the introduction of bogus cycles and odd package exports in the future.
> [~tmueller], patch will follow asap.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)