You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by Apache subversion Wiki <co...@subversion.apache.org> on 2012/03/29 18:59:28 UTC

[Subversion Wiki] Update of "NonNormalizingUnicodeCompositionAwareness" by DanielShahaf

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Subversion Wiki" for change notification.

The "NonNormalizingUnicodeCompositionAwareness" page has been changed by DanielShahaf:
http://wiki.apache.org/subversion/NonNormalizingUnicodeCompositionAwareness?action=diff&rev1=2&rev2=3

Comment:
review of r2

  
  A new column, local_relpath_fs, is added that contains the path as stored in the file system. This column will be used on all systems to interact with the file system. Currently, the content of columns local_relpath and  local_relpath_fs will be identical on all file systems except HFS+.
  
+ {{{#!wiki comment
+ can we use a term (eg, "disk path") that avoids confusion with fs == libsvn_fs?
+ }}}
  
  === Normalized uniqueness ===
  
@@ -134, +137 @@

  
  === Pristine Storage ===
  
- Since svn 1.7, pristines are stored based on their SHA1 checksum rather than name. There should be very little impact.
+ Since svn 1.7, pristines are stored based on the SHA1 checksum of their contents, independently of their name. There should be very little impact.
- 
- TODO: Please confirm.
- 
  
  === Command Line ===
  
@@ -154, +154 @@

  
  All commands that access files in the Working Copy must do so by getting the path from the column local_relpath/local_relpath_fs. 
  
- TODO: Investigate which subcommands currently use local_relpath for other purposes than accessing the file. With alternative 1 (abover), it will NOT be acceptable to use local_relpath for comparison/substring operations with other paths, e.g. repos_path.
+ TODO: Investigate which subcommands currently use local_relpath for other purposes than accessing the file. With alternative 1 (above), it will NOT be acceptable to use local_relpath for comparison/substring operations with other paths, e.g. repos_path.
  
  
  ==== Checkout/Update ====
@@ -173, +173 @@

  
  TODO: Clarify if status performs string comparisons between local_relpath and some other path.
  
+ TODO: how does status show a file whose name changed to a value that canonicalizes to the same value as the original name? (is that possible?)
  
- ==== Add ====
+ ==== Add and mkdir ====
  
  Since this approach does not dictate a Normalized repository storage, the add subcommand should not perform any normalization.
  
@@ -205, +206 @@

  
  On Mac OS X it will not be possible to define externals that cause a "normalized-name collision".
  
+ TODO: match where? in the URL? in the target dist path? both?
  
  == Use Cases ==
  
@@ -224, +226 @@

  
   * Working Copies will be upgraded in the same way as any other wc-ng upgrade with SQL schema changes. Working Copies on Mac OS X that are broken before upgrade might require a fresh check out.
  
+ TODO: does upgrade have just to transform the wc.db metadata? does it look at the disk (say, to look for preexisting collisions)?
+