You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/21 02:42:14 UTC
[GitHub] [incubator-kyuubi] zinking opened a new pull request #2193: [KYUUBI #1915] invoke tpcds from sql
zinking opened a new pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
invoke tpcds from sql
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
UT cases added
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d065a7e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e390f34c83b3023afc73cb79a498514303a8fd6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e390f34) will **decrease** coverage by `0.16%`.
> The diff coverage is `42.95%`.
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.22% 61.05% -0.17%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15739 15881 +142
Branches 2010 2044 +34
============================================
+ Hits 9636 9696 +60
- Misses 5286 5350 +64
- Partials 817 835 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e390f34...d065a7e](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (686a3df) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b02fb584d068cc41bb9b9dd8d5554e948953223d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b02fb58) will **decrease** coverage by `0.42%`.
> The diff coverage is `42.95%`.
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.49% 61.07% -0.43%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15718 15881 +163
Branches 2008 2044 +36
============================================
+ Hits 9666 9699 +33
- Misses 5233 5347 +114
- Partials 819 835 +16
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [.../apache/spark/kyuubi/SparkConsoleProgressBar.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrQ29uc29sZVByb2dyZXNzQmFyLnNjYWxh) | `0.00% <0.00%> (-94.00%)` | :arrow_down: |
| [...org/apache/spark/kyuubi/SQLOperationListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NRTE9wZXJhdGlvbkxpc3RlbmVyLnNjYWxh) | `86.48% <0.00%> (-7.64%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b02fb58...686a3df](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#discussion_r832012546
##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/zorder/ZorderSqlExtensions.g4
##########
@@ -76,6 +82,11 @@ comparisonOperator
: EQ | NEQ | NEQJ | LT | LTE | GT | GTE | NSEQ
;
+expression
Review comment:
I'm a little confused with this name. I see it comes from iceberg, but why not name it as `argument` ? The semantics of expression in Spark is different with this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1075980778
> The existed antlr4 file is for Z-Order, it should not add other procedures.
>
> I think we can add a new antlr4 file and something else into tpcds module, so we don't need depend on Spark extension module.
it is a bit weird to add new semantics into something called z-order. so the problem is are we expecting adding new syntaxes ? or we are adopting a syntax per file approach (which a lot of code duplication would occur).
that would work, but code is expected to duplicate in that case. **and** originally my intention is that this procedure could be reused in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking commented on a change in pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking commented on a change in pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#discussion_r832900917
##########
File path: dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/zorder/ZorderSqlExtensions.g4
##########
@@ -76,6 +82,11 @@ comparisonOperator
: EQ | NEQ | NEQJ | LT | LTE | GT | GTE | NSEQ
;
+expression
Review comment:
I am okay calling it argument. and agree it's a better name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1076093270
> > originally my intention is that this procedure could be reused in the future
>
> I see your concern, but it does not work if we add procedure at spark extension module. Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`. It should be added into Kyuubi Server module, and its scope is for all engines(Spark/Flink/Trino).
>
> So at present, I think it makes sense to just add this inside tpcds module. What do you think ? @zinking
I guess that is the `underlying` design I would like to discuss.
calling tpcds functions is really merely exercising that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1074785246
> thank you @zinking for working on this. please do not push irrelevant change, e.g. `.idea`.
>
> also, can you enrich description about how it works ? e.g. the added node/expression, the compile process
updated, I'm seeing test brokerages from `master` which I don't know why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1078699710
If so, it's real a big feature. We should have enough discussion in some other places. e.g. the Kyuubi dev list, like the recent Flink checkpoint thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9910c1) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b02fb584d068cc41bb9b9dd8d5554e948953223d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b02fb58) will **decrease** coverage by `0.17%`.
> The diff coverage is `42.95%`.
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.49% 61.32% -0.18%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15718 15860 +142
Branches 2008 2042 +34
============================================
+ Hits 9666 9726 +60
- Misses 5233 5297 +64
- Partials 819 837 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b02fb58...b9910c1](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (686a3df) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e390f34c83b3023afc73cb79a498514303a8fd6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e390f34) will **decrease** coverage by `0.15%`.
> The diff coverage is `42.95%`.
> :exclamation: Current head 686a3df differs from pull request most recent head ab9ae38. Consider uploading reports for the commit ab9ae38 to get more accurate results
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.22% 61.07% -0.16%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15739 15881 +142
Branches 2010 2044 +34
============================================
+ Hits 9636 9699 +63
- Misses 5286 5347 +61
- Partials 817 835 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e390f34...ab9ae38](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (686a3df) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e390f34c83b3023afc73cb79a498514303a8fd6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e390f34) will **decrease** coverage by `0.15%`.
> The diff coverage is `42.95%`.
> :exclamation: Current head 686a3df differs from pull request most recent head d065a7e. Consider uploading reports for the commit d065a7e to get more accurate results
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.22% 61.07% -0.16%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15739 15881 +142
Branches 2010 2044 +34
============================================
+ Hits 9636 9699 +63
- Misses 5286 5347 +61
- Partials 817 835 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.85% <0.00%> (-2.39%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e390f34...d065a7e](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking removed a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking removed a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1074785246
> thank you @zinking for working on this. please do not push irrelevant change, e.g. `.idea`.
>
> also, can you enrich description about how it works ? e.g. the added node/expression, the compile process
updated, I'm seeing test brokerages from `master` which I don't know why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2442f12) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e390f34c83b3023afc73cb79a498514303a8fd6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e390f34) will **increase** coverage by `0.25%`.
> The diff coverage is `42.95%`.
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
+ Coverage 61.22% 61.47% +0.25%
- Complexity 69 96 +27
============================================
Files 329 337 +8
Lines 15739 16044 +305
Branches 2010 2051 +41
============================================
+ Hits 9636 9863 +227
- Misses 5286 5351 +65
- Partials 817 830 +13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...engine/trino/operation/TrinoOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL29wZXJhdGlvbi9Ucmlub09wZXJhdGlvbk1hbmFnZXIuc2NhbGE=) | `86.36% <0.00%> (-4.12%)` | :arrow_down: |
| [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `75.00% <0.00%> (-2.78%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e390f34...2442f12](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1077042702
> Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`
The procedure is a dedicated syntax, `CALL procedure_name(arg1, arg2 ...)`, `STOP ENGINE` is command style, the equality procedure style is something like `CALL stop_engine(engine_id: string)`
> I think it makes sense to just add this inside tpcds module
I would like to add it into `kyuubi-extension-spark-common`, along with Z-Order syntax, and rename `ZorderSqlExtensions.g4` to a more common name, e.g. `KyuubiExtensions.g4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1077042702
> Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`
The procedure is a dedicated syntax, `CALL procedure_name(arg1, arg2 ...)`, `CREATE ENGINE` is command style, the equality procedure style is something like `CALL stop_engine(engine_id: string)`
> I think it makes sense to just add this inside tpcds module
I would like to add it into `kyuubi-extension-spark-common`, along with Z-Order syntax, and rename `ZorderSqlExtensions.g4` to a more common name, e.g. `KyuubiExtensions.g4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1076051160
> originally my intention is that this procedure could be reused in the future
I see your concern, but it does not work if we add procedure at spark extension module. Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`. It should be added into Kyuubi Server module, and its scope is for all engines(Spark/Flink/Trino).
So at present, I think it makes sense to just add this inside tpcds module. What do you think ? @zinking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1077042702
> Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`
The procedure is a dedicated syntax, `CALL procedure_name(arg1, arg2 ...)`, `STOP ENGINE` is command style, the equality procedure style is something like `CALL stop_engine(engine_id: string)`
> I think it makes sense to just add this inside tpcds module
I would like to add it into `kyuubi-extension-spark-common`, along with Z-Order syntax, and rename `ZorderSqlExtensions.g4` to a more common name, e.g. `KyuubiExtensions.g4`. The reason is, procedure syntax itself is a common one, adopted by iceberg, trino, hudi, and has an opportunity to get into Spark(saw discussion previously in Iceberg mailing list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1073447775
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2193](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b9910c1) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/b02fb584d068cc41bb9b9dd8d5554e948953223d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b02fb58) will **decrease** coverage by `0.17%`.
> The diff coverage is `42.95%`.
> :exclamation: Current head b9910c1 differs from pull request most recent head 686a3df. Consider uploading reports for the commit 686a3df to get more accurate results
```diff
@@ Coverage Diff @@
## master #2193 +/- ##
============================================
- Coverage 61.49% 61.32% -0.18%
- Complexity 69 96 +27
============================================
Files 329 335 +6
Lines 15718 15860 +142
Branches 2008 2042 +34
============================================
+ Hits 9666 9726 +60
- Misses 5233 5297 +64
- Partials 819 837 +18
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/kyuubi/sql/call/procedure/Procedure.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../scala/org/apache/kyuubi/sql/call/Statements.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL1N0YXRlbWVudHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...pache/kyuubi/sql/call/KyuubiProcedureCatalog.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0t5dXViaVByb2NlZHVyZUNhdGFsb2cuc2NhbGE=) | `33.75% <33.75%> (ø)` | |
| [...ubi/sql/call/procedure/ProcedureParameterImpl.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlckltcGwuamF2YQ==) | `42.10% <42.10%> (ø)` | |
| [...scala/org/apache/kyuubi/sql/call/CallCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC9jYWxsL0NhbGxDb21tYW5kLnNjYWxh) | `50.00% <50.00%> (ø)` | |
| [...g/apache/kyuubi/sql/zorder/ResolveZorderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvUmVzb2x2ZVpvcmRlckJhc2Uuc2NhbGE=) | `64.44% <59.09%> (-5.13%)` | :arrow_down: |
| [...he/kyuubi/sql/zorder/ZorderSqlAstBuilderBase.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL3NxbC96b3JkZXIvWm9yZGVyU3FsQXN0QnVpbGRlckJhc2Uuc2NhbGE=) | `30.69% <76.92%> (+4.46%)` | :arrow_up: |
| [.../kyuubi/sql/call/procedure/ProcedureParameter.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGV2L2t5dXViaS1leHRlbnNpb24tc3BhcmstY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1Ymkvc3FsL2NhbGwvcHJvY2VkdXJlL1Byb2NlZHVyZVBhcmFtZXRlci5qYXZh) | `100.00% <100.00%> (ø)` | |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `65.06% <0.00%> (-4.82%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b02fb58...686a3df](https://codecov.io/gh/apache/incubator-kyuubi/pull/2193?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1074639124
thank you @zinking for working on this. please do not push irrelevant change, e.g. `.idea`.
also, can you enrich description about how it works ? e.g. the added node/expression, the compile process
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zinking commented on pull request #2193: [KYUUBI #1915] invoke tpcds from sql
Posted by GitBox <gi...@apache.org>.
zinking commented on pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1077283773
> > Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`
>
> The procedure is a dedicated syntax, `CALL procedure_name(arg1, arg2 ...)`, `STOP ENGINE` is command style, the equality procedure style is something like `CALL stop_engine(engine_id: string)`
>
> > I think it makes sense to just add this inside tpcds module
>
> I would like to add it into `kyuubi-extension-spark-common`, along with Z-Order syntax, and rename `ZorderSqlExtensions.g4` to a more common name, e.g. `KyuubiExtensions.g4`. The reason is, procedure syntax itself is a common one, adopted by iceberg, trino, hudi, and has an opportunity to get into Spark(saw discussion previously in Iceberg mailing list)
this matches my thought. but if it is only in spark-common, I guess @ulysses-you 's argument makes sense, since I don't see how trino, flink and other engines gets to execute that. am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org