You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/11 04:05:05 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request #5605: fix
prometheusMetrics export contains " bug
hangc0276 opened a new pull request #5605: fix prometheusMetrics export contains " bug
URL: https://github.com/apache/pulsar/pull/5605
when i use Oracle JDK 10.0.2，the broker metrics `jvm_info` will export as follow:
```
# TYPE jvm_info gauge
jvm_info{cluster="pulsar-cluster-zk",version="10.0.2+13",vendor=""Oracle Corporation"",runtime="Java(TM) SE Runtime Environment"} 1.0
```
and then prometheus will failed when parsing `""Oracle Corporation""`
The Reason is when using `io.prometheus:simpleclient:0.5.0` to collect jvm info, it returns jvm vendor with `"Oracle Corporation"`, and in the Pulsar source code, it adds `"` in both sides, so it comming with `vendor=""Oracle Corporation""`, and prometheus parse failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services