You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by GitBox <gi...@apache.org> on 2020/07/07 12:34:41 UTC

[GitHub] [sling-org-apache-sling-distribution-journal] amit-jain opened a new pull request #51: SLING-9569: Emit error code when error event received if available

amit-jain opened a new pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51


   - Emit metric counter for the error code received from error event if available


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-distribution-journal] tmaret commented on pull request #51: SLING-9569: Emit error code when error event received if available

Posted by GitBox <gi...@apache.org>.
tmaret commented on pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51#issuecomment-654912154


   Thanks @amit-jain , merged.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-distribution-journal] amit-jain commented on pull request #51: SLING-9569: Emit error code when error event received if available

Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51#issuecomment-654882214


   @tmaret 
   > Is the intend to allow filtering out error codes or to have metrics defined upon start (instead of lazily created upon handling specific error codes)
   The intent is to accomplish both. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-distribution-journal] amit-jain commented on pull request #51: SLING-9569: Emit error code when error event received if available

Posted by GitBox <gi...@apache.org>.
amit-jain commented on pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51#issuecomment-654825340


   Depends upon https://github.com/apache/sling-org-apache-sling-distribution-journal-messages/pull/3


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-distribution-journal] tmaret merged pull request #51: SLING-9569: Emit error code when error event received if available

Posted by GitBox <gi...@apache.org>.
tmaret merged pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-org-apache-sling-distribution-journal] amit-jain edited a comment on pull request #51: SLING-9569: Emit error code when error event received if available

Posted by GitBox <gi...@apache.org>.
amit-jain edited a comment on pull request #51:
URL: https://github.com/apache/sling-org-apache-sling-distribution-journal/pull/51#issuecomment-654882214


   @tmaret 
   > Is the intend to allow filtering out error codes or to have metrics defined upon start (instead of lazily created upon handling specific error codes)
   
   The intent is to accomplish both. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org