[GitHub] [incubator-shardingsphere] sunbufu commented on issue #3185: The configuration of RegistryCenter, ConfigCenter, LeafCenter should be split apart or not?

[GitBox <gi...@apache.org>]

sunbufu commented on issue #3185: The configuration of RegistryCenter, ConfigCenter,LeafCenter should be split apart or not?
URL: https://github.com/apache/incubator-shardingsphere/issues/3185#issuecomment-548364888
 
 
   Hi, we got some conclusions, after the discussion. 
   The new configuration in the plan is as follows.
   ```yml
   spring:
       shardingsphere:
           orchestration:
               name: ''
               overwrite: ''
               registry:
                   digest: ''
                   max-retries: ''
                   name: '#Orchestration instance name'
                   namespace: ''
                   operation-timeout-milliseconds: ''
                   props: ''
                   retry-interval-milliseconds: ''
                   server-lists: ''
                   time-to-live-seconds: ''
                   type: '#Example:zookeeper,nacos,apollo'
               config:
                   digest: ''
                   max-retries: ''
                   name: '#Orchestration instance name'
                   namespace: ''
                   operation-timeout-milliseconds: ''
                   overwrite: ''
                   props: ''
                   retry-interval-milliseconds: ''
                   server-lists: ''
                   time-to-live-seconds: ''
                   type: '#Example:zookeeper,nacos,apollo'
               leaf:
                   digest: ''
                   max-retries: ''
                   name: '#Orchestration instance name'
                   namespace: ''
                   operation-timeout-milliseconds: ''
                   props: ''
                   retry-interval-milliseconds: ''
                   server-lists: ''
                   time-to-live-seconds: ''
                   type: '#Example:zookeeper,nacos,apollo'
   ```
   The old configuration is as follows.
   ```yml
   spring:
       shardingsphere:
           orchestration:
               name: ''
               overwrite: ''
               registry:
                   digest: ''
                   max-retries: ''
                   namespace: ''
                   operation-timeout-milliseconds: ''
                   props: ''
                   retry-interval-milliseconds: ''
                   server-lists: ''
                   time-to-live-seconds: ''
                   type: ''
                   use-for: '#'
   ```
   
   We hope that the new configuration can be compatible with the old configuration, but we do not want the configuration to be redundant. There are some of difficulties we get, can you give me some advice ?
   
   1. For compatibility with old configuration, ConfigCenter and ConfigCenter must be optional. Can we use RegistryCenter to do the job of ConfigCenter or LeafCenter When user don't config ConfigCenter or LeafCenter ?
   
   2. There are `orchestration`'s child `name` in old configuration. Can we keep the `orchestration.name` and add `orchestration.registry.name` `orchestration.config.name` `orchestration.leaf.name` ?
   
   We're very confused about this, Looking forward to your advice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services