You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/23 18:46:24 UTC

[GitHub] [skywalking] mikhail-dr opened a new issue #7547: [INFRA] Support for Block Comment Style for Python files

mikhail-dr opened a new issue #7547:
URL: https://github.com/apache/skywalking/issues/7547


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [ X] Question or discussion
   - [ ] Bug
   - [ X] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   
   There does not appear to be any way to configure the tool to use block comment for the insertion of copyright notice into Python files? The only way I can use block comments for that is if I modify `styles.yaml` and `languages.yaml` files?
   ___
   ### Bug
   - Which version of SkyWalking, OS, and JRE?
   
   - Which company or project?
   
   - What happened?
   If possible, provide a way to reproduce the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - I would like to use block style comments, rather than `#` inline comments to insert copyright notices into Python files. It would be great if such possibility or config option were available in the tool.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904263790


   > do you mean to say that it is already somehow possible to override the default styles.yaml and languages.yaml files? if so, please, let me know how, i found no information on that. thanks.
   
   I think we should have at least. We have this similar feature in other images, same for this too. Let's wait for @kezhenxu94 's confirmation. We are closing to eye 0.2.0. Let's see.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904228670


   @kezhenxu94 yes, correct, docstrings, `"""`. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-905417340


   @kezhenxu94 any further comments/updates on this? thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904250213


   well, this was just an internal preference, to use docstring `"""`, rather than `#` comments for copyright notice. while i can change the two yaml files to use `"""` docstring and rebuild the binary (i did do that today and that works), I thought it would be better if that was an official option so that folks could use your official docker image. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-905421588


   ok, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904225505


   @mikhail-dr IIRC Python doesn't allow multi line comments, do you mean docstring?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904242656


   Hi, my question is which? Is recommended in any Python doc or project? If so, it is reasonable to accept this.
   At least we should be able to find more than one top level open source Python projects using in this way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904260533


   @wu-sheng do you mean to say that it is already somehow possible to override the default `styles.yaml` and `languages.yaml` files? if so, please, let me know how, i found no information on that. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904259235


   @kezhenxu94 I noticed no doc on https://hub.docker.com/r/apache/skywalking-eyes. Could you update it?
   I think we should or already have yaml override for our image.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904233390


   > @kezhenxu94 yes, correct, docstrings, `"""`. thanks.
   
   Could do share whicg project uses this style?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] wu-sheng edited a comment on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904233390


   > @kezhenxu94 yes, correct, docstrings, `"""`. thanks.
   
   Could do share which project uses this style?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] mikhail-dr commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
mikhail-dr commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-904241475


   we'd like to use `"""`-style docstring, rather than `#`-style comments for Python files. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #7547: [INFRA] Support for Block Comment Style for Python files

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #7547:
URL: https://github.com/apache/skywalking/issues/7547#issuecomment-905419349


   > @kezhenxu94 any further comments/updates on this? thanks.
   
   @mikhail-dr those files `styles.yaml` and `languages.yaml` are not overridable for now, and I didn't expect users to override them at all, we might consider another config to allow users to specify using block comments or inline comments


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org