[GitHub] [accumulo] ctubbsii commented on a change in pull request #2427: WIP - Migrate from JUnit 4 to JUnit 5

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2427:
URL: https://github.com/apache/accumulo/pull/2427#discussion_r790018859



##########
File path: pom.xml
##########
@@ -610,6 +605,16 @@
         <artifactId>jline</artifactId>
         <version>3.20.0</version>
       </dependency>
+      <dependency>
+        <groupId>org.junit.jupiter</groupId>
+        <artifactId>junit-jupiter-api</artifactId>
+        <version>5.8.2</version>
+      </dependency>
+      <dependency>
+        <groupId>org.junit.vintage</groupId>
+        <artifactId>junit-vintage-engine</artifactId>
+        <version>5.8.2</version>
+      </dependency>

Review comment:
       It might be possible to manage all the junit dependencies with a single bom:
   
   ```suggestion
         <dependency>
           <groupId>org.junit</groupId>
           <artifactId>junit-bom</artifactId>
           <version>5.8.2</version>
           <type>pom</type>
           <scope>import</scope>
         </dependency>
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org