You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-commits@lucene.apache.org by sh...@apache.org on 2008/08/25 14:34:10 UTC

svn commit: r688705 - /lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java

Author: shalin
Date: Mon Aug 25 05:34:10 2008
New Revision: 688705

URL: http://svn.apache.org/viewvc?rev=688705&view=rev
Log:
Small fix -- a null or empty name is not allowed in JMX. Don't put a name to info mbean if it is not supplied.

Modified:
    lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java

Modified: lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java
URL: http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java?rev=688705&r1=688704&r2=688705&view=diff
==============================================================================
--- lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java (original)
+++ lucene/solr/trunk/src/java/org/apache/solr/core/JmxMonitoredMap.java Mon Aug 25 05:34:10 2008
@@ -184,7 +184,9 @@
           throws MalformedObjectNameException {
     Hashtable<String, String> map = new Hashtable<String, String>();
     map.put("type", key);
-    map.put("id", infoBean.getName());
+    if (infoBean.getName() != null && !"".equals(infoBean.getName())) {
+      map.put("id", infoBean.getName());
+    }
     return ObjectName.getInstance(jmxRootName, map);
   }