You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/19 09:16:29 UTC
[GitHub] [lucene-solr] donnerpeter opened a new pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
donnerpeter opened a new pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
FST traversal is the hottest spot in Hunspell, let's call it less frequently
# Solution
Add a hash-based Bloom filter before FST traversal to avoid it.
# Tests
None. `TestPerformance.de` became ~30% faster, `fr` — ~15% faster.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405#discussion_r579416054
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -160,7 +160,8 @@ public void testDictionariesLoadSuccessfully() throws Exception {
try {
Dictionary dic = loadDictionary(aff);
totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
- totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
+ totalWords.addAndGet(
+ RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
Review comment:
Yes, that's from wooorm and LibreOffice dictionaries
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
Posted by GitBox <gi...@apache.org>.
dweiss commented on a change in pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405#discussion_r579415213
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -160,7 +160,8 @@ public void testDictionariesLoadSuccessfully() throws Exception {
try {
Dictionary dic = loadDictionary(aff);
totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
- totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
+ totalWords.addAndGet(
+ RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
Review comment:
These are actual numbers from the dictionaries you checked, correct? The code doesn't seem to have an upper limit (only highestOneBit(words*10)). I hope the dictionaries out there are reasonable (lexicon of spoken human languages certainly is bound, so I think it's a sane assumption).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
Posted by GitBox <gi...@apache.org>.
dweiss merged pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405#discussion_r579170824
##########
File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java
##########
@@ -249,7 +254,9 @@ public void close() {
readAffixFile(affixStream, decoder, flagEnumerator);
// read dictionary entries
- IndexOutput unsorted = mergeDictionaries(tempDir, tempFileNamePrefix, dictionaries, decoder);
+ IndexOutput unsorted = tempDir.createTempOutput(tempFileNamePrefix, "dat", IOContext.DEFAULT);
+ int wordCount = mergeDictionaries(dictionaries, decoder, unsorted);
Review comment:
Moved `unsorted` calculation outside of `mergeDictionaries` to be able to return `wordCount` instead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2405: LUCENE-9790: Hunspell: avoid slow dictionary lookup if the word's hash isn't there
Posted by GitBox <gi...@apache.org>.
donnerpeter commented on a change in pull request #2405:
URL: https://github.com/apache/lucene-solr/pull/2405#discussion_r579171729
##########
File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestAllDictionaries.java
##########
@@ -160,7 +160,8 @@ public void testDictionariesLoadSuccessfully() throws Exception {
try {
Dictionary dic = loadDictionary(aff);
totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
- totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
+ totalWords.addAndGet(
+ RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
Review comment:
About ~7% memory usage increase on average, at most 512KB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org