You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/02/20 19:35:44 UTC
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15256
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
[test] Fix ASAN failure when Hive Metastore connections are retried.
I saw an ASAN test failure that occured when there was a failure
to connect to the Hive Metastore. This may not fix the connection
issue, but it fixes the unsafe ASAN failure and allows the test to
continue.
Below is a sample of the log:
W0220 18:46:15.548344 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
I0220 18:46:16.549294 18002 client.cc:56] TSocket::open() error on socket (after THRIFT_POLL) <Host: 127.0.0.1 Port: 45269>Connection refused
W0220 18:46:16.549479 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3: runtime error: left shift of 100 by 26 places cannot be represented in type 'int'
#0 0x7f527299d77b in kudu::thrift::HaClient<kudu::hms::HmsClient>::Execute(std::function<kudu::Status (kudu::hms::HmsClient*)>)::'lambda'()::operator()() const /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3
#1 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#2 0x7f526b6f21f4 in kudu::ThreadPool::DispatchThread() /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/threadpool.cc:685:22
#3 0x7f526b70c992 in boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::ThreadPool>, boost::_bi::list1<boost::_bi::value<kudu::ThreadPool*> > >::operator()() /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/bind/bind.hpp:1222:16
#4 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#5 0x7f526b6d812a in kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/thread.cc:675:3
#6 0x7f5267917183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312
#7 0x7f526742dffc in clone sysdeps/unix/sysv/linux/x86_64/clone.S:111
Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3 in
---
M src/kudu/thrift/client.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15256/1
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h@260
PS1, Line 260: consecutive_reconnect_failures_
Maybe, instead of relying on consecutive_reconnect_failures_ to be small enough to fit (100 << count) to int64_t, it's worth limit the 'count' to be max(consecutive_reconnect_failures_, 16) ? And then it's possible to remove the MonoDelta::FromSeconds(10) upper boundary (instead, it will be 6553600 ms)
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 20:00:32 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
[test] Fix ASAN failure when Hive Metastore connections are retried.
I saw an ASAN test failure that occured when there was a failure
to connect to the Hive Metastore. This may not fix the connection
issue, but it fixes the unsafe ASAN failure and allows the test to
continue.
Below is a sample of the log:
W0220 18:46:15.548344 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
I0220 18:46:16.549294 18002 client.cc:56] TSocket::open() error on socket (after THRIFT_POLL) <Host: 127.0.0.1 Port: 45269>Connection refused
W0220 18:46:16.549479 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3: runtime error: left shift of 100 by 26 places cannot be represented in type 'int'
#0 0x7f527299d77b in kudu::thrift::HaClient<kudu::hms::HmsClient>::Execute(std::function<kudu::Status (kudu::hms::HmsClient*)>)::'lambda'()::operator()() const /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3
#1 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#2 0x7f526b6f21f4 in kudu::ThreadPool::DispatchThread() /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/threadpool.cc:685:22
#3 0x7f526b70c992 in boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::ThreadPool>, boost::_bi::list1<boost::_bi::value<kudu::ThreadPool*> > >::operator()() /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/bind/bind.hpp:1222:16
#4 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#5 0x7f526b6d812a in kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/thread.cc:675:3
#6 0x7f5267917183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312
#7 0x7f526742dffc in clone sysdeps/unix/sysv/linux/x86_64/clone.S:111
Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3 in
Reviewed-on: http://gerrit.cloudera.org:8080/15256
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/thrift/client.h
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 4
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15256
to look at the new patch set (#2).
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
[test] Fix ASAN failure when Hive Metastore connections are retried.
I saw an ASAN test failure that occured when there was a failure
to connect to the Hive Metastore. This may not fix the connection
issue, but it fixes the unsafe ASAN failure and allows the test to
continue.
Below is a sample of the log:
W0220 18:46:15.548344 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
I0220 18:46:16.549294 18002 client.cc:56] TSocket::open() error on socket (after THRIFT_POLL) <Host: 127.0.0.1 Port: 45269>Connection refused
W0220 18:46:16.549479 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3: runtime error: left shift of 100 by 26 places cannot be represented in type 'int'
#0 0x7f527299d77b in kudu::thrift::HaClient<kudu::hms::HmsClient>::Execute(std::function<kudu::Status (kudu::hms::HmsClient*)>)::'lambda'()::operator()() const /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3
#1 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#2 0x7f526b6f21f4 in kudu::ThreadPool::DispatchThread() /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/threadpool.cc:685:22
#3 0x7f526b70c992 in boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::ThreadPool>, boost::_bi::list1<boost::_bi::value<kudu::ThreadPool*> > >::operator()() /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/bind/bind.hpp:1222:16
#4 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#5 0x7f526b6d812a in kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/thread.cc:675:3
#6 0x7f5267917183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312
#7 0x7f526742dffc in clone sysdeps/unix/sysv/linux/x86_64/clone.S:111
Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3 in
---
M src/kudu/thrift/client.h
1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15256/2
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo, Hao Hao, Bankim Bhavsar,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15256
to look at the new patch set (#3).
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
[test] Fix ASAN failure when Hive Metastore connections are retried.
I saw an ASAN test failure that occured when there was a failure
to connect to the Hive Metastore. This may not fix the connection
issue, but it fixes the unsafe ASAN failure and allows the test to
continue.
Below is a sample of the log:
W0220 18:46:15.548344 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
I0220 18:46:16.549294 18002 client.cc:56] TSocket::open() error on socket (after THRIFT_POLL) <Host: 127.0.0.1 Port: 45269>Connection refused
W0220 18:46:16.549479 18002 client.h:351] Failed to connect to Hive Metastore (127.0.0.1:45269): Network error: failed to open Hive Metastore connection: socket open() error: Connection refused
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3: runtime error: left shift of 100 by 26 places cannot be represented in type 'int'
#0 0x7f527299d77b in kudu::thrift::HaClient<kudu::hms::HmsClient>::Execute(std::function<kudu::Status (kudu::hms::HmsClient*)>)::'lambda'()::operator()() const /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3
#1 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#2 0x7f526b6f21f4 in kudu::ThreadPool::DispatchThread() /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/threadpool.cc:685:22
#3 0x7f526b70c992 in boost::_bi::bind_t<void, boost::_mfi::mf0<void, kudu::ThreadPool>, boost::_bi::list1<boost::_bi::value<kudu::ThreadPool*> > >::operator()() /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/bind/bind.hpp:1222:16
#4 0x7f526e44ead7 in boost::function0<void>::operator()() const /home/jenkins-slave/workspace/kudu-master/0/thirdparty/installed/uninstrumented/include/boost/function/function_template.hpp:770:14
#5 0x7f526b6d812a in kudu::Thread::SuperviseThread(void*) /home/jenkins-slave/workspace/kudu-master/0/src/kudu/util/thread.cc:675:3
#6 0x7f5267917183 in start_thread /build/eglibc-SvCtMH/eglibc-2.19/nptl/pthread_create.c:312
#7 0x7f526742dffc in clone sysdeps/unix/sysv/linux/x86_64/clone.S:111
Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior /home/jenkins-slave/workspace/kudu-master/0/src/kudu/thrift/client.h:204:3 in
---
M src/kudu/thrift/client.h
1 file changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15256/3
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h@260
PS1, Line 260: consecutive_reconnect_failures_
> Maybe, instead of relying on consecutive_reconnect_failures_ to be small en
I think the 10s capped is still a functional expectation.
FWIW MonoDelta::FromMilliseconds expects an int64_t.
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h@260
PS1, Line 260: int64_t
> Nit: C++ static_cast<> instead.
I used int64_t given thats what MonoDelta::FromMilliseconds expects.
I could use LL as a suffix to get the equivalent type.
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 20:13:54 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15256/2/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/2/src/kudu/thrift/client.h@260
PS2, Line 260: reconnect_after_ = MonoTime::Now() + ComputeExponentialBackoff(consecutive_reconnect_failures_);
> this line seems to be too long
Done
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 22:33:56 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 23:31:01 +0000
Gerrit-HasComments: No
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h@260
PS1, Line 260: consecutive_reconnect_failures_
> I think the 10s capped is still a functional expectation.
It's absolutely thrilling that we have so many different implementations of exponential backoff. Here's one from src/kudu/rpc/rpc.cc:
MonoDelta ComputeExponentialBackoff(int num_attempts) {
return MonoDelta::FromMilliseconds(
(10 + rand() % 10) * static_cast<int>(
std::pow(2.0, std::min(8, num_attempts - 1))));
}
Agreed with Alexey that left-shifting by what is effectively an unbounded amount feels wrong, so maybe just expressing this differently would be better. It's not a hot path.
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 20:20:51 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15256/2/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/2/src/kudu/thrift/client.h@260
PS2, Line 260: reconnect_after_ = MonoTime::Now() + ComputeExponentialBackoff(consecutive_reconnect_failures_);
this line seems to be too long
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 22:31:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] [test] Fix ASAN failure when Hive Metastore connections are retried.
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15256 )
Change subject: [test] Fix ASAN failure when Hive Metastore connections are retried.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h
File src/kudu/thrift/client.h:
http://gerrit.cloudera.org:8080/#/c/15256/1/src/kudu/thrift/client.h@260
PS1, Line 260: int64_t
Nit: C++ static_cast<> instead.
Is a suffix L an option?
--
To view, visit http://gerrit.cloudera.org:8080/15256
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1282ad36027b314d090e5a2dffdc3854002af761
Gerrit-Change-Number: 15256
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 20 Feb 2020 19:38:12 +0000
Gerrit-HasComments: Yes