You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "aaronlindsey (GitHub)" <gi...@apache.org> on 2019/08/16 00:42:42 UTC
[GitHub] [geode] aaronlindsey opened pull request #3938: GEODE-7091:
Add Micrometer binders to meter registry
Add the following Micrometer binders:
- JvmGcMetrics
- ProcessorMetrics
- JvmThreadMetrics
- UptimeMetrics
- FileDescriptorMetrics
Ignore FileDescriptorMetrics binder tests on Windows
Co-authored-by: Aaron Lindsey <al...@pivotal.io>
Co-authored-by: Kirk Lund <kl...@apache.org>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] kirklund closed pull request #3938: GEODE-7091: Add
Micrometer binders to meter registry
Posted by "kirklund (GitHub)" <gi...@apache.org>.
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/3938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] aaronlindsey commented on issue #3938: GEODE-7091:
Add Micrometer binders to meter registry
Posted by "aaronlindsey (GitHub)" <gi...@apache.org>.
This is the same PR as #3935, except that the FileDescriptorMetrics binder tests are ignored on Windows. @kirklund @demery-pivotal @mhansonp
[ Full content available at: https://github.com/apache/geode/pull/3938 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org