You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/01 17:16:04 UTC
[GitHub] [zookeeper] belugabehr opened a new pull request #1240:
ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
belugabehr opened a new pull request #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1240: ZOOKEEPER-3708:
Move Logging Code into Logging Guard in Learner
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240#issuecomment-581277326
@anmolnar
I think it is not worth to port this kind of changes to 3.5.
We can do it to 3.6 in order to ease cherry picks from master branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #1240: ZOOKEEPER-3708: Move
Logging Code into Logging Guard in Learner
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #1240: ZOOKEEPER-3708: Move
Logging Code into Logging Guard in Learner
Posted by GitBox <gi...@apache.org>.
anmolnar commented on issue #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240#issuecomment-581332328
@eolivelli I wasn't sure about that either, but the patch does not do any harm and my thinking was that until we don't have a stable release on 3.6, we don't need to be super conservative with committing to 3.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #1240: ZOOKEEPER-3708: Move
Logging Code into Logging Guard in Learner
Posted by GitBox <gi...@apache.org>.
anmolnar commented on issue #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240#issuecomment-581222205
Committed to 3.5, 3.6 and master branches.
Thanks @belugabehr !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] anmolnar commented on issue #1240: ZOOKEEPER-3708: Move
Logging Code into Logging Guard in Learner
Posted by GitBox <gi...@apache.org>.
anmolnar commented on issue #1240: ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner
URL: https://github.com/apache/zookeeper/pull/1240#issuecomment-581332936
Otherwise you're probably right. We might want to lock down 3.5 and commit only security and bug fixes from now on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services