You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/01/23 22:31:52 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1161: [SYSTEMDS-2747] Federated Quaternary Operation WDivMM and WUMM

mboehm7 commented on pull request #1161:
URL: https://github.com/apache/systemds/pull/1161#issuecomment-766189970


   LGTM - thanks for the patch @ywcb00. I made minor improvements regarding formatting, and added a check for row-partitioned federated matrices in the new instructions. For the future, if you have so many test scripts at expression level, consider a consolidated test script with multiple branches and an input parameter that controls the test.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org