You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/12 03:41:12 UTC
[kudu-CR] thirdparty: fix build curl some more
Hello Alexey Serbin, Grant Henke,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13593
to review the following change.
Change subject: thirdparty: fix build_curl some more
......................................................................
thirdparty: fix build_curl some more
As written, the function would misbehave if krb5-config wasn't found at all.
Change-Id: Ic70880b7a361ce9768748a0e3c6afaf0b8dc3ca0
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/13593/1
--
To view, visit http://gerrit.cloudera.org:8080/13593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic70880b7a361ce9768748a0e3c6afaf0b8dc3ca0
Gerrit-Change-Number: 13593
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] thirdparty: fix build curl some more
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13593 )
Change subject: thirdparty: fix build_curl some more
......................................................................
thirdparty: fix build_curl some more
As written, the function would misbehave if krb5-config wasn't found at all.
Change-Id: Ic70880b7a361ce9768748a0e3c6afaf0b8dc3ca0
Reviewed-on: http://gerrit.cloudera.org:8080/13593
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70880b7a361ce9768748a0e3c6afaf0b8dc3ca0
Gerrit-Change-Number: 13593
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] thirdparty: fix build curl some more
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13593 )
Change subject: thirdparty: fix build_curl some more
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13593
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic70880b7a361ce9768748a0e3c6afaf0b8dc3ca0
Gerrit-Change-Number: 13593
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 12 Jun 2019 03:43:37 +0000
Gerrit-HasComments: No