You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Arun Patidar (JIRA)" <ji...@apache.org> on 2009/07/20 12:03:14 UTC
[jira] Created: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
-------------------------------------------------------------------------------------------------------------
Key: OFBIZ-2741
URL: https://issues.apache.org/jira/browse/OFBIZ-2741
Project: OFBiz
Issue Type: Bug
Components: specialpurpose/ecommerce
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Arun Patidar
Priority: Minor
On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Joe Eckard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733226#action_12733226 ]
Joe Eckard commented on OFBIZ-2741:
-----------------------------------
I noticed this last week also... but I have a different fix (see patch). The question is: why were we always resetting the ship info each time an item was modified, and do we need to handle that conditionally now?
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Attachments: OFBIZ-2741.patch
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Mayur reassigned OFBIZ-2741:
----------------------------------
Assignee: Vikas Mayur
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Joe Eckard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742866#action_12742866 ]
Joe Eckard commented on OFBIZ-2741:
-----------------------------------
Create a PO for DemoSupplier consisting of 1 item. Finalize order, continue through selecting the shipping address, then go back to order items and change quantity and finalize again.
I am working on a custom codebase that sets order info before items are added, so I can't easily provide examples for those scenarios. The applied patch only addresses the scenario where item quantities are modified for sales orders.
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733260#action_12733260 ]
Arun Patidar commented on OFBIZ-2741:
-------------------------------------
Thanks Joe for looking into it, I tested your patch but it does not work properly for me. I am attaching new patch which is working in both cases (update qty and remove item).
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Attachments: OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-2741:
--------------------------------
Attachment: OFBIZ-2741.patch
Here is patch for this.
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Attachments: OFBIZ-2741.patch
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734536#action_12734536 ]
Vikas Mayur commented on OFBIZ-2741:
------------------------------------
Thanks Arun, Joe.
Arun your patch is in trunk rev. 796992 as well as in release09.04 (I did not tested in release though but it should be fine) rev. 796993
Vikas
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Joe Eckard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742566#action_12742566 ]
Joe Eckard commented on OFBIZ-2741:
-----------------------------------
This bug is still present - the line:
cart.setItemShipGroupQty(item, quantity, 0);
in the applied patch can be reverted - it is unnecessary because setItemShipGroupQty() is already called within item.setQuantity(), and it doesn't address the problem.
The code that is clearing the shipping contact mech when an item is added (or the quantity is changed) is ShoppingCart.clearItemShipInfo() followed directly by ShoppingCart.cleanUpShipGroups(). This happens when resetShipGroups is set to true, which is the default value when calling setQuantity() on a ShoppingCartItem.
Also, it only seems to do this when there is only 1 line item in the cart - when there are multiple line items, it doesn't clear the shipping contact mech.
I was working on a patch but ran out of time, adding notes here so I can come back to it or someone else can take a quick look.
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-2741:
--------------------------------
Attachment: OFBIZ-2741.patch
Here is improved patch for this.
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Joe Eckard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Eckard updated OFBIZ-2741:
------------------------------
Attachment: OFBIZ-2741.2.patch
Updated patch. A side effect will be that empty ship groups are not auto-cleared when empty, you have to explicitly request this with finalizeMode=removeEmptyShipGroups during checkout. Not committing right away in case there are objections to this behavior.
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.2.patch, OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742722#action_12742722 ]
Vikas Mayur commented on OFBIZ-2741:
------------------------------------
Could you please add steps to reproduce this issue?
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884192#action_12884192 ]
Jacques Le Roux commented on OFBIZ-2741:
----------------------------------------
Should we not take care of this?
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 09.04, SVN trunk
> Reporter: Arun Patidar
> Assignee: Vikas Mayur
> Priority: Minor
> Attachments: OFBIZ-2741.2.patch, OFBIZ-2741.patch, OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2741) Information of shipping method and
sales tax are remove from cart when we update shopping cart item quantity.
Posted by "Joe Eckard (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joe Eckard updated OFBIZ-2741:
------------------------------
Attachment: sci-patch.txt
> Information of shipping method and sales tax are remove from cart when we update shopping cart item quantity.
> -------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-2741
> URL: https://issues.apache.org/jira/browse/OFBIZ-2741
> Project: OFBiz
> Issue Type: Bug
> Components: specialpurpose/ecommerce
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Attachments: OFBIZ-2741.patch, sci-patch.txt
>
>
> On update cart item quantity after selecting shipping method, Informations of shipping method and sales tax removes if there is only one item in cart.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.