[jira] [Commented] (THRIFT-1296) SSL detection is broken

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13101044#comment-13101044 ] 

Hudson commented on THRIFT-1296:
--------------------------------

Integrated in Thrift #255 (See [https://builds.apache.org/job/Thrift/255/])
    THRIFT-1296 SSL detection is broken

mingw toolchain used to build "Thrift Compiler for Windows"
does not support libcrypto, so we just check if we building the cpp library

roger : http://svn.apache.org/viewvc/?view=rev&rev=1167013
Files : 
* /thrift/trunk/.gitignore
* /thrift/trunk/configure.ac


> SSL detection is broken
> -----------------------
>
>                 Key: THRIFT-1296
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1296
>             Project: Thrift
>          Issue Type: Bug
>          Components: Build Process
>    Affects Versions: 0.7
>         Environment: Ubuntu 10.04
> Building Thrift against a custom toolchain (not using system packages/libraries)
>            Reporter: Diwaker Gupta
>            Assignee: Jake Farrell
>         Attachments: THRIFT-1296.patch, thrift-1296.patch
>
>
> When using shared libraries, libssl has dependencies on libcrypto. The current autoconf macro for checking SSL doesn't do the job:
> {noformat}
> configure:23665: checking for SSL_ctrl in -lssl
> configure:23690: x86_64-unknown-linux-gnu-g++ -o conftest -O2 -Wall -pipe  -L<snip> -I<snip>  -O2 -Wall -pipe conftest.cpp -lssl  -lrt -lpthread  >&5
> x86_64-unknown-linux-gnu/bin/ld: warning: libcrypto.so.1.0.0, needed by <snip>/usr/lib/libssl.so, not found (try using -rpath or -rpath-link)
> {noformat}
> The following patch fixes this problem:
> {noformat}
> +--- configure.ac
> ++++ configure.ac
> +@@ -312,7 +312,7 @@ dnl of the POSIX Real-Time Extensions.  This seems necessary on Linux,
> + dnl and we haven't yet found a system where this is a problem.
> + AC_CHECK_LIB(rt, clock_gettime)
> + AC_CHECK_LIB(socket, setsockopt)
> +-AC_CHECK_LIB(ssl, SSL_ctrl)
> ++AC_CHECK_LIB(ssl, SSL_ctrl,[LIBS="-lssl -lcrypto $LIBS"],,-lcrypto)
> +
> + AC_TYPE_INT16_T
> + AC_TYPE_INT32_T
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira