You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "jt2594838 (via GitHub)" <gi...@apache.org> on 2024/09/11 01:52:36 UTC
[PR] Support dictionary encoding for STRING data type. [tsfile]
jt2594838 opened a new pull request, #238:
URL: https://github.com/apache/tsfile/pull/238
Support dictionary encoding for STRING data type.
Move datatype-encoding map into TsFile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support dictionary encoding for STRING data type. [tsfile]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #238:
URL: https://github.com/apache/tsfile/pull/238#issuecomment-2342473792
## [Codecov](https://app.codecov.io/gh/apache/tsfile/pull/238?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `95.00000%` with `2 lines` in your changes missing coverage. Please review.
> Project coverage is 62.33%. Comparing base [(`a90fe9a`)](https://app.codecov.io/gh/apache/tsfile/commit/a90fe9ac18db2b422dc3e02f964e0a81c192470e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`fdc362e`)](https://app.codecov.io/gh/apache/tsfile/commit/fdc362e846d63f768ac698b36edaf77fae2a6512?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files with missing lines](https://app.codecov.io/gh/apache/tsfile/pull/238?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/tsfile/encoding/encoder/TSEncodingBuilder.java](https://app.codecov.io/gh/apache/tsfile/pull/238?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Fencoding%2Fencoder%2FTSEncodingBuilder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9lbmNvZGluZy9lbmNvZGVyL1RTRW5jb2RpbmdCdWlsZGVyLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../apache/tsfile/file/metadata/enums/TSEncoding.java](https://app.codecov.io/gh/apache/tsfile/pull/238?src=pr&el=tree&filepath=java%2Ftsfile%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Ftsfile%2Ffile%2Fmetadata%2Fenums%2FTSEncoding.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-amF2YS90c2ZpbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3RzZmlsZS9maWxlL21ldGFkYXRhL2VudW1zL1RTRW5jb2RpbmcuamF2YQ==) | 97.43% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/tsfile/pull/238?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #238 +/- ##
===========================================
+ Coverage 62.28% 62.33% +0.04%
===========================================
Files 476 476
Lines 31614 31653 +39
Branches 4107 4107
===========================================
+ Hits 19692 19730 +38
- Misses 11475 11476 +1
Partials 447 447
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/tsfile/pull/238?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support dictionary encoding for STRING data type. [tsfile]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #238:
URL: https://github.com/apache/tsfile/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org