[GitHub] [skywalking] mrproliu commented on pull request #9857: Support `slowTrace` in LAL

[GitBox <gi...@apache.org>]

mrproliu commented on PR #9857:
URL: https://github.com/apache/skywalking/pull/9857#issuecomment-1294430822

   
   > But in ebpf, we may sample all requests with trace headers, rather than only slow, right?
   
   Yes, In the eBPF we can sample all kinds of requests with trace headers, for now, we only have the `slow` cases. There may be more in the future.
   
    > And in the record, it would be SampledTraceRecord, with a column of sampling reason is slow. WDYT?
   
   It's good to be, when the rover agent uploads the logs, they need to add a `reason` field to confirm the sampling reason. But for the GraphQL query, for now, we only could be ordering the record. We need a filter mechanism to filter the `reason` filed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org