[GitHub] [trafficcontrol] rob05c opened a new pull request #5119: Fix ORT Topology Generation to Omit OFFLINE, Other CDNs, and MSO Origins without DeliveryServiceServers

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #5119:
URL: https://github.com/apache/trafficcontrol/pull/5119


   Fixes ORT generation for Topology DSes to omit parents that are
   not ONLINE or REPORTED, as well as parents assigned to other CDNs.
   
   Also fixes Topologies on MSO Delivery Services to consider
   Delivery Service Servers, and omit Origins not assigned to a DS.
   
   Includes tests.
   No docs, no interface change.
   No changelog, no interface change, and bug is not in an existing release.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops ORT
   
   ## What is the best way to verify this PR?
   Run tests.
   Run ORT with a Topology DS, with OFFLINE Mids in the Topology, and Mids in other CDNs in the Topology, and with MSO Delivery Services with assigned Origin Servers, and with Origin Servers belonging to other DSes which aren't assigned; verify OFFLINE and other-cdn mids are not added to parent.config, verify MSO origins are in parent.config, verify origins on other DSes are not on the DS parent.config line.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   - master
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #5119: Fix ORT Topology Generation to Omit OFFLINE, Other CDNs, and MSO Origins without DeliveryServiceServers

[GitBox <gi...@apache.org>]

rob05c commented on a change in pull request #5119:
URL: https://github.com/apache/trafficcontrol/pull/5119#discussion_r501369301



##########
File path: lib/go-atscfg/parentdotconfig.go
##########
@@ -1325,3 +1346,48 @@ func GetDSOrigins(dses map[int]tc.DeliveryServiceNullableV30) (map[int]*OriginUR
 	}
 	return dsOrigins, nil
 }
+
+func makeDSOrigins(dsses []tc.DeliveryServiceServer, dses []tc.DeliveryServiceNullableV30, servers []tc.ServerNullable) map[DeliveryServiceID]map[ServerID]struct{} {

Review comment:
       It isn't strictly necessary to do this filtering. But it will make it easier to change ORT to use the origins table or any other DSS alternative in the future.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #5119: Fix ORT Topology Generation to Omit OFFLINE, Other CDNs, and MSO Origins without DeliveryServiceServers

[GitBox <gi...@apache.org>]

rawlinp merged pull request #5119:
URL: https://github.com/apache/trafficcontrol/pull/5119


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org