You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/29 11:23:17 UTC

[GitHub] [cordova-ios] jcesarmobile opened a new pull request #731: CB-14135(ios): escape all single quotes from name in Podfile

jcesarmobile opened a new pull request #731: CB-14135(ios): escape all single quotes from name in Podfile
URL: https://github.com/apache/cordova-ios/pull/731
 
 
   
   
   ### Motivation and Context
   If the app name have multiple single quotes the Podfile is not correctly generated
   
   
   ### Description
   <!-- Describe your changes in detail -->
   make the escape function to escape all occurrences and not just the first one
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   added a new test
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org